From: "Heiko Stübner" <heiko@sntech.de>
To: Doug Anderson <dianders@chromium.org>
Cc: sre@kernel.org, Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH v2 2/3] power: gpio-charger: add device tree support
Date: Tue, 23 Sep 2014 14:03:17 +0200 [thread overview]
Message-ID: <1549304.qklrgkYl3q@phil> (raw)
In-Reply-To: <CAD=FV=W6q7wMDWWDkwdC_KF4EHJt2q8afxSGCpPEC+Nk2Jp2Ag@mail.gmail.com>
Am Montag, 22. September 2014, 09:48:33 schrieb Doug Anderson:
> > @@ -196,6 +255,7 @@ static struct platform_driver gpio_charger_driver = {
> >
> > .name = "gpio-charger",
> > .owner = THIS_MODULE,
> > .pm = &gpio_charger_pm_ops,
> >
> > + .of_match_table = of_match_ptr(gpio_charger_match),
>
> Given that you don't have any #ifdefs with "CONFIG_OF", I think
> gpio_charger_match will always exist. It seems like you should remove
> the of_match_ptr or add some #ifdefs. I can't quite keep up with what
> the currently suggested best practice is here, though.
I've kept the of_match_ptr in v3. The dt parsing functions (of_read_foo,...)
define stubs for the !CONFIG_OF case which we use here in this case and
of_match_ptr is also defined differently for both OF and !OF, so it feels like
it should be there ;-)
Heiko
next prev parent reply other threads:[~2014-09-23 12:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 20:05 [PATCH v2 0/3] gpio-charger: add devicetree support Heiko Stuebner
2014-09-21 20:05 ` [PATCH v2 1/3] dt-bindings: document gpio-charger bindings Heiko Stuebner
2014-09-22 16:51 ` Doug Anderson
2014-09-21 20:05 ` [PATCH v2 2/3] power: gpio-charger: add device tree support Heiko Stuebner
2014-09-22 16:48 ` Doug Anderson
2014-09-23 12:03 ` Heiko Stübner [this message]
2014-09-23 15:59 ` Doug Anderson
2014-09-21 20:05 ` [PATCH v2 3/3] power: gpio-charger: do not use gpio value directly Heiko Stuebner
2014-09-22 16:50 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1549304.qklrgkYl3q@phil \
--to=heiko@sntech.de \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox