From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2DB29C71153 for ; Mon, 28 Aug 2023 18:43:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233065AbjH1Smj (ORCPT ); Mon, 28 Aug 2023 14:42:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58600 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233061AbjH1SmV (ORCPT ); Mon, 28 Aug 2023 14:42:21 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3370BF for ; Mon, 28 Aug 2023 11:42:17 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b9d07a8d84so51935791fa.3 for ; Mon, 28 Aug 2023 11:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693248136; x=1693852936; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4crfFK9rbkvRAtTGcELIJgSDL7K1RAR2VvV1PTA/yS8=; b=UufLu8sEdTBwkzCCLhJYuXW+vIpDt5IVesFf31AZIV4tBqaWT78XsJU8vMBZhsBeXU 5BAxgvCKb31UscQ68QGvnBEHkhhRR1nsjV/FzpmOFcCcrNCyCh0v97MK61a0QAeq6Anh f20r3JZ0vPBPq5gMChHQMMuyn6PWFBYnJpfcWavo65xEqw/GgRqjzCVtcGjo9ykCjv5e rqLXtj6XFcEhmCF2ggubbgx7H3KyRDKvbBiqWKjaUM0yWLMI9DmCcfrIMrJZb2ThbjNG +gwDrCueai5hwfO04wXYLPF4Ffvt1AIhjOTGy2DQ2zaAGFy0T316pzzxv6//1KvFwbDe uwXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693248136; x=1693852936; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4crfFK9rbkvRAtTGcELIJgSDL7K1RAR2VvV1PTA/yS8=; b=gp0D/78NzzamqaymEHhp/jBkkJXQ+KFNOn1mf8FIwTWdE8WiXuU5jx+5781P4JtAwN gh3WUiT5Uw46gKazJCeAwl/2dgaqCpGu3vDxjJ/C4VD59I6NWUVYhkITUsjgyY+hYScs hDPtkAwwJnsTHGIzao1sMmR+RlHE7syNQSjRR7j3GxEpr8M+97PURSSUF4TAqI7Ui0eV YUDPzB8H4ABHascEhzzvcaL8KeS0s+MC8J7Cu691bkaD76UNoZ2fQBH66C1wDdcOgcDp KRY2LwLNJsY83tweT4opfjnDmUb6dKTvkHBJi7zOibgYqzhFbjo2UaDrt4XjT5ZpiXQs iNaw== X-Gm-Message-State: AOJu0YwOAS7a+dQjEd0o4GwD2W6Hb/BuUt8q8GTHeOiZq6fXhXSh9fsb CMtf1bYnmzHE/xq5emwzfLgaGA== X-Google-Smtp-Source: AGHT+IFvRz58L4vS5FMH8WGd1L+nXz7BkWynYCX2F5o9W0KTVWQfHur/iCV+WULOlxr+cKlREecxLw== X-Received: by 2002:a2e:2404:0:b0:2bc:dcdb:b5dc with SMTP id k4-20020a2e2404000000b002bcdcdbb5dcmr11162107ljk.39.1693248135751; Mon, 28 Aug 2023 11:42:15 -0700 (PDT) Received: from [192.168.0.22] ([77.252.47.225]) by smtp.gmail.com with ESMTPSA id u22-20020a17090626d600b009a1fd22257fsm4960187ejc.207.2023.08.28.11.42.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 28 Aug 2023 11:42:15 -0700 (PDT) Message-ID: <154b36de-652b-3931-96e6-04e99253a09f@linaro.org> Date: Mon, 28 Aug 2023 20:42:13 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file To: Shenwei Wang , Ulf Hansson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Liam Girdwood , Mark Brown , "imx@lists.linux.dev" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , dl-linux-imx References: <20230818153446.1076027-1-shenwei.wang@nxp.com> <4e2c18e3-b1ed-6361-3998-5de060d2bcf0@linaro.org> <51fe3126-16ba-ade6-b106-e3683f96ad26@linaro.org> Content-Language: en-US From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 28/08/2023 20:39, Shenwei Wang wrote: > > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, August 28, 2023 12:11 PM >> To: Shenwei Wang ; Ulf Hansson >> >> Cc: Rob Herring ; Krzysztof Kozlowski >> ; Conor Dooley ; >> Liam Girdwood ; Mark Brown ; >> imx@lists.linux.dev; devicetree@vger.kernel.org; linux-kernel@vger.kernel.org; >> dl-linux-imx >> Subject: [EXT] Re: [PATCH 1/2] dt-bindings: power: Add regulator-pd yaml file >> On 28/08/2023 16:04, Shenwei Wang wrote: >> >>>>> Are you suggesting to move the regulator-pd to the imx directory and >>>>> add a company prefix to the compatible string? >>>> >>>> There is no such part of iMX processor as such >>>> regulator-power-domain, so I don't recommend that approach. DTS nodes >>>> represent hardware, not your SW layers. >>>> >>> >>> That's not always the case, as we do sometimes need a virtual device. >>> As an example, the "regulator-fixed" acts as a software abstraction >>> layer to create virtual regulator devices by interfacing with the underlying >> GPIO drivers. >> >> Not true. This is a real regulator device. Real hardware on the board. >> You can even see and touch it. >> > > The physical hardware component is the GPIO pin, which is what you can only touch. No. The regulator is the chip. > The regulator functions virtually through software layer above of the GPIO driver. While > we may call it a "regulator" or whatever else, this cannot obscure the fact that the underlying > hardware is just a GPIO pin being used in a specialized way. The regulator is some tiny little box, you can touch and called ti,tps51632 or similar. Best regards, Krzysztof