From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tomer Maimon <tmaimon77@gmail.com>,
avifishman70@gmail.com, tali.perry1@gmail.com, joel@jms.id.au,
venture@google.com, yuenn@google.com, benjaminfair@google.com,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, j.neuschaefer@gmx.net,
zhengbin13@huawei.com
Cc: openbmc@lists.ozlabs.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v1 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string
Date: Tue, 12 Jul 2022 10:15:54 +0200 [thread overview]
Message-ID: <154dd9ef-cb8c-d8d7-ae62-a73bac160089@linaro.org> (raw)
In-Reply-To: <20220711134312.234268-2-tmaimon77@gmail.com>
On 11/07/2022 15:43, Tomer Maimon wrote:
> Add a compatible string for Nuvoton BMC NPCM845 ADC.
>
> Signed-off-by: Tomer Maimon <tmaimon77@gmail.com>
> ---
> .../devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> index 001cf263b7d5..c9e9c5bf5e5b 100644
> --- a/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/nuvoton,npcm750-adc.yaml
> @@ -14,7 +14,10 @@ description:
>
> properties:
> compatible:
> - const: nuvoton,npcm750-adc
> + oneOf:
> + - items:
This does not make sense. oneOf with one item. You also create now list
breaking all existing users/ABI.
You probably wanted an enum here.
> + - const: nuvoton,npcm750-adc
> + - const: nuvoton,npcm845-adc
>
> reg:
> maxItems: 1
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-12 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-11 13:43 [PATCH v1 0/2] iio: adc: npcm: add Arbel NPCM8XX support Tomer Maimon
2022-07-11 13:43 ` [PATCH v1 1/2] dt-bindings: iio: adc: npcm: Add npcm845 compatible string Tomer Maimon
2022-07-11 17:55 ` Rob Herring
2022-07-12 8:03 ` Tomer Maimon
2022-07-12 8:15 ` Krzysztof Kozlowski [this message]
2022-07-12 8:19 ` Tomer Maimon
2022-07-11 13:43 ` [PATCH v1 2/2] iio: adc: npcm: Add NPCM8XX support Tomer Maimon
2022-07-11 14:14 ` Andy Shevchenko
2022-07-11 14:16 ` Andy Shevchenko
2022-07-12 7:59 ` Tomer Maimon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=154dd9ef-cb8c-d8d7-ae62-a73bac160089@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=devicetree@vger.kernel.org \
--cc=j.neuschaefer@gmx.net \
--cc=jic23@kernel.org \
--cc=joel@jms.id.au \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
--cc=zhengbin13@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).