From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stanley Chu Subject: Re: [PATCH v3 4/7] dt-bindings: phy: Add document for phy-mtk-ufs Date: Wed, 13 Mar 2019 18:27:32 +0800 Message-ID: <1552472852.30977.43.camel@mtkswgap22> References: <1551252192-535-1-git-send-email-stanley.chu@mediatek.com> <1551252192-535-6-git-send-email-stanley.chu@mediatek.com> <20190312132524.GA27601@bogus> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190312132524.GA27601@bogus> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Rob Herring Cc: "mark.rutland-5wv7dgnIgG8@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "martin.petersen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org" , "subhashj-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org" , Chun-Hung Wu =?UTF-8?Q?=28=E5=B7=AB=E9=A7=BF=E5=AE=8F=29?= , Kuohong Wang =?UTF-8?Q?=28=E7=8E=8B=E5=9C=8B=E9=B4=BB=29?= , Peter Wang =?UTF-8?Q?=28=E7=8E=8B=E4=BF=A1=E5=8F=8B=29?= , "kishon-l0cyMroinI0@public.gmane.org" , "avri.altman-Sjgp3cTcYWE@public.gmane.org" , "linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "liwei213-hv44wF8Li93QT0dZR+AlfA@public.gmane.org" , "alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org" , Chunfeng Yun =?UTF-8?Q?=28=E4=BA=91=E6=98=A5=E5=B3=B0=29?= pe List-Id: devicetree@vger.kernel.org Hi Rob, On Tue, 2019-03-12 at 21:25 +0800, Rob Herring wrote: > On Wed, Feb 27, 2019 at 03:23:09PM +0800, Stanley Chu wrote: > > Add UFS M-PHY node document for MediaTek SoC chips. > > > > Signed-off-by: Stanley Chu > > --- > > .../devicetree/bindings/phy/phy-mtk-ufs.txt | 35 +++++++++++++++++++ > > 1 file changed, 35 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > > > diff --git a/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > new file mode 100644 > > index 000000000000..5fc22c7fe0bc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/phy/phy-mtk-ufs.txt > > @@ -0,0 +1,35 @@ > > +MediaTek Universal Flash Storage (UFS) M-PHY binding > > +-------------------------------------------------------- > > + > > +UFS M-PHY nodes are defined to describe on-chip UFS M-PHY hardware macro. > > +Each UFS M-PHY node should have its own node. > > + > > +To bind UFS M-PHY with UFS host controller, the controller node should > > +contain a phandle reference to UFS M-PHY node. > > + > > +Required properties for UFS M-PHY nodes: > > +- compatible : Compatible list, contains the following controller: > > + "mediatek,ufs-mphy" > > Needs a more specific compatible string. > > > +- reg : Address and length of the UFS M-PHY register set. > > +- #phy-cells : This property shall be set to 0 > > +- clocks : List of phandle and clock specifier pairs. > > +- clock-names : List of clock input name strings sorted in the same > > + order as the clocks property. "unipro-clk" and > > + "mp-clk" are mandatory. > > + > > +Example: > > + > > + ufs_mphy: ufs_mphy@11fa0000 { > > phy@... > > > + compatible = "mediatek,ufs-mphy"; > > + reg = <0 0x11fa0000 0 0xc000>; > > + #phy-cells = <0>; > > + > > + clocks = <&infracfg_ao INFRACFG_AO_UNIPRO_SCK_CG>, > > + <&infracfg_ao INFRACFG_AO_UFS_MP_SAP_BCLK_CG>; > > + clock-names = "unipro-clk", "mp-clk"; Question about clock name: Shall we drop "-clk" in clock names? For example, clock-names = "unipro-clk", "mp-clk"; becomes clock-names = "unipro", "mp"; ? > > + }; > > + > > + ufshci:ufshci@11270000 { > > + ... > > + phys = <&ufs_mphy>; > > + }; > > -- > > 2.18.0 > > Thanks, Stanley.