From: Chunfeng Yun <chunfeng.yun@mediatek.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Adam Thomson <Adam.Thomson.Opensource@diasemi.com>,
Li Jun <jun.li@nxp.com>,
Badhri Jagan Sridharan <badhri@google.com>,
Hans de Goede <hdegoede@redhat.com>,
Min Guo <min.guo@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node
Date: Fri, 15 Mar 2019 17:32:59 +0800 [thread overview]
Message-ID: <1552642379.10179.138.camel@mhfsdcap03> (raw)
In-Reply-To: <20190315092644.GG7752@kuha.fi.intel.com>
Hi,
On Fri, 2019-03-15 at 11:26 +0200, Heikki Krogerus wrote:
> Hi Chunfeng,
>
> On Fri, Mar 15, 2019 at 05:13:24PM +0800, Chunfeng Yun wrote:
> > I encounter a build error when CONFIG_USB_ROLE_SWITCH is not enabled,
> >
> > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_role_sw_register':
> > ./drivers/usb/mtu3/mtu3_dr.c:460: undefined reference to
> > `usb_role_switch_register'
> > drivers/usb/mtu3/mtu3_dr.o: In function `ssusb_otg_switch_exit':
> > ./drivers/usb/mtu3/mtu3_dr.c:491: undefined reference to
> > `usb_role_switch_unregister'
>
> So you need to add dependency on USB_ROLE_SWITCH, right?
Yes
>
> --- a/drivers/usb/mtu3/Kconfig
> +++ b/drivers/usb/mtu3/Kconfig
> @@ -43,6 +43,7 @@ config USB_MTU3_DUAL_ROLE
> bool "Dual Role mode"
> depends on ((USB=y || USB=USB_MTU3) && (USB_GADGET=y || USB_GADGET=USB_MTU3))
> depends on (EXTCON=y || EXTCON=USB_MTU3)
> + depends on USB_ROLE_SWITCH
> help
> This is the default mode of working of MTU3 controller where
> both host and gadget features are enabled.
>
> > the following patch has fixed the issue, but seems not get into kernel,
> > [v3,08/12] usb: roles: Add usb role switch notifier.
> > https://patchwork.kernel.org/patch/10836525/
>
> I don't understand how that fixes the problem? That patch will in any
> case be targeting v5.2. We are in the middle of merge window, so
> nothing is happening until v5.1-rc1 is tagged.
It provides some dummy inline functions when USB_ROLE_SWITCH is not
enabled, this will avoid build error
>
>
> thanks,
>
next prev parent reply other threads:[~2019-03-15 9:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-15 7:38 [PATCH v2 0/6] add USB Type-B GPIO based role switch driver Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 1/6] dt-bindings: connector: add optional properties for Type-B Chunfeng Yun
2019-03-31 6:40 ` Rob Herring
2019-03-31 12:45 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 2/6] dt-bindings: usb: add binding for Type-B dual role switch by GPIO Chunfeng Yun
2019-03-15 7:52 ` Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 3/6] dt-bindings: usb: mtu3: add properties about USB Role Switch Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 4/6] usb: roles: add API to get usb_role_switch by node Chunfeng Yun
2019-03-15 8:18 ` Heikki Krogerus
2019-03-15 9:11 ` Heikki Krogerus
2019-03-15 9:14 ` Chunfeng Yun
2019-03-15 9:13 ` Chunfeng Yun
2019-03-15 9:26 ` Heikki Krogerus
2019-03-15 9:32 ` Chunfeng Yun [this message]
2019-03-15 10:34 ` Heikki Krogerus
2019-03-15 11:58 ` Heikki Krogerus
2019-03-15 7:38 ` [PATCH v2 5/6] usb: roles: add driver of USB Type-B role switch by GPIO Chunfeng Yun
2019-03-15 7:38 ` [PATCH v2 6/6] usb: mtu3: register a USB Role Switch for dual role mode Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1552642379.10179.138.camel@mhfsdcap03 \
--to=chunfeng.yun@mediatek.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=andy.shevchenko@gmail.com \
--cc=badhri@google.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=jun.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=min.guo@mediatek.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).