From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH v5 09/12] mtd: rawnand: ingenic: Make use of ecc-engine property Date: Mon, 18 Mar 2019 21:37:09 +0100 Message-ID: <1552941429.1495.0@crapouillou.net> References: <20190313222259.28704-1-paul@crapouillou.net> <20190313222259.28704-9-paul@crapouillou.net> <20190315094009.66b91ad5@xps13> <1552660654.1727.0@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <1552660654.1727.0@crapouillou.net> Sender: linux-kernel-owner@vger.kernel.org To: Miquel Raynal Cc: David Woodhouse , Brian Norris , Boris Brezillon , Marek Vasut , Richard Weinberger , Rob Herring , Mark Rutland , Harvey Hunt , od@zcrc.me, Mathieu Malaterre , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, Le ven. 15 mars 2019 =E0 15:37, Paul Cercueil a=20 =E9crit : > Hi, >=20 > Le ven. 15 mars 2019 =E0 9:40, Miquel Raynal=20 > a =E9crit : >> Hi Paul, >>=20 >> Paul Cercueil wrote on Wed, 13 Mar 2019=20 >> =7F23:22:56 >> +0100: >>=20 >>> Use the 'ecc-engine' standard property instead of the custom >>> 'ingenic,bch-controller' custom property, which is now deprecated. >>>=20 >>> Signed-off-by: Paul Cercueil >>> --- >>>=20 >>> Notes: >>> v5: New patch >>>=20 >>> drivers/mtd/nand/raw/ingenic/ingenic_ecc.c | 13 ++++++++++--- >>> 1 file changed, 10 insertions(+), 3 deletions(-) >>>=20 >>> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c=20 >>> =7F=7Fb/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c >>> index d7f3a8c3abea..30436ca6628a 100644 >>> --- a/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c >>> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_ecc.c >>> @@ -82,9 +82,9 @@ static struct ingenic_ecc=20 >>> *ingenic_ecc_get(struct =7F=7Fdevice_node *np) >>>=20 >>> /** >>> * of_ingenic_ecc_get() - get the ECC controller from a DT node >>> - * @of_node: the node that contains a bch-controller property. >>> + * @of_node: the node that contains a ecc-engine property. >>=20 >> Would "contains an ecc-engine property" be better English? >>=20 >> I am not sure what is the rule when it comes to plain English with >> variable names. However if you agree, no need to re-send the series,=20 >> I >> can fix it when applying. >=20 > Yes, that's better. >=20 >> BTW, I added hw ECC engines support to my generic ECC engine >> implementation, but migrating the whole raw NAND subsystem (using I/O >> requests like in the SPI-NAND core, adding prepare/finish_io_req=20 >> =7Fhooks) >> is going to be much more invasive than initially expected, so I am=20 >> not >> sure I will finish the migration any time soon. >=20 > Ok, I will follow the development then. >=20 >> Thanks, >> Miqu=E8l >=20 > One thing I notice with my patchset: it works perfectly on top of=20 > 4.20, > but on top of 5.0 I am unable to erase any eraseblock with=20 > flash_erase. > I get -EIO every time. I'm trying to debug it but didn't go very far, > it looks like nand_status_op() gives me a status of 0xff. Do you know > what could have changed between 4.20 and 5.0 that could trigger this=20 > bug? Nevermind. It works now. > Second thing, everytime I reboot it fails to find the BBT. That's=20 > because > the BBT marker is overwritten by the ECC data as they occupy the same=20 > area > in the OOB space. Is there a way to move the BBT marker? Or should I=20 > use > NAND_BBT_NO_OOB then? Since the eraseblocks where the BBTs are located > is used in my system partition, won't that conflict with the data? Response to myself: It's possible to move the BBT marker. But in my=20 case I have to deal with three possible layouts, so it's simpler to just use NAND_BBT_NO_OOB then. The BBT pages are marked so that they're not used for data in the partitions. I'll send a V6 then. Thanks, -Paul =