* [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
@ 2019-03-20 11:09 Michal Vokáč
2019-03-20 13:35 ` Christian Lamparter
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Michal Vokáč @ 2019-03-20 11:09 UTC (permalink / raw)
To: Shawn Guo
Cc: Rob Herring, Andrew Lunn, Florian Fainelli, Christian Lamparter,
devicetree, Michal Vokáč
The switch is accessible through pseudo PHY which is located at 0x10.
Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
---
arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
index 091d829f6b05..e8d800fec637 100644
--- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
+++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
@@ -114,9 +114,9 @@
reg = <2>;
};
- switch@0 {
+ switch@10 {
compatible = "qca,qca8334";
- reg = <0>;
+ reg = <10>;
switch_ports: ports {
#address-cells = <1>;
--
2.1.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
2019-03-20 11:09 [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch Michal Vokáč
@ 2019-03-20 13:35 ` Christian Lamparter
[not found] ` <3351685.tXMZElDEK0@debian64>
2019-03-22 1:20 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Christian Lamparter @ 2019-03-20 13:35 UTC (permalink / raw)
To: Michal Vokáč
Cc: Shawn Guo, Rob Herring, Andrew Lunn, Florian Fainelli, devicetree
On Wednesday, March 20, 2019 12:09:05 PM CET Michal Vokáč wrote:
> The switch is accessible through pseudo PHY which is located at 0x10.
from what I know the switch@0 came from John' original qca8k submission patch
<https://lore.kernel.org/patchwork/patch/715974/> (this is v1! not the later
version)
In this version, the qca8k_sw_probe() function used read the MII_PHYID1 and 2
from the PHY0 in order to identify the switch (much like ar8216.c / ar8327.c
switchdev does):
| /* sw_addr is irrelevant as the switch occupies the MDIO bus from
| * addresses 0 to 4 (PHYs) and 16-23 (for MDIO 32bits protocol). So
| * we'll probe address 0 to see if we see the right switch family.
| */
| phy_id = mdiobus_read(mdiodev->bus, 0, MII_PHYSID1) << 16;
| phy_id |= mdiobus_read(mdiodev->bus, 0, MII_PHYSID2);
|
| switch (phy_id) {
| case PHY_ID_QCA8337:
| break;
| default:
| return -ENODEV;
| }
However, this code was changed in v2. Probably because if the PHY is put in
isolation and powered down the MII_PHYID1 and 2 will read "0xffff". So the
discovery would no longer worked on systems that purposely disable the switch
during the bootloader-handoff procedure (like the Meraki MX60).
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
> ---
> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> index 091d829f6b05..e8d800fec637 100644
> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
> @@ -114,9 +114,9 @@
> reg = <2>;
> };
>
> - switch@0 {
> + switch@10 {
> compatible = "qca,qca8334";
> - reg = <0>;
> + reg = <10>;
>
> switch_ports: ports {
> #address-cells = <1>;
>
^ permalink raw reply [flat|nested] 6+ messages in thread[parent not found: <3351685.tXMZElDEK0@debian64>]
* Re: PM: RE: [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
[not found] ` <3351685.tXMZElDEK0@debian64>
@ 2019-03-21 12:44 ` Michal Vokáč
2019-03-22 1:22 ` Shawn Guo
0 siblings, 1 reply; 6+ messages in thread
From: Michal Vokáč @ 2019-03-21 12:44 UTC (permalink / raw)
To: Christian Lamparter, Shawn Guo, Rob Herring
Cc: Andrew Lunn, Florian Fainelli, devicetree
Hi Christian,
I added all the original recipients back to your PM as we may get some
useful feedback from someone.
On 21. 03. 19 0:17, Christian Lamparter wrote:
> On Wednesday, March 20, 2019 12:09:05 PM CET you wrote:
>> The switch is accessible through pseudo PHY which is located at 0x10.
>
> It doesn't look like your patch made it to the device-tree patchwork?!
> (Maybe your @ysoft.com is blacklisted or something else is broken?)
I am aware of that and I am quite sure my mail is not blacklisted.
I submitted quite some patches recently and some of those made it to
the device-tree patchwork with no problem. I've got the impression that
only patches that modify something inside Documentation/devicetree/ are
visible there (but I do not really know how the system works).
@Rob, would you mind to shortly clarify how this works?
> Also I don't think devicetree-tree would merge it. I think the best bet
> would be to resent the mail and include netdev mailing list and everyone
> from the get_maintainer.pl output:
I always use the get_maintainter.pl script to get some initial list and
then I apply common sense to shrink/broaden the list to which people and
lists send the patches.
> Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> Fabio Estevam <festevam@gmail.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
In this case this is really trivial patch so I think bothering all those
people is not necessary. In my case the script actually reports more
items then what you posted.
I added you, Florian and Andrew just because I tripped around your patch
that fixes the device tree example of the qca8k binding and this change
is related to it.
I actually expect the patch to be picked by Shawn (AFAIK he takes care
of the imx device trees).
@Shawn, if my expectation is wrong, please correct me.
Anyway, thanks a lot for your comments Christian!
Best regards,
Michal
>> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
>> ---
>> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> index 091d829f6b05..e8d800fec637 100644
>> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi
>> @@ -114,9 +114,9 @@
>> reg = <2>;
>> };
>>
>> - switch@0 {
>> + switch@10 {
>> compatible = "qca,qca8334";
>> - reg = <0>;
>> + reg = <10>;
>>
>> switch_ports: ports {
>> #address-cells = <1>;
>>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: PM: RE: [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
2019-03-21 12:44 ` PM: " Michal Vokáč
@ 2019-03-22 1:22 ` Shawn Guo
2019-03-22 6:02 ` Michal Vokáč
0 siblings, 1 reply; 6+ messages in thread
From: Shawn Guo @ 2019-03-22 1:22 UTC (permalink / raw)
To: Michal Vokáč
Cc: Christian Lamparter, Rob Herring, Andrew Lunn, Florian Fainelli,
devicetree
On Thu, Mar 21, 2019 at 01:44:26PM +0100, Michal Vokáč wrote:
> Hi Christian,
>
> I added all the original recipients back to your PM as we may get some
> useful feedback from someone.
>
> On 21. 03. 19 0:17, Christian Lamparter wrote:
> >On Wednesday, March 20, 2019 12:09:05 PM CET you wrote:
> >>The switch is accessible through pseudo PHY which is located at 0x10.
> >
> >It doesn't look like your patch made it to the device-tree patchwork?!
> >(Maybe your @ysoft.com is blacklisted or something else is broken?)
>
> I am aware of that and I am quite sure my mail is not blacklisted.
> I submitted quite some patches recently and some of those made it to
> the device-tree patchwork with no problem. I've got the impression that
> only patches that modify something inside Documentation/devicetree/ are
> visible there (but I do not really know how the system works).
>
> @Rob, would you mind to shortly clarify how this works?
>
> >Also I don't think devicetree-tree would merge it. I think the best bet
> >would be to resent the mail and include netdev mailing list and everyone
> >from the get_maintainer.pl output:
>
> I always use the get_maintainter.pl script to get some initial list and
> then I apply common sense to shrink/broaden the list to which people and
> lists send the patches.
>
> >Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> >Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> >Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> >Fabio Estevam <festevam@gmail.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> >NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
> >devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
> >linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>
> In this case this is really trivial patch so I think bothering all those
> people is not necessary. In my case the script actually reports more
> items then what you posted.
For future patches, please do copy folks above. We need more eyes.
Shawn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: PM: RE: [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
2019-03-22 1:22 ` Shawn Guo
@ 2019-03-22 6:02 ` Michal Vokáč
0 siblings, 0 replies; 6+ messages in thread
From: Michal Vokáč @ 2019-03-22 6:02 UTC (permalink / raw)
To: Shawn Guo
Cc: Christian Lamparter, Rob Herring, Andrew Lunn, Florian Fainelli,
devicetree
On 22. 03. 19 2:22, Shawn Guo wrote:
> On Thu, Mar 21, 2019 at 01:44:26PM +0100, Michal Vokáč wrote:
>> Hi Christian,
>>
>> I added all the original recipients back to your PM as we may get some
>> useful feedback from someone.
>>
>> On 21. 03. 19 0:17, Christian Lamparter wrote:
>>> On Wednesday, March 20, 2019 12:09:05 PM CET you wrote:
>>>> The switch is accessible through pseudo PHY which is located at 0x10.
>>>
>>> It doesn't look like your patch made it to the device-tree patchwork?!
>>> (Maybe your @ysoft.com is blacklisted or something else is broken?)
>>
>> I am aware of that and I am quite sure my mail is not blacklisted.
>> I submitted quite some patches recently and some of those made it to
>> the device-tree patchwork with no problem. I've got the impression that
>> only patches that modify something inside Documentation/devicetree/ are
>> visible there (but I do not really know how the system works).
>>
>> @Rob, would you mind to shortly clarify how this works?
>>
>>> Also I don't think devicetree-tree would merge it. I think the best bet
>>> would be to resent the mail and include netdev mailing list and everyone
>> >from the get_maintainer.pl output:
>>
>> I always use the get_maintainter.pl script to get some initial list and
>> then I apply common sense to shrink/broaden the list to which people and
>> lists send the patches.
>>
>>> Shawn Guo <shawnguo@kernel.org> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>> Sascha Hauer <s.hauer@pengutronix.de> (maintainer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>> Pengutronix Kernel Team <kernel@pengutronix.de> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>> Fabio Estevam <festevam@gmail.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>> NXP Linux Team <linux-imx@nxp.com> (reviewer:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>> devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
>>> linux-arm-kernel@lists.infradead.org (moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE)
>>
>> In this case this is really trivial patch so I think bothering all those
>> people is not necessary. In my case the script actually reports more
>> items then what you posted.
>
> For future patches, please do copy folks above. We need more eyes.
OK, I will do so. Thank you Shawn.
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch
2019-03-20 11:09 [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch Michal Vokáč
2019-03-20 13:35 ` Christian Lamparter
[not found] ` <3351685.tXMZElDEK0@debian64>
@ 2019-03-22 1:20 ` Shawn Guo
2 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2019-03-22 1:20 UTC (permalink / raw)
To: Michal Vokáč
Cc: Rob Herring, Andrew Lunn, Florian Fainelli, Christian Lamparter,
devicetree
On Wed, Mar 20, 2019 at 12:09:05PM +0100, Michal Vokáč wrote:
> The switch is accessible through pseudo PHY which is located at 0x10.
>
> Signed-off-by: Michal Vokáč <michal.vokac@ysoft.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-03-22 6:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-20 11:09 [PATCH] ARM: dts: imx6dl-yapp4: Use correct pseudo PHY address for the switch Michal Vokáč
2019-03-20 13:35 ` Christian Lamparter
[not found] ` <3351685.tXMZElDEK0@debian64>
2019-03-21 12:44 ` PM: " Michal Vokáč
2019-03-22 1:22 ` Shawn Guo
2019-03-22 6:02 ` Michal Vokáč
2019-03-22 1:20 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).