devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver
@ 2019-03-29 15:32 Stanley Chu
       [not found] ` <1553873568-9177-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2019-04-04  3:26 ` [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add " Martin K. Petersen
  0 siblings, 2 replies; 4+ messages in thread
From: Stanley Chu @ 2019-03-29 15:32 UTC (permalink / raw)
  To: linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	robh-DgEjT+Ai2ygdnm+yROfE0A,
	martin.petersen-QHcLZuEGTsvQT0dZR+AlfA, avri.altman-Sjgp3cTcYWE,
	alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ,
	pedrom.sousa-HKixBCOQz3hWk0Htik3J/w
  Cc: chun-hung.wu-NuS5LvNUpcJWk0Htik3J/w,
	kuohong.wang-NuS5LvNUpcJWk0Htik3J/w,
	evgreen-F7+t8E8rja9g9hUCZPvPmw, subhashj-sgV2jX0FEOL9JmXXK+q4OQ,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	peter.wang-NuS5LvNUpcJWk0Htik3J/w,
	vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
	sayalil-sgV2jX0FEOL9JmXXK+q4OQ, Stanley Chu,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	beanhuo-AL4WhLSQfzjQT0dZR+AlfA

Hi,

Now we can remove custom device tree property "<name>-fixed-regulator" for
UFS because,

1) It is not used anywhere in tree.
2) All handlings for "<name>-fixed-regulator" have been removed in UFS
   driver.
3) There is no issue if an existed regulator defined
   "<name>-fixed-regulator" property in device tree.

Besides, add VCC supply capability on MediaTek UFS driver.

Stanley Chu (2):
  scsi: dt-bindings: ufs: Remove custom property
    "<name>-fixed-regulator"
  scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver

 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt  | 3 +++
 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 --
 2 files changed, 3 insertions(+), 2 deletions(-)

-- 
2.18.0

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 1/2] scsi: dt-bindings: ufs: Remove custom property "<name>-fixed-regulator"
       [not found] ` <1553873568-9177-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2019-03-29 15:32   ` Stanley Chu
  2019-03-29 15:32   ` [PATCH 2/2] scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver Stanley Chu
  1 sibling, 0 replies; 4+ messages in thread
From: Stanley Chu @ 2019-03-29 15:32 UTC (permalink / raw)
  To: linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	robh-DgEjT+Ai2ygdnm+yROfE0A,
	martin.petersen-QHcLZuEGTsvQT0dZR+AlfA, avri.altman-Sjgp3cTcYWE,
	alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ,
	pedrom.sousa-HKixBCOQz3hWk0Htik3J/w
  Cc: chun-hung.wu-NuS5LvNUpcJWk0Htik3J/w,
	kuohong.wang-NuS5LvNUpcJWk0Htik3J/w,
	evgreen-F7+t8E8rja9g9hUCZPvPmw, subhashj-sgV2jX0FEOL9JmXXK+q4OQ,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	peter.wang-NuS5LvNUpcJWk0Htik3J/w,
	vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
	sayalil-sgV2jX0FEOL9JmXXK+q4OQ, Stanley Chu,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	beanhuo-AL4WhLSQfzjQT0dZR+AlfA

Custom device tree property "<name>-fixed-regulator" can be removed
because,

1) It is not used anywhere in tree.

2) All handlings for "<name>-fixed-regulator" have been removed in UFS
   driver.

3) There is no issue if an existed regulator defined
   "<name>-fixed-regulator" property in device tree.

Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
index 5111e9130bc3..f3140cffc54d 100644
--- a/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
+++ b/Documentation/devicetree/bindings/ufs/ufshcd-pltfrm.txt
@@ -31,7 +31,6 @@ Optional properties:
 - vcc-max-microamp      : specifies max. load that can be drawn from vcc supply
 - vccq-max-microamp     : specifies max. load that can be drawn from vccq supply
 - vccq2-max-microamp    : specifies max. load that can be drawn from vccq2 supply
-- <name>-fixed-regulator : boolean property specifying that <name>-supply is a fixed regulator
 
 - clocks                : List of phandle and clock specifier pairs
 - clock-names           : List of clock input name strings sorted in the same
@@ -63,7 +62,6 @@ Example:
 		interrupts = <0 28 0>;
 
 		vdd-hba-supply = <&xxx_reg0>;
-		vdd-hba-fixed-regulator;
 		vcc-supply = <&xxx_reg1>;
 		vcc-supply-1p8;
 		vccq-supply = <&xxx_reg2>;
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 2/2] scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver
       [not found] ` <1553873568-9177-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
  2019-03-29 15:32   ` [PATCH 1/2] scsi: dt-bindings: ufs: Remove custom property "<name>-fixed-regulator" Stanley Chu
@ 2019-03-29 15:32   ` Stanley Chu
  1 sibling, 0 replies; 4+ messages in thread
From: Stanley Chu @ 2019-03-29 15:32 UTC (permalink / raw)
  To: linux-scsi-u79uwXL29TY76Z2rM5mHXA,
	devicetree-u79uwXL29TY76Z2rM5mHXA, robh+dt-DgEjT+Ai2ygdnm+yROfE0A,
	robh-DgEjT+Ai2ygdnm+yROfE0A,
	martin.petersen-QHcLZuEGTsvQT0dZR+AlfA, avri.altman-Sjgp3cTcYWE,
	alim.akhtar-Sze3O3UU22JBDgjK7y7TUQ,
	pedrom.sousa-HKixBCOQz3hWk0Htik3J/w
  Cc: chun-hung.wu-NuS5LvNUpcJWk0Htik3J/w,
	kuohong.wang-NuS5LvNUpcJWk0Htik3J/w,
	evgreen-F7+t8E8rja9g9hUCZPvPmw, subhashj-sgV2jX0FEOL9JmXXK+q4OQ,
	linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	peter.wang-NuS5LvNUpcJWk0Htik3J/w,
	vivek.gautam-sgV2jX0FEOL9JmXXK+q4OQ,
	matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w,
	sayalil-sgV2jX0FEOL9JmXXK+q4OQ, Stanley Chu,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	beanhuo-AL4WhLSQfzjQT0dZR+AlfA

Add VCC supply for ufs-mediatek driver to provide power-saving
operation during low-power modes, for example, VCC can be
turned-off during system suspend and turned-on after
system is resumed.

Signed-off-by: Stanley Chu <stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/Documentation/devicetree/bindings/ufs/ufs-mediatek.txt b/Documentation/devicetree/bindings/ufs/ufs-mediatek.txt
index e25c007b95d7..72aab8547308 100644
--- a/Documentation/devicetree/bindings/ufs/ufs-mediatek.txt
+++ b/Documentation/devicetree/bindings/ufs/ufs-mediatek.txt
@@ -21,6 +21,7 @@ Required properties for UFS nodes:
                        defined or a value in the array is "0" then it is assumed
                        that the frequency is set by the parent clock or a
                        fixed rate clock source.
+- vcc-supply         : phandle to VCC supply regulator node.
 
 Example:
 
@@ -37,4 +38,6 @@ Example:
 		clocks = <&infracfg_ao INFRACFG_AO_UFS_CG>;
 		clock-names = "ufs";
 		freq-table-hz = <0 0>;
+
+		vcc-supply = <&mt_pmic_vemc_ldo_reg>;
 	};
-- 
2.18.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver
  2019-03-29 15:32 [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver Stanley Chu
       [not found] ` <1553873568-9177-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
@ 2019-04-04  3:26 ` Martin K. Petersen
  1 sibling, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2019-04-04  3:26 UTC (permalink / raw)
  To: Stanley Chu
  Cc: devicetree, linux-scsi, martin.petersen, robh, vivek.gautam,
	subhashj, chun-hung.wu, kuohong.wang, evgreen, avri.altman,
	robh+dt, linux-mediatek, peter.wang, alim.akhtar, matthias.bgg,
	sayalil, pedrom.sousa, linux-arm-kernel, beanhuo


Stanley,

> Now we can remove custom device tree property "<name>-fixed-regulator" for
> UFS because,

> Besides, add VCC supply capability on MediaTek UFS driver.

Applied to 5.2/scsi-queue, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-04  3:26 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-03-29 15:32 [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add VCC capability on MediaTek UFS driver Stanley Chu
     [not found] ` <1553873568-9177-1-git-send-email-stanley.chu-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-03-29 15:32   ` [PATCH 1/2] scsi: dt-bindings: ufs: Remove custom property "<name>-fixed-regulator" Stanley Chu
2019-03-29 15:32   ` [PATCH 2/2] scsi: dt-bindings: ufs: Add VCC capability on MediaTek UFS driver Stanley Chu
2019-04-04  3:26 ` [PATCH 0/2] scsi: dt-bindings: ufs: Remove "<name>-fixed-regulator" property and add " Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).