[PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

[PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

[Leonidas P. Papadakos]

The eMMC 5.x that Libre Computer provide for their boards supports HS200 mode.
The support is already included in the dts for their newest board:

La Frite (AML-S805X-AC)
dts: arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts

That same eMMC is supported in the ROC-RK3328-CC:
https://www.loverpi.com/products/libre-computer-board-emmc-5-x-module

This increases the speed of the eMMC significantly.

Signed-off-by: Leonidas P. Papadakos <papadakospan-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
Changes since v1:
- disable-wp isn't needed.
- limit max_frequency to 150MHz for rk3328

 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index c213ad74d..db3246995 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -122,6 +122,9 @@
 &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
+	max-frequency = <150000000>;
+	mmc-ddr-1_8v;
+	mmc-hs200-1_8v;
 	non-removable;
 	pinctrl-names = "default";
 	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
-- 
2.21.0

Re: [PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

[Leonidas P. Papadakos]

Should I make a patch v3 with the vccs for the emmc like on rock64?
> vmmc-supply = <&vcc_io>;
> vqmmc-supply = <&vcc18_emmc>;

They do exist in the renegade dts.

Re: [PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

[Heiko Stuebner]

Am Donnerstag, 4. April 2019, 14:40:09 CEST schrieb Leonidas P. Papadakos:
> 
> Should I make a patch v3 with the vccs for the emmc like on rock64?
> > vmmc-supply = <&vcc_io>;
> > vqmmc-supply = <&vcc18_emmc>;
> 
> They do exist in the renegade dts.

modelling relevant supplies is always good to have.

I've applied your patch for 5.2 and just added the supplies you mention
above. So no need for a respin, but you could double-check that I didn't
mess up please:
https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.2-armsoc/dts64&id=de674862f76d006c670308c46a010b3a09536fd3

Thanks
Heiko

Re: [PATCH v2] arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

[Leonidas P. Papadakos]

> modelling relevant supplies is always good to have.
> 
> I've applied your patch for 5.2 and just added the supplies you 
> mention
> above. So no need for a respin, but you could double-check that I 
> didn't
> mess up please:
> https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v5.2-armsoc/dts64&id=de674862f76d006c670308c46a010b3a09536fd3
> 
> Thanks
> Heiko
> 

Looks good, thanks!