devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lucas Stach <l.stach@pengutronix.de>
To: "Guido Günther" <agx@sigxcpu.org>
Cc: devicetree@vger.kernel.org, Shawn Guo <shawnguo@kernel.org>,
	patchwork-lst@pengutronix.de, NXP Linux Team <linux-imx@nxp.com>,
	kernel@pengutronix.de, Fabio Estevam <festevam@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: imx8mq: add GPU node
Date: Wed, 10 Apr 2019 15:02:12 +0200	[thread overview]
Message-ID: <1554901332.11529.9.camel@pengutronix.de> (raw)
In-Reply-To: <20190408134540.GA13816@bogon.m.sigxcpu.org>

Hi Guido,

Am Montag, den 08.04.2019, 15:45 +0200 schrieb Guido Günther:
> Hi,
> On Mon, Apr 08, 2019 at 03:07:29PM +0200, Guido Günther wrote:
> > Hi Lucas,
> > On Thu, Apr 04, 2019 at 06:52:11PM +0200, Lucas Stach wrote:
> > > This enables the Vivante GC7000L GPU on the i.MX8MQ SoC.
> > > 
> > > > > > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > > ---
> > >  arch/arm64/boot/dts/freescale/imx8mq.dtsi | 22 ++++++++++++++++++++++
> > >  1 file changed, 22 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/imx8mq.dtsi b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > index 4300781558f6..79d418b4f585 100644
> > > --- a/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/imx8mq.dtsi
> > > @@ -792,6 +792,28 @@
> > > > > >  			};
> > > > > >  		};
> > >  
> > > > > > > > > +		gpu: gpu@38000000 {
> > > > > > +			compatible = "vivante,gc";
> > > > > > +			reg = <0x38000000 0x40000>;
> > > > > > +			interrupts = <GIC_SPI 3 IRQ_TYPE_LEVEL_HIGH>;
> > > > > > +			clocks = <&clk IMX8MQ_CLK_GPU_ROOT>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_SHADER_DIV>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > +			         <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > +			clock-names = "core", "shader", "bus", "reg";
> > > > > > +			assigned-clocks = <&clk IMX8MQ_CLK_GPU_CORE_SRC>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_SHADER_SRC>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AXI>,
> > > > > > +			                  <&clk IMX8MQ_CLK_GPU_AHB>;
> > > > > > +			assigned-clock-parents = <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>,
> > > > > > +			                         <&clk IMX8MQ_GPU_PLL_OUT>;
> > > > > > +			assigned-clock-rates = <800000000>, <800000000>,
> > > > > > +			                       <800000000>, <800000000>;
> > > > > > +			power-domains = <&pgc_gpu>;
> > > +		};
> > 
> > Reviewed-by: Guido Günther <agx@sigxcpu.org>
> 
> On a second thought should this have a
> 
>     status = "disabled";

I disagree. This is a SoC internal peripheral, that has no board level
dependencies other than the voltage rail being connected, so it's fine
to have the node enabled on all systems. This is consistent with what
we did on all previous i.MX SoC DTs.

Regards,
Lucas

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-04-10 13:02 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 16:52 [PATCH] arm64: dts: imx8mq: add GPU node Lucas Stach
2019-04-08 13:07 ` Guido Günther
2019-04-08 13:45   ` Guido Günther
2019-04-10 13:02     ` Lucas Stach [this message]
2019-04-11 18:47       ` Guido Günther
2019-04-09  1:54 ` Aisheng Dong
2019-04-10 10:59   ` Lucas Stach
2019-04-11  6:50 ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1554901332.11529.9.camel@pengutronix.de \
    --to=l.stach@pengutronix.de \
    --cc=agx@sigxcpu.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=patchwork-lst@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).