From: Seiya Wang <seiya.wang@mediatek.com>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
srv_heupstream@mediatek.com
Subject: Re: [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173
Date: Tue, 16 Apr 2019 16:35:01 +0800 [thread overview]
Message-ID: <1555403701.26958.1.camel@mtksdaap41> (raw)
In-Reply-To: <38a56fc1-09fa-a35a-fcef-e265f1608b83@gmail.com>
On Fri, 2019-02-08 at 16:04 +0100, Matthias Brugger wrote:
>
> On 09/01/2019 09:21, Seiya Wang wrote:
> > This patch adds the device nodes of ARM Performance Monitor Uint
> > for mt8173.
> >
> > Signed-off-by: Seiya Wang <seiya.wang@mediatek.com>
> > ---
> > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > index 412ffd4d426b..44374c506a1c 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi
> > @@ -216,6 +216,20 @@
> > };
> > };
> >
> > + pmu_a53 {
> > + compatible = "arm,cortex-a53-pmu";
> > + interrupts = <GIC_SPI 8 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 9 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu0>, <&cpu1>;
> > + };
> > +
> > + pmu_a72 {
> > + compatible = "arm,cortex-a72-pmu";
> > + interrupts = <GIC_SPI 12 IRQ_TYPE_LEVEL_LOW>,
> > + <GIC_SPI 13 IRQ_TYPE_LEVEL_LOW>;
> > + interrupt-affinity = <&cpu2>, <&cpu3>;
> > + };
>
> There is no a72 but a a57 CPU present.
> Typo?
>
> Regards,
> Matthias
Please also apply this (if no problems) since we have changed to ca72.
Thanks.
> > +
> > psci {
> > compatible = "arm,psci-1.0", "arm,psci-0.2", "arm,psci";
> > method = "smc";
> >
next prev parent reply other threads:[~2019-04-16 8:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-09 8:21 [PATCH v1 1/1] arm64: dts: mt8173: add pmu nodes for mt8173 Seiya Wang
2019-02-08 15:04 ` Matthias Brugger
2019-02-11 5:20 ` Seiya Wang
2019-04-16 8:35 ` Seiya Wang [this message]
2019-04-16 8:57 ` Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1555403701.26958.1.camel@mtksdaap41 \
--to=seiya.wang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).