From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH v3 2/3] dt-bindings: Add header for the ingenic-drm driver bindings Date: Mon, 22 Apr 2019 18:13:02 +0200 Message-ID: <1555949582.1483.0@crapouillou.net> References: <20190414200824.28348-1-paul@crapouillou.net> <20190414200824.28348-2-paul@crapouillou.net> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Ezequiel Garcia Cc: Rob Herring , David Airlie , Daniel Vetter , Mark Rutland , Maarten Lankhorst , Maxime Ripard , Sean Paul , od@zcrc.me, dri-devel , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, Le sam. 20 avril 2019 =E0 14:23, Ezequiel Garcia=20 a =E9crit : > On Wed, 17 Apr 2019 at 10:48, Rob Herring wrote: >>=20 >> On Sun, Apr 14, 2019 at 3:08 PM Paul Cercueil=20 >> wrote: >> > >> > Add macros that can be used with the ingenic,lcd-mode property in=20 >> the >> > devicetree node that corresponds to the ingenic-drm driver. >>=20 >> DRM is a Linuxism. >>=20 >> > >> > Signed-off-by: Paul Cercueil >> > Tested-by: Artur Rojek >> > --- >> > >> > Notes: >> > v2: No change >> > >> > v3: s/_DRM// >> > >> > include/dt-bindings/display/ingenic,drm.h | 28=20 >> ++++++++++++++++++++++++++++ >>=20 >> DRM is a Linuxism... >>=20 >> > 1 file changed, 28 insertions(+) >> > create mode 100644 include/dt-bindings/display/ingenic,drm.h >> > >> > diff --git a/include/dt-bindings/display/ingenic,drm.h=20 >> b/include/dt-bindings/display/ingenic,drm.h >> > new file mode 100644 >> > index 000000000000..c749b8c346fc >> > --- /dev/null >> > +++ b/include/dt-bindings/display/ingenic,drm.h >> > @@ -0,0 +1,28 @@ >> > +/* SPDX-License-Identifier: GPL-2.0 */ >> > +/* >> > + * Ingenic JZ47xx KMS driver >>=20 >> Pretty sure this file is not a KMS driver. >>=20 >> > + * >> > + * Copyright (C) 2019, Paul Cercueil >> > + */ >> > +#ifndef __INCLUDE_DT_BINDINGS_DISPLAY_INGENIC_DRM_H__ >> > +#define __INCLUDE_DT_BINDINGS_DISPLAY_INGENIC_DRM_H__ >> > + >> > +#define JZ_LCD_GENERIC_16BIT 0 >> > +#define JZ_LCD_GENERIC_18BIT 16 >>=20 >> We have some generic properties for defining the bus width already. >> Plus, in many cases this can be implied by the panel compatible. The >> exceptions are cases such as when both the ctrlr and panel support >> multiple modes. >>=20 >=20 > In the same direction as Rob's comment, I'd like to see these=20 > decoupled > from the register value. >=20 > Ideally, we'd like to reuse this driver and its bindings for JZ4780, > and these values are already different. Well they are not any different on the JZ4780, I just checked on the=20 manual. But yes, I don't mind getting rid of that devicetree property and its corresponding bindings file. The major problem is that we don't have a way to map some of the values=20 there to DRM macros. I sumitted a PR to add a MEDIA_BUS_FMT_RGB888_3X8_BE bus=20 format (that I could detect to support 8-bit serial TFT panels, which is what=20 the Ben Nanonote uses), but I miss a way to detect the special* TFT panels. I will leave these aside for now, but I want to support them eventually. Thanks, -Paul * "special" TFT panels have extra pins (CLS, SPL, REV, PS) and seem to=20 be a thing from Sharp. Ingenic SoCs (as well as i.MX SoCs) have the required hardware to drive these panels. > Thanks! > -- > Ezequiel Garc=EDa, VanguardiaSur > www.vanguardiasur.com.ar =