From: "Petr Štetiar" <ynezz@true.cz>
To: netdev@vger.kernel.org, devicetree@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Gregory Clement <gregory.clement@bootlin.com>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: "Florian Fainelli" <f.fainelli@gmail.com>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Frank Rowand" <frowand.list@gmail.com>,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Maxime Ripard" <maxime.ripard@bootlin.com>,
"Petr Štetiar" <ynezz@true.cz>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v4 09/10] ARM: Kirkwood: support of_get_mac_address new ERR_PTR error
Date: Fri, 3 May 2019 16:27:14 +0200 [thread overview]
Message-ID: <1556893635-18549-10-git-send-email-ynezz@true.cz> (raw)
In-Reply-To: <1556893635-18549-1-git-send-email-ynezz@true.cz>
There was NVMEM support added to of_get_mac_address, so it could now return
ERR_PTR encoded error values, so we need to adjust all current users of
of_get_mac_address to this new fact.
Signed-off-by: Petr Štetiar <ynezz@true.cz>
---
Changes since v3:
* IS_ERR_OR_NULL -> IS_ERR
arch/arm/mach-mvebu/kirkwood.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-mvebu/kirkwood.c b/arch/arm/mach-mvebu/kirkwood.c
index 0aa8810..9b5f4d6 100644
--- a/arch/arm/mach-mvebu/kirkwood.c
+++ b/arch/arm/mach-mvebu/kirkwood.c
@@ -92,7 +92,8 @@ static void __init kirkwood_dt_eth_fixup(void)
continue;
/* skip disabled nodes or nodes with valid MAC address*/
- if (!of_device_is_available(pnp) || of_get_mac_address(np))
+ if (!of_device_is_available(pnp) ||
+ !IS_ERR(of_get_mac_address(np)))
goto eth_fixup_skip;
clk = of_clk_get(pnp, 0);
--
1.9.1
next prev parent reply other threads:[~2019-05-03 14:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 14:27 [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 01/10] of_net: add " Petr Štetiar
2019-05-03 14:36 ` Maxime Ripard
2019-05-03 15:44 ` Petr Štetiar
2019-05-06 14:04 ` Maxime Ripard
[not found] ` <1556893635-18549-1-git-send-email-ynezz-knWk7/PSn+s@public.gmane.org>
2019-05-03 14:27 ` [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-05-07 16:44 ` Rob Herring
2019-05-08 8:41 ` Petr Štetiar
2019-05-08 11:48 ` Andrew Lunn
2019-05-03 14:27 ` [PATCH v4 05/10] net: ethernet: support of_get_mac_address new ERR_PTR error Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 03/10] net: macb: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 04/10] net: davinci: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 06/10] net: usb: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 07/10] net: wireless: " Petr Štetiar
2019-05-06 7:59 ` Kalle Valo
2019-05-03 14:27 ` [PATCH v4 08/10] staging: octeon-ethernet: " Petr Štetiar
2019-05-03 15:32 ` [PATCH v5] " Petr Štetiar
2019-05-03 14:27 ` Petr Štetiar [this message]
2019-05-03 14:27 ` [PATCH v4 10/10] powerpc: tsi108: " Petr Štetiar
2019-05-06 4:47 ` [PATCH v4 00/10] of_net: Add NVMEM support to of_get_mac_address David Miller
2019-05-06 8:32 ` Petr Štetiar
2019-05-06 14:41 ` Maxime Chevallier
2019-05-06 16:19 ` Petr Štetiar
2019-05-07 15:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556893635-18549-10-git-send-email-ynezz@true.cz \
--to=ynezz@true.cz \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hkallweit1@gmail.com \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.ripard@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).