From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eddie Huang Subject: Re: [PATCH 3/8] arm64: dts: mt8183: Add #cooling-cells to CPU nodes Date: Mon, 6 May 2019 13:25:32 +0800 Message-ID: <1557120332.13225.2.camel@mtksdaap41> References: <1556793795-25204-1-git-send-email-michael.kao@mediatek.com> <1556793795-25204-4-git-send-email-michael.kao@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1556793795-25204-4-git-send-email-michael.kao@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: "michael.kao" Cc: Mark Rutland , JamesJJ Liao =?UTF-8?Q?=28=E5=BB=96=E5=BB=BA=E6=99=BA=29?= , "devicetree@vger.kernel.org" , Louis Yu =?UTF-8?Q?=28=E6=B8=B8=E6=94=BF=E9=8C=95=29?= , Dawei Chien =?UTF-8?Q?=28=E9=8C=A2=E5=A4=A7=E8=A1=9B=29?= , "linux-pm@vger.kernel.org" , Daniel Lezcano , Roger Lu =?UTF-8?Q?=28=E9=99=B8=E7=91=9E=E5=82=91=29?= , "linux-kernel@vger.kernel.org" , Eduardo Valentin , Fan Chen =?UTF-8?Q?=28=E9=99=B3=E5=87=A1=29?= , Rob Herring , "linux-mediatek@lists.infradead.org" , Matthias Brugger , Zhang Rui List-Id: devicetree@vger.kernel.org Hi Michael, On Thu, 2019-05-02 at 18:43 +0800, michael.kao wrote: > The #cooling-cells property needs to be specified to allow a CPU > to be used as cooling device. > > Signed-off-by: michael.kao > --- > arch/arm64/boot/dts/mediatek/mt8183.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > index 5668fb8..95f1d7b 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi > @@ -11,6 +11,8 @@ > #include > #include > #include "mt8183-pinfunc.h" > +#include > + > / { > compatible = "mediatek,mt8183"; > interrupt-parent = <&sysirq>; It seems this patch don't have #cooling-cells but in your 2/8 patch in this series