From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko =?ISO-8859-1?Q?St=FCbner?= Subject: Re: [PATCH v14 0/3] Add drm driver for Rockchip Socs Date: Wed, 26 Nov 2014 01:37:51 +0100 Message-ID: <1557742.FTdLsE0bVs@diego> References: <1416447994-9921-1-git-send-email-mark.yao@rock-chips.com> <23617908.6oA5uRuO3l@diego> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-doc-owner@vger.kernel.org To: Dave Airlie , Joerg Roedel Cc: Mark Yao , Boris BREZILLON , Rob Clark , Daniel Vetter , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Randy Dunlap , Grant Likely , Greg Kroah-Hartman , John Stultz , Rom Lemarchand , "devicetree@vger.kernel.org" , linux-doc@vger.kernel.org, LKML , dri-devel , linux-api@vger.kernel.org, linux-rockchip@lists.infradead.org, Douglas Anderson , =?ISO-8859-1?Q?St=E9phane?= Marchesin List-Id: devicetree@vger.kernel.org Hi Joerg, Dave, Am Mittwoch, 26. November 2014, 09:12:56 schrieb Dave Airlie: > On 26 November 2014 at 02:38, Heiko St=FCbner wrote= : > > Mark, > >=20 > > Am Donnerstag, 20. November 2014, 09:46:34 schrieb Mark Yao: > >> This a series of patches is a DRM Driver for Rockchip Socs, add su= pport > >> for vop devices. Future patches will add additional encoders/conne= ctors, > >> such as eDP, HDMI. > >>=20 > >> The basic "crtc" for rockchip is a "VOP" - Video Output Processor. > >> the vop devices found on Rockchip rk3288 Soc, rk3288 soc have two = similar > >> Vop devices. Vop devices support iommu mapping, we use dma-mapping= API > >> with > >> ARM_DMA_USE_IOMMU. > >=20 > > it looks like everybody is more or less happy with this version - i= n past > > versions responses voicing concerns where quite swift. > >=20 > > As David requested a pull request the last time, it might be time t= o do > > so, so that we maybe still reach 3.19. >=20 > I need the iommu changes the drm driver depends on in a stable > maintainer git tree, > I'm not pulling in code I can't build. Joerg, is your arm/rockchip branch [0] considered stable? [0] https://git.kernel.org/cgit/linux/kernel/git/joro/iommu.git/log/?h=3D= arm/rockchip > I'm happy if the rockchip drm pull stays static and I can pull it in > once the iommu bits > are done. While testing this I noticed a quite big kconfig warning (on both 3.18-rc1 and 3.18-rc6): drivers/video/fbdev/Kconfig:5:error: recursive dependency detected! drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HEL= PER drivers/gpu/drm/Kconfig:34: symbol DRM_KMS_FB_HELPER is selected by= DRM_ROCKCHIP drivers/gpu/drm/rockchip/Kconfig:1: symbol DRM_ROCKCHIP depends on = ARM_DMA_USE_IOMMU arch/arm/Kconfig:95: symbol ARM_DMA_USE_IOMMU is selected by VIDEO_O= MAP3 drivers/media/platform/Kconfig:96: symbol VIDEO_OMAP3 depends on V= IDEO_V4L2 drivers/media/v4l2-core/Kconfig:6: symbol VIDEO_V4L2 depends on I2= C drivers/i2c/Kconfig:7: symbol I2C is selected by FB_DDC drivers/video/fbdev/Kconfig:59: symbol FB_DDC is selected by FB_CYBER20= 00_DDC drivers/video/fbdev/Kconfig:374: symbol FB_CYBER2000_DDC depends= on FB_CYBER2000 drivers/video/fbdev/Kconfig:362: symbol FB_CYBER2000 depends on = =46B It looks like the VIDEO_OMAP3 is selecting ARM_DMA_USE_IOMMU and OMAP_IOMMU instead of depending on it. I'm not sure which driver should change but looking at the exynos drm driver it is also depends on the iommu parts instead of selecting them [like the rockchip drm currently does] Heiko