From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Cercueil Subject: Re: [PATCH v4 2/3] media: uapi: Add RGB bus format for the GiantPlus GPM940B0 panel Date: Wed, 05 Jun 2019 23:59:58 +0200 Message-ID: <1559771998.1972.0@crapouillou.net> References: <20190603153511.24384-1-paul@crapouillou.net> <20190603153511.24384-2-paul@crapouillou.net> <20190605112645.5b357630@coco.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20190605112645.5b357630@coco.lan> Sender: linux-kernel-owner@vger.kernel.org To: Mauro Carvalho Chehab Cc: Thierry Reding , Sam Ravnborg , Hans Verkuil , dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, od@zcrc.me List-Id: devicetree@vger.kernel.org Le mer. 5 juin 2019 =E0 16:26, Mauro Carvalho Chehab=20 a =E9crit : > Em Mon, 3 Jun 2019 17:35:10 +0200 > Paul Cercueil escreveu: >=20 >> The GiantPlus GPM940B0 is a 24-bit TFT panel where the RGB=20 >> components >> are transferred sequentially on a 8-bit bus. >>=20 >> Signed-off-by: Paul Cercueil >> --- >>=20 >> Notes: >> v2: New patch >>=20 >> v3: No change >>=20 >> v4: Add only MEDIA_BUS_FMT_RGB888_3X8, as we don't have to care=20 >> about >> endianness >=20 > Same comment as on version 3: >=20 > You should also patch the documentation text at: >=20 > Documentation/media/uapi/v4l/subdev-formats.rst >=20 > In order to describe the new format that will be included. Ouch. Sorry. Will do. -Paul >=20 >>=20 >> include/uapi/linux/media-bus-format.h | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >>=20 >> diff --git a/include/uapi/linux/media-bus-format.h=20 >> b/include/uapi/linux/media-bus-format.h >> index 2a6b253cfb05..16c1fa2d89a4 100644 >> --- a/include/uapi/linux/media-bus-format.h >> +++ b/include/uapi/linux/media-bus-format.h >> @@ -34,7 +34,7 @@ >>=20 >> #define MEDIA_BUS_FMT_FIXED 0x0001 >>=20 >> -/* RGB - next is 0x101c */ >> +/* RGB - next is 0x101d */ >> #define MEDIA_BUS_FMT_RGB444_1X12 0x1016 >> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_BE 0x1001 >> #define MEDIA_BUS_FMT_RGB444_2X8_PADHI_LE 0x1002 >> @@ -55,6 +55,7 @@ >> #define MEDIA_BUS_FMT_RGB888_1X24 0x100a >> #define MEDIA_BUS_FMT_RGB888_2X12_BE 0x100b >> #define MEDIA_BUS_FMT_RGB888_2X12_LE 0x100c >> +#define MEDIA_BUS_FMT_RGB888_3X8 0x101c >> #define MEDIA_BUS_FMT_RGB888_1X7X4_SPWG 0x1011 >> #define MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA 0x1012 >> #define MEDIA_BUS_FMT_ARGB8888_1X32 0x100d >=20 >=20 >=20 > Thanks, > Mauro =