* [PATCH V2 0/2] Add DesignWare IP support to simple reset @ 2019-06-06 15:36 Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 1/2] reset: " Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings Luis Oliveira 0 siblings, 2 replies; 6+ messages in thread From: Luis Oliveira @ 2019-06-06 15:36 UTC (permalink / raw) To: p.zabel, robh+dt, mark.rutland, linux-kernel, devicetree Cc: Joao.Pinto, Luis Oliveira This patch series adds a reset-simple compatible string for DesignWare IPs allowing active high and low resets inputs. Also adds the corresponding documentation. Gustavo Pimentel (1): reset: Add DesignWare IP support to simple reset Luis Oliveira (1): dt-bindings: Document the DesignWare IP reset bindings .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ drivers/reset/Kconfig | 2 +- drivers/reset/reset-simple.c | 3 +++ 3 files changed, 34 insertions(+), 1 deletion(-) create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt -- 2.7.4 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH V2 1/2] reset: Add DesignWare IP support to simple reset 2019-06-06 15:36 [PATCH V2 0/2] Add DesignWare IP support to simple reset Luis Oliveira @ 2019-06-06 15:36 ` Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings Luis Oliveira 1 sibling, 0 replies; 6+ messages in thread From: Luis Oliveira @ 2019-06-06 15:36 UTC (permalink / raw) To: p.zabel, robh+dt, mark.rutland, linux-kernel, devicetree Cc: Joao.Pinto, Gustavo Pimentel, Luis Oliveira From: Gustavo Pimentel <gustavo.pimentel@synopsys.com> The reset-simple driver can be now used on DesignWare IPs by default by selecting the following compatible strings: - snps,dw-high-reset for active high resets inputs - snps,dw-low-reset for active low resets inputs Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com> --- Changelog - no changes drivers/reset/Kconfig | 2 +- drivers/reset/reset-simple.c | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/reset/Kconfig b/drivers/reset/Kconfig index d506d32..ac85fd2 100644 --- a/drivers/reset/Kconfig +++ b/drivers/reset/Kconfig @@ -118,7 +118,7 @@ config RESET_QCOM_PDC config RESET_SIMPLE bool "Simple Reset Controller Driver" if COMPILE_TEST - default ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARCH_ASPEED + default ARCH_STM32 || ARCH_STRATIX10 || ARCH_SUNXI || ARCH_ZX || ARCH_ASPEED || ARC help This enables a simple reset controller driver for reset lines that that can be asserted and deasserted by toggling bits in a contiguous, diff --git a/drivers/reset/reset-simple.c b/drivers/reset/reset-simple.c index 77fbba3..79e73be 100644 --- a/drivers/reset/reset-simple.c +++ b/drivers/reset/reset-simple.c @@ -129,6 +129,9 @@ static const struct of_device_id reset_simple_dt_ids[] = { .data = &reset_simple_active_low }, { .compatible = "aspeed,ast2400-lpc-reset" }, { .compatible = "aspeed,ast2500-lpc-reset" }, + { .compatible = "snps,dw-high-reset" }, + { .compatible = "snps,dw-low-reset", + .data = &reset_simple_active_low }, { /* sentinel */ }, }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings 2019-06-06 15:36 [PATCH V2 0/2] Add DesignWare IP support to simple reset Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 1/2] reset: " Luis Oliveira @ 2019-06-06 15:36 ` Luis Oliveira 2019-07-09 1:52 ` Rob Herring 1 sibling, 1 reply; 6+ messages in thread From: Luis Oliveira @ 2019-06-06 15:36 UTC (permalink / raw) To: p.zabel, robh+dt, mark.rutland, linux-kernel, devicetree Cc: Joao.Pinto, Luis Oliveira, Gustavo Pimentel This adds documentation of device tree bindings for the DesignWare IP reset controller. Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com> --- Changelog - Add active low configuration example - Fix compatible string in the active high example .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt diff --git a/Documentation/devicetree/bindings/reset/snps,dw-reset.txt b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt new file mode 100644 index 0000000..85f3301 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt @@ -0,0 +1,30 @@ +Synopsys DesignWare Reset controller +======================================= + +Please also refer to reset.txt in this directory for common reset +controller binding usage. + +Required properties: + +- compatible: should be one of the following. + "snps,dw-high-reset" - for active high configuration + "snps,dw-low-reset" - for active low configuration + +- reg: physical base address of the controller and length of memory mapped + region. + +- #reset-cells: must be 1. + +example: + + dw_rst_1: reset-controller@0000 { + compatible = "snps,dw-high-reset"; + reg = <0x0000 0x4>; + #reset-cells = <1>; + }; + + dw_rst_2: reset-controller@1000 {i + compatible = "snps,dw-low-reset"; + reg = <0x1000 0x8>; + #reset-cells = <1>; + }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings 2019-06-06 15:36 ` [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings Luis Oliveira @ 2019-07-09 1:52 ` Rob Herring 2019-07-09 10:33 ` Luis de Oliveira 0 siblings, 1 reply; 6+ messages in thread From: Rob Herring @ 2019-07-09 1:52 UTC (permalink / raw) To: Luis Oliveira Cc: p.zabel, mark.rutland, linux-kernel, devicetree, Joao.Pinto, Gustavo Pimentel On Thu, Jun 06, 2019 at 05:36:28PM +0200, Luis Oliveira wrote: > This adds documentation of device tree bindings for the > DesignWare IP reset controller. > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com> > --- > Changelog > - Add active low configuration example > - Fix compatible string in the active high example > > .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > diff --git a/Documentation/devicetree/bindings/reset/snps,dw-reset.txt b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > new file mode 100644 > index 0000000..85f3301 > --- /dev/null > +++ b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > @@ -0,0 +1,30 @@ > +Synopsys DesignWare Reset controller > +======================================= > + > +Please also refer to reset.txt in this directory for common reset > +controller binding usage. > + > +Required properties: > + > +- compatible: should be one of the following. > + "snps,dw-high-reset" - for active high configuration > + "snps,dw-low-reset" - for active low configuration This is really a standalone block? Are there versions of IP? > + > +- reg: physical base address of the controller and length of memory mapped > + region. > + > +- #reset-cells: must be 1. > + > +example: > + > + dw_rst_1: reset-controller@0000 { > + compatible = "snps,dw-high-reset"; > + reg = <0x0000 0x4>; > + #reset-cells = <1>; > + }; > + > + dw_rst_2: reset-controller@1000 {i > + compatible = "snps,dw-low-reset"; > + reg = <0x1000 0x8>; > + #reset-cells = <1>; > + }; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
* RE: [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings 2019-07-09 1:52 ` Rob Herring @ 2019-07-09 10:33 ` Luis de Oliveira 2019-07-09 13:23 ` Rob Herring 0 siblings, 1 reply; 6+ messages in thread From: Luis de Oliveira @ 2019-07-09 10:33 UTC (permalink / raw) To: Rob Herring, Luis Oliveira Cc: p.zabel@pengutronix.de, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Joao.Pinto@synopsys.com, Gustavo Pimentel Hi Rob, Thank you for the comments, From: Rob Herring <robh@kernel.org> Date: Tue, Jul 09, 2019 at 02:52:20 > On Thu, Jun 06, 2019 at 05:36:28PM +0200, Luis Oliveira wrote: > > This adds documentation of device tree bindings for the > > DesignWare IP reset controller. > > > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com> > > --- > > Changelog > > - Add active low configuration example > > - Fix compatible string in the active high example > > > > .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > > diff --git a/Documentation/devicetree/bindings/reset/snps,dw-reset.txt b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > new file mode 100644 > > index 0000000..85f3301 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > @@ -0,0 +1,30 @@ > > +Synopsys DesignWare Reset controller > > +======================================= > > + > > +Please also refer to reset.txt in this directory for common reset > > +controller binding usage. > > + > > +Required properties: > > + > > +- compatible: should be one of the following. > > + "snps,dw-high-reset" - for active high configuration > > + "snps,dw-low-reset" - for active low configuration > > This is really a standalone block? > > Are there versions of IP? > We use this block because is is very simple. The Verilog is autogenerated after an simple input configuration (APB config, reset pin number, active high/low, etc) so it does not need versioning. We use it in almost all our testchips and prototyping, and it is a standalone block. > > + > > +- reg: physical base address of the controller and length of memory mapped > > + region. > > + > > +- #reset-cells: must be 1. > > + > > +example: > > + > > + dw_rst_1: reset-controller@0000 { > > + compatible = "snps,dw-high-reset"; > > + reg = <0x0000 0x4>; > > + #reset-cells = <1>; > > + }; > > + > > + dw_rst_2: reset-controller@1000 {i > > + compatible = "snps,dw-low-reset"; > > + reg = <0x1000 0x8>; > > + #reset-cells = <1>; > > + }; > > -- > > 2.7.4 > > Thank you Rob, Luis ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings 2019-07-09 10:33 ` Luis de Oliveira @ 2019-07-09 13:23 ` Rob Herring 0 siblings, 0 replies; 6+ messages in thread From: Rob Herring @ 2019-07-09 13:23 UTC (permalink / raw) To: Luis de Oliveira Cc: p.zabel@pengutronix.de, mark.rutland@arm.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Joao.Pinto@synopsys.com, Gustavo Pimentel On Tue, Jul 9, 2019 at 4:33 AM Luis de Oliveira <Luis.Oliveira@synopsys.com> wrote: > > Hi Rob, > > Thank you for the comments, > > From: Rob Herring <robh@kernel.org> > Date: Tue, Jul 09, 2019 at 02:52:20 > > > On Thu, Jun 06, 2019 at 05:36:28PM +0200, Luis Oliveira wrote: > > > This adds documentation of device tree bindings for the > > > DesignWare IP reset controller. > > > > > > Signed-off-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com> > > > Signed-off-by: Luis Oliveira <luis.oliveira@synopsys.com> > > > --- > > > Changelog > > > - Add active low configuration example > > > - Fix compatible string in the active high example > > > > > > .../devicetree/bindings/reset/snps,dw-reset.txt | 30 ++++++++++++++++++++++ > > > 1 file changed, 30 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > > > > diff --git a/Documentation/devicetree/bindings/reset/snps,dw-reset.txt b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > new file mode 100644 > > > index 0000000..85f3301 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/reset/snps,dw-reset.txt > > > @@ -0,0 +1,30 @@ > > > +Synopsys DesignWare Reset controller > > > +======================================= > > > + > > > +Please also refer to reset.txt in this directory for common reset > > > +controller binding usage. > > > + > > > +Required properties: > > > + > > > +- compatible: should be one of the following. > > > + "snps,dw-high-reset" - for active high configuration > > > + "snps,dw-low-reset" - for active low configuration > > > > This is really a standalone block? > > > > Are there versions of IP? > > > > We use this block because is is very simple. The Verilog is autogenerated > after an simple input configuration (APB config, reset pin number, active > high/low, etc) so it does not need versioning. > We use it in almost all our testchips and prototyping, and it is a > standalone block. Okay. Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-07-09 13:23 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-06 15:36 [PATCH V2 0/2] Add DesignWare IP support to simple reset Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 1/2] reset: " Luis Oliveira 2019-06-06 15:36 ` [PATCH V2 2/2] dt-bindings: Document the DesignWare IP reset bindings Luis Oliveira 2019-07-09 1:52 ` Rob Herring 2019-07-09 10:33 ` Luis de Oliveira 2019-07-09 13:23 ` Rob Herring
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).