[PATCH 0/3] Add HDMI support to HiHope RZ/G2M

[PATCH 0/3] Add HDMI support to HiHope RZ/G2M

[Fabrizio Castro]

Dear All,

this series adds HDMI support to the HiHope RZ/G2M board.

Thanks,
Fab

Fabrizio Castro (3):
  dt-bindings: display: renesas: Add r8a774a1 support
  arm64: dts: renesas: r8a774a1: Add HDMI encoder instance
  arm64: dts: renesas: hihope-common: Add HDMI support

 .../bindings/display/bridge/renesas,dw-hdmi.txt    |  4 +-
 arch/arm64/boot/dts/renesas/hihope-common.dtsi     | 62 ++++++++++++++++++++++
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi          | 32 +++++++++++
 3 files changed, 97 insertions(+), 1 deletion(-)

-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

[Fabrizio Castro]

Document RZ/G2M (R8A774A1) SoC bindings.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
 Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
index a41d280..db68041 100644
--- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
+++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
@@ -12,10 +12,12 @@ following device-specific properties.
 Required properties:
 
 - compatible : Shall contain one or more of
+  - "renesas,r8a774a1-hdmi" for R8A774A1 (RZ/G2M) compatible HDMI TX
   - "renesas,r8a7795-hdmi" for R8A7795 (R-Car H3) compatible HDMI TX
   - "renesas,r8a7796-hdmi" for R8A7796 (R-Car M3-W) compatible HDMI TX
   - "renesas,r8a77965-hdmi" for R8A77965 (R-Car M3-N) compatible HDMI TX
-  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 compatible HDMI TX
+  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 and RZ/G2 compatible
+			     HDMI TX
 
     When compatible with generic versions, nodes must list the SoC-specific
     version corresponding to the platform first, followed by the
-- 
2.7.4

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Tue, Jun 18, 2019 at 04:18:37PM +0100, Fabrizio Castro wrote:
> Document RZ/G2M (R8A774A1) SoC bindings.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I don't have pending changes for this file for this kernel release. As
your series contains DT changes, I'm fine if this patch gets merged
through the ARM SoC tree along with the rest. Otherwise please let me
know if I should handle it myself.

> ---
>  Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> index a41d280..db68041 100644
> --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> @@ -12,10 +12,12 @@ following device-specific properties.
>  Required properties:
>  
>  - compatible : Shall contain one or more of
> +  - "renesas,r8a774a1-hdmi" for R8A774A1 (RZ/G2M) compatible HDMI TX
>    - "renesas,r8a7795-hdmi" for R8A7795 (R-Car H3) compatible HDMI TX
>    - "renesas,r8a7796-hdmi" for R8A7796 (R-Car M3-W) compatible HDMI TX
>    - "renesas,r8a77965-hdmi" for R8A77965 (R-Car M3-N) compatible HDMI TX
> -  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 compatible HDMI TX
> +  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 and RZ/G2 compatible
> +			     HDMI TX
>  
>      When compatible with generic versions, nodes must list the SoC-specific
>      version corresponding to the platform first, followed by the

-- 
Regards,

Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

RE: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

[Fabrizio Castro]

Hi Laurent,

Thank you for your feedback!

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 18 June 2019 17:44
> Subject: Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support
> 
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Tue, Jun 18, 2019 at 04:18:37PM +0100, Fabrizio Castro wrote:
> > Document RZ/G2M (R8A774A1) SoC bindings.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> I don't have pending changes for this file for this kernel release. As
> your series contains DT changes, I'm fine if this patch gets merged
> through the ARM SoC tree along with the rest. Otherwise please let me
> know if I should handle it myself.

Thank you Laurent, I think this patch can go along with the rest, if that's OK with
Simon?

Thanks,
Fab

> 
> > ---
> >  Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> > index a41d280..db68041 100644
> > --- a/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,dw-hdmi.txt
> > @@ -12,10 +12,12 @@ following device-specific properties.
> >  Required properties:
> >
> >  - compatible : Shall contain one or more of
> > +  - "renesas,r8a774a1-hdmi" for R8A774A1 (RZ/G2M) compatible HDMI TX
> >    - "renesas,r8a7795-hdmi" for R8A7795 (R-Car H3) compatible HDMI TX
> >    - "renesas,r8a7796-hdmi" for R8A7796 (R-Car M3-W) compatible HDMI TX
> >    - "renesas,r8a77965-hdmi" for R8A77965 (R-Car M3-N) compatible HDMI TX
> > -  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 compatible HDMI TX
> > +  - "renesas,rcar-gen3-hdmi" for the generic R-Car Gen3 and RZ/G2 compatible
> > +			     HDMI TX
> >
> >      When compatible with generic versions, nodes must list the SoC-specific
> >      version corresponding to the platform first, followed by the
> 
> --
> Regards,
> 
> Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support

[Simon Horman]

On Wed, Jun 19, 2019 at 08:08:09AM +0000, Fabrizio Castro wrote:
> Hi Laurent,
> 
> Thank you for your feedback!
> 
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> > Sent: 18 June 2019 17:44
> > Subject: Re: [PATCH 1/3] dt-bindings: display: renesas: Add r8a774a1 support
> > 
> > Hi Fabrizio,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Jun 18, 2019 at 04:18:37PM +0100, Fabrizio Castro wrote:
> > > Document RZ/G2M (R8A774A1) SoC bindings.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > I don't have pending changes for this file for this kernel release. As
> > your series contains DT changes, I'm fine if this patch gets merged
> > through the ARM SoC tree along with the rest. Otherwise please let me
> > know if I should handle it myself.
> 
> Thank you Laurent, I think this patch can go along with the rest, if that's OK with
> Simon?

Thanks,

I've queued this up in the renesas tree for inclusion in v5.3.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance

[Fabrizio Castro]

Add the HDMI encoder to the R8A774A1 DT in disabled state.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
This patch depends on:
https://patchwork.kernel.org/patch/10995149/

 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 32 +++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index d6dd4b6..a849ca7 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -2397,6 +2397,37 @@
 			};
 		};
 
+		hdmi0: hdmi@fead0000 {
+			compatible = "renesas,r8a774a1-hdmi",
+				     "renesas,rcar-gen3-hdmi";
+			reg = <0 0xfead0000 0 0x10000>;
+			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 729>,
+				 <&cpg CPG_CORE R8A774A1_CLK_HDMI>;
+			clock-names = "iahb", "isfr";
+			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
+			resets = <&cpg 729>;
+			status = "disabled";
+
+			ports {
+				#address-cells = <1>;
+				#size-cells = <0>;
+				port@0 {
+					reg = <0>;
+					dw_hdmi0_in: endpoint {
+						remote-endpoint = <&du_out_hdmi0>;
+					};
+				};
+				port@1 {
+					reg = <1>;
+				};
+				port@2 {
+					/* HDMI sound */
+					reg = <2>;
+				};
+			};
+		};
+
 		du: display@feb00000 {
 			compatible = "renesas,du-r8a774a1";
 			reg = <0 0xfeb00000 0 0x70000>;
@@ -2423,6 +2454,7 @@
 				port@1 {
 					reg = <1>;
 					du_out_hdmi0: endpoint {
+						remote-endpoint = <&dw_hdmi0_in>;
 					};
 				};
 				port@2 {
-- 
2.7.4

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Tue, Jun 18, 2019 at 04:18:38PM +0100, Fabrizio Castro wrote:
> Add the HDMI encoder to the R8A774A1 DT in disabled state.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> ---
> This patch depends on:
> https://patchwork.kernel.org/patch/10995149/

Is that the correct one ? I don't see how CAN support is related.

In any case,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 32 +++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> index d6dd4b6..a849ca7 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> @@ -2397,6 +2397,37 @@
>  			};
>  		};
>  
> +		hdmi0: hdmi@fead0000 {
> +			compatible = "renesas,r8a774a1-hdmi",
> +				     "renesas,rcar-gen3-hdmi";
> +			reg = <0 0xfead0000 0 0x10000>;
> +			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> +			clocks = <&cpg CPG_MOD 729>,
> +				 <&cpg CPG_CORE R8A774A1_CLK_HDMI>;
> +			clock-names = "iahb", "isfr";
> +			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
> +			resets = <&cpg 729>;
> +			status = "disabled";
> +
> +			ports {
> +				#address-cells = <1>;
> +				#size-cells = <0>;
> +				port@0 {
> +					reg = <0>;
> +					dw_hdmi0_in: endpoint {
> +						remote-endpoint = <&du_out_hdmi0>;
> +					};
> +				};
> +				port@1 {
> +					reg = <1>;
> +				};
> +				port@2 {
> +					/* HDMI sound */
> +					reg = <2>;
> +				};
> +			};
> +		};
> +
>  		du: display@feb00000 {
>  			compatible = "renesas,du-r8a774a1";
>  			reg = <0 0xfeb00000 0 0x70000>;
> @@ -2423,6 +2454,7 @@
>  				port@1 {
>  					reg = <1>;
>  					du_out_hdmi0: endpoint {
> +						remote-endpoint = <&dw_hdmi0_in>;
>  					};
>  				};
>  				port@2 {

-- 
Regards,

Laurent Pinchart

RE: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance

[Fabrizio Castro]

Hello Laurent,

Thank you for your feedback.

> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 19 June 2019 13:39
> Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance
> 
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Tue, Jun 18, 2019 at 04:18:38PM +0100, Fabrizio Castro wrote:
> > Add the HDMI encoder to the R8A774A1 DT in disabled state.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > This patch depends on:
> > https://patchwork.kernel.org/patch/10995149/
> 
> Is that the correct one ? I don't see how CAN support is related.

It's only to please git ;-)

Thank you for reviewing this.

Fab

> 
> In any case,
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> >  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 32 +++++++++++++++++++++++++++++++
> >  1 file changed, 32 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > index d6dd4b6..a849ca7 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -2397,6 +2397,37 @@
> >  			};
> >  		};
> >
> > +		hdmi0: hdmi@fead0000 {
> > +			compatible = "renesas,r8a774a1-hdmi",
> > +				     "renesas,rcar-gen3-hdmi";
> > +			reg = <0 0xfead0000 0 0x10000>;
> > +			interrupts = <GIC_SPI 389 IRQ_TYPE_LEVEL_HIGH>;
> > +			clocks = <&cpg CPG_MOD 729>,
> > +				 <&cpg CPG_CORE R8A774A1_CLK_HDMI>;
> > +			clock-names = "iahb", "isfr";
> > +			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
> > +			resets = <&cpg 729>;
> > +			status = "disabled";
> > +
> > +			ports {
> > +				#address-cells = <1>;
> > +				#size-cells = <0>;
> > +				port@0 {
> > +					reg = <0>;
> > +					dw_hdmi0_in: endpoint {
> > +						remote-endpoint = <&du_out_hdmi0>;
> > +					};
> > +				};
> > +				port@1 {
> > +					reg = <1>;
> > +				};
> > +				port@2 {
> > +					/* HDMI sound */
> > +					reg = <2>;
> > +				};
> > +			};
> > +		};
> > +
> >  		du: display@feb00000 {
> >  			compatible = "renesas,du-r8a774a1";
> >  			reg = <0 0xfeb00000 0 0x70000>;
> > @@ -2423,6 +2454,7 @@
> >  				port@1 {
> >  					reg = <1>;
> >  					du_out_hdmi0: endpoint {
> > +						remote-endpoint = <&dw_hdmi0_in>;
> >  					};
> >  				};
> >  				port@2 {
> 
> --
> Regards,
> 
> Laurent Pinchart

Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance

[Simon Horman]

On Wed, Jun 19, 2019 at 12:42:24PM +0000, Fabrizio Castro wrote:
> Hello Laurent,
> 
> Thank you for your feedback.
> 
> > From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Sent: 19 June 2019 13:39
> > Subject: Re: [PATCH 2/3] arm64: dts: renesas: r8a774a1: Add HDMI encoder instance
> > 
> > Hi Fabrizio,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Jun 18, 2019 at 04:18:38PM +0100, Fabrizio Castro wrote:
> > > Add the HDMI encoder to the R8A774A1 DT in disabled state.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > ---
> > > This patch depends on:
> > > https://patchwork.kernel.org/patch/10995149/
> > 
> > Is that the correct one ? I don't see how CAN support is related.
> 
> It's only to please git ;-)
> 
> Thank you for reviewing this.
> 
> Fab
> 
> > 
> > In any case,
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Thanks, I have queued this up for inclusion in v5.3.

[PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Fabrizio Castro]

Add HDMI support to the HiHope RZ/G2[MN] mother board common
dtsi.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
Please note that this patch was tested with a 4K monitor and cma=96M

 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
 1 file changed, 62 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 625c3aa..e7568e1 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -17,6 +17,18 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	hdmi0-out {
+		compatible = "hdmi-connector";
+		label = "HDMI0 OUT";
+		type = "a";
+
+		port {
+			hdmi0_con: endpoint {
+				remote-endpoint = <&rcar_dw_hdmi0_out>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -82,6 +94,30 @@
 		states = <3300000 1
 			  1800000 0>;
 	};
+
+	x302_clk: x302-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <33000000>;
+	};
+
+	x304_clk: x304-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <25000000>;
+	};
+};
+
+&du {
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&cpg CPG_MOD 722>,
+		 <&versaclock5 1>,
+		 <&x302_clk>,
+		 <&versaclock5 2>;
+	clock-names = "du.0", "du.1", "du.2",
+		      "dclkin.0", "dclkin.1", "dclkin.2";
+	status = "okay";
 };
 
 &ehci0 {
@@ -109,11 +145,37 @@
 	};
 };
 
+&hdmi0 {
+	status = "okay";
+
+	ports {
+		port@1 {
+			reg = <1>;
+			rcar_dw_hdmi0_out: endpoint {
+				remote-endpoint = <&hdmi0_con>;
+			};
+		};
+	};
+};
+
 &hsusb {
 	dr_mode = "otg";
 	status = "okay";
 };
 
+&i2c4 {
+	clock-frequency = <400000>;
+	status = "okay";
+
+	versaclock5: clock-generator@6a {
+		compatible = "idt,5p49v5923";
+		reg = <0x6a>;
+		#clock-cells = <1>;
+		clocks = <&x304_clk>;
+		clock-names = "xin";
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.7.4

Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Laurent Pinchart]

Hi Fabrizio,

Thank you for the patch.

On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> Add HDMI support to the HiHope RZ/G2[MN] mother board common
> dtsi.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> ---
> Please note that this patch was tested with a 4K monitor and cma=96M
> 
>  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
>  1 file changed, 62 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> index 625c3aa..e7568e1 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -17,6 +17,18 @@
>  		stdout-path = "serial0:115200n8";
>  	};
>  
> +	hdmi0-out {
> +		compatible = "hdmi-connector";
> +		label = "HDMI0 OUT";

Is the label physically present on the device (printed on the board or
the case) ?

Apart from that, without access to the schematics I can't really tell if
the DT is correct, but nothing strikes me as really wrong, so

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +		type = "a";
> +
> +		port {
> +			hdmi0_con: endpoint {
> +				remote-endpoint = <&rcar_dw_hdmi0_out>;
> +			};
> +		};
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
>  
> @@ -82,6 +94,30 @@
>  		states = <3300000 1
>  			  1800000 0>;
>  	};
> +
> +	x302_clk: x302-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <33000000>;
> +	};
> +
> +	x304_clk: x304-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <25000000>;
> +	};
> +};
> +
> +&du {
> +	clocks = <&cpg CPG_MOD 724>,
> +		 <&cpg CPG_MOD 723>,
> +		 <&cpg CPG_MOD 722>,
> +		 <&versaclock5 1>,
> +		 <&x302_clk>,
> +		 <&versaclock5 2>;
> +	clock-names = "du.0", "du.1", "du.2",
> +		      "dclkin.0", "dclkin.1", "dclkin.2";
> +	status = "okay";
>  };
>  
>  &ehci0 {
> @@ -109,11 +145,37 @@
>  	};
>  };
>  
> +&hdmi0 {
> +	status = "okay";
> +
> +	ports {
> +		port@1 {
> +			reg = <1>;
> +			rcar_dw_hdmi0_out: endpoint {
> +				remote-endpoint = <&hdmi0_con>;
> +			};
> +		};
> +	};
> +};
> +
>  &hsusb {
>  	dr_mode = "otg";
>  	status = "okay";
>  };
>  
> +&i2c4 {
> +	clock-frequency = <400000>;
> +	status = "okay";
> +
> +	versaclock5: clock-generator@6a {
> +		compatible = "idt,5p49v5923";
> +		reg = <0x6a>;
> +		#clock-cells = <1>;
> +		clocks = <&x304_clk>;
> +		clock-names = "xin";
> +	};
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };

-- 
Regards,

Laurent Pinchart

RE: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Fabrizio Castro]

Hi Laurent,

> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> Sent: 19 June 2019 13:42
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
> 
> Hi Fabrizio,
> 
> Thank you for the patch.
> 
> On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> > Add HDMI support to the HiHope RZ/G2[MN] mother board common
> > dtsi.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > ---
> > Please note that this patch was tested with a 4K monitor and cma=96M
> >
> >  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> >  1 file changed, 62 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > index 625c3aa..e7568e1 100644
> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > @@ -17,6 +17,18 @@
> >  		stdout-path = "serial0:115200n8";
> >  	};
> >
> > +	hdmi0-out {
> > +		compatible = "hdmi-connector";
> > +		label = "HDMI0 OUT";
> 
> Is the label physically present on the device (printed on the board or
> the case) ?

I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?

> 
> Apart from that, without access to the schematics I can't really tell if
> the DT is correct, but nothing strikes me as really wrong, so

I didn't know you had no access to the schematics, on their way...

Thanks,
Fab

> 
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> > +		type = "a";
> > +
> > +		port {
> > +			hdmi0_con: endpoint {
> > +				remote-endpoint = <&rcar_dw_hdmi0_out>;
> > +			};
> > +		};
> > +	};
> > +
> >  	leds {
> >  		compatible = "gpio-leds";
> >
> > @@ -82,6 +94,30 @@
> >  		states = <3300000 1
> >  			  1800000 0>;
> >  	};
> > +
> > +	x302_clk: x302-clock {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <33000000>;
> > +	};
> > +
> > +	x304_clk: x304-clock {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <25000000>;
> > +	};
> > +};
> > +
> > +&du {
> > +	clocks = <&cpg CPG_MOD 724>,
> > +		 <&cpg CPG_MOD 723>,
> > +		 <&cpg CPG_MOD 722>,
> > +		 <&versaclock5 1>,
> > +		 <&x302_clk>,
> > +		 <&versaclock5 2>;
> > +	clock-names = "du.0", "du.1", "du.2",
> > +		      "dclkin.0", "dclkin.1", "dclkin.2";
> > +	status = "okay";
> >  };
> >
> >  &ehci0 {
> > @@ -109,11 +145,37 @@
> >  	};
> >  };
> >
> > +&hdmi0 {
> > +	status = "okay";
> > +
> > +	ports {
> > +		port@1 {
> > +			reg = <1>;
> > +			rcar_dw_hdmi0_out: endpoint {
> > +				remote-endpoint = <&hdmi0_con>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> >  &hsusb {
> >  	dr_mode = "otg";
> >  	status = "okay";
> >  };
> >
> > +&i2c4 {
> > +	clock-frequency = <400000>;
> > +	status = "okay";
> > +
> > +	versaclock5: clock-generator@6a {
> > +		compatible = "idt,5p49v5923";
> > +		reg = <0x6a>;
> > +		#clock-cells = <1>;
> > +		clocks = <&x304_clk>;
> > +		clock-names = "xin";
> > +	};
> > +};
> > +
> >  &ohci0 {
> >  	status = "okay";
> >  };
> 
> --
> Regards,
> 
> Laurent Pinchart

Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Simon Horman]

On Wed, Jun 19, 2019 at 12:48:17PM +0000, Fabrizio Castro wrote:
> Hi Laurent,
> 
> > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> > Sent: 19 June 2019 13:42
> > Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
> > 
> > Hi Fabrizio,
> > 
> > Thank you for the patch.
> > 
> > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> > > Add HDMI support to the HiHope RZ/G2[MN] mother board common
> > > dtsi.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > ---
> > > Please note that this patch was tested with a 4K monitor and cma=96M
> > >
> > >  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> > >  1 file changed, 62 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > index 625c3aa..e7568e1 100644
> > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > @@ -17,6 +17,18 @@
> > >  		stdout-path = "serial0:115200n8";
> > >  	};
> > >
> > > +	hdmi0-out {
> > > +		compatible = "hdmi-connector";
> > > +		label = "HDMI0 OUT";
> > 
> > Is the label physically present on the device (printed on the board or
> > the case) ?
> 
> I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?

Thanks,

I have removed the label attribute when queuing this patch up for v5.3.
The result is as follows:

From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Date: Tue, 18 Jun 2019 16:18:39 +0100
Subject: [PATCH] arm64: dts: renesas: hihope-common: Add HDMI support

Add HDMI support to the HiHope RZ/G2[MN] mother board common
dtsi.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
 arch/arm64/boot/dts/renesas/hihope-common.dtsi | 61 ++++++++++++++++++++++++++
 1 file changed, 61 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
index 625c3aaead14..9f05e80cee10 100644
--- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
+++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
@@ -17,6 +17,17 @@
 		stdout-path = "serial0:115200n8";
 	};
 
+	hdmi0-out {
+		compatible = "hdmi-connector";
+		type = "a";
+
+		port {
+			hdmi0_con: endpoint {
+				remote-endpoint = <&rcar_dw_hdmi0_out>;
+			};
+		};
+	};
+
 	leds {
 		compatible = "gpio-leds";
 
@@ -82,6 +93,30 @@
 		states = <3300000 1
 			  1800000 0>;
 	};
+
+	x302_clk: x302-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <33000000>;
+	};
+
+	x304_clk: x304-clock {
+		compatible = "fixed-clock";
+		#clock-cells = <0>;
+		clock-frequency = <25000000>;
+	};
+};
+
+&du {
+	clocks = <&cpg CPG_MOD 724>,
+		 <&cpg CPG_MOD 723>,
+		 <&cpg CPG_MOD 722>,
+		 <&versaclock5 1>,
+		 <&x302_clk>,
+		 <&versaclock5 2>;
+	clock-names = "du.0", "du.1", "du.2",
+		      "dclkin.0", "dclkin.1", "dclkin.2";
+	status = "okay";
 };
 
 &ehci0 {
@@ -109,11 +144,37 @@
 	};
 };
 
+&hdmi0 {
+	status = "okay";
+
+	ports {
+		port@1 {
+			reg = <1>;
+			rcar_dw_hdmi0_out: endpoint {
+				remote-endpoint = <&hdmi0_con>;
+			};
+		};
+	};
+};
+
 &hsusb {
 	dr_mode = "otg";
 	status = "okay";
 };
 
+&i2c4 {
+	clock-frequency = <400000>;
+	status = "okay";
+
+	versaclock5: clock-generator@6a {
+		compatible = "idt,5p49v5923";
+		reg = <0x6a>;
+		#clock-cells = <1>;
+		clocks = <&x304_clk>;
+		clock-names = "xin";
+	};
+};
+
 &ohci0 {
 	status = "okay";
 };
-- 
2.11.0

RE: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 19 June 2019 15:07
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
> 
> On Wed, Jun 19, 2019 at 12:48:17PM +0000, Fabrizio Castro wrote:
> > Hi Laurent,
> >
> > > From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Laurent Pinchart
> > > Sent: 19 June 2019 13:42
> > > Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
> > >
> > > Hi Fabrizio,
> > >
> > > Thank you for the patch.
> > >
> > > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> > > > Add HDMI support to the HiHope RZ/G2[MN] mother board common
> > > > dtsi.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > >
> > > > ---
> > > > Please note that this patch was tested with a 4K monitor and cma=96M
> > > >
> > > >  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> > > >  1 file changed, 62 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > index 625c3aa..e7568e1 100644
> > > > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > > > @@ -17,6 +17,18 @@
> > > >  		stdout-path = "serial0:115200n8";
> > > >  	};
> > > >
> > > > +	hdmi0-out {
> > > > +		compatible = "hdmi-connector";
> > > > +		label = "HDMI0 OUT";
> > >
> > > Is the label physically present on the device (printed on the board or
> > > the case) ?
> >
> > I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?
> 
> Thanks,
> 
> I have removed the label attribute when queuing this patch up for v5.3.
> The result is as follows:

Great, thank you Simon!

Fab

> 
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Date: Tue, 18 Jun 2019 16:18:39 +0100
> Subject: [PATCH] arm64: dts: renesas: hihope-common: Add HDMI support
> 
> Add HDMI support to the HiHope RZ/G2[MN] mother board common
> dtsi.
> 
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
>  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 61 ++++++++++++++++++++++++++
>  1 file changed, 61 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> index 625c3aaead14..9f05e80cee10 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -17,6 +17,17 @@
>  		stdout-path = "serial0:115200n8";
>  	};
> 
> +	hdmi0-out {
> +		compatible = "hdmi-connector";
> +		type = "a";
> +
> +		port {
> +			hdmi0_con: endpoint {
> +				remote-endpoint = <&rcar_dw_hdmi0_out>;
> +			};
> +		};
> +	};
> +
>  	leds {
>  		compatible = "gpio-leds";
> 
> @@ -82,6 +93,30 @@
>  		states = <3300000 1
>  			  1800000 0>;
>  	};
> +
> +	x302_clk: x302-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <33000000>;
> +	};
> +
> +	x304_clk: x304-clock {
> +		compatible = "fixed-clock";
> +		#clock-cells = <0>;
> +		clock-frequency = <25000000>;
> +	};
> +};
> +
> +&du {
> +	clocks = <&cpg CPG_MOD 724>,
> +		 <&cpg CPG_MOD 723>,
> +		 <&cpg CPG_MOD 722>,
> +		 <&versaclock5 1>,
> +		 <&x302_clk>,
> +		 <&versaclock5 2>;
> +	clock-names = "du.0", "du.1", "du.2",
> +		      "dclkin.0", "dclkin.1", "dclkin.2";
> +	status = "okay";
>  };
> 
>  &ehci0 {
> @@ -109,11 +144,37 @@
>  	};
>  };
> 
> +&hdmi0 {
> +	status = "okay";
> +
> +	ports {
> +		port@1 {
> +			reg = <1>;
> +			rcar_dw_hdmi0_out: endpoint {
> +				remote-endpoint = <&hdmi0_con>;
> +			};
> +		};
> +	};
> +};
> +
>  &hsusb {
>  	dr_mode = "otg";
>  	status = "okay";
>  };
> 
> +&i2c4 {
> +	clock-frequency = <400000>;
> +	status = "okay";
> +
> +	versaclock5: clock-generator@6a {
> +		compatible = "idt,5p49v5923";
> +		reg = <0x6a>;
> +		#clock-cells = <1>;
> +		clocks = <&x304_clk>;
> +		clock-names = "xin";
> +	};
> +};
> +
>  &ohci0 {
>  	status = "okay";
>  };
> --
> 2.11.0

Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Laurent Pinchart]

Hi Fabrizio,

On Wed, Jun 19, 2019 at 12:48:17PM +0000, Fabrizio Castro wrote:
> On Sent: 19 June 2019 13:42 Laurent Pinchart wrote:
> > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> >> Add HDMI support to the HiHope RZ/G2[MN] mother board common
> >> dtsi.
> >>
> >> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >>
> >> ---
> >> Please note that this patch was tested with a 4K monitor and cma=96M
> >>
> >>  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> >>  1 file changed, 62 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> >> index 625c3aa..e7568e1 100644
> >> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> >> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> >> @@ -17,6 +17,18 @@
> >>  		stdout-path = "serial0:115200n8";
> >>  	};
> >>
> >> +	hdmi0-out {
> >> +		compatible = "hdmi-connector";
> >> +		label = "HDMI0 OUT";
> > 
> > Is the label physically present on the device (printed on the board or
> > the case) ?
> 
> I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?
> 
> > Apart from that, without access to the schematics I can't really tell if
> > the DT is correct, but nothing strikes me as really wrong, so
> 
> I didn't know you had no access to the schematics, on their way...

Thank you. I confirm the DT looks good.

On a side note, there's an ESD protection and level shifter chip between
the HDMI output and the HDMI connector. On this board all its control
pins are hardwired to fixed levels, so it's completely transparent, but
in other cases it should be modelled in DT. I'm working on a driver for
the TPD12S015 which should be quite similar, I will post it soon.

> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> >> +		type = "a";
> >> +
> >> +		port {
> >> +			hdmi0_con: endpoint {
> >> +				remote-endpoint = <&rcar_dw_hdmi0_out>;
> >> +			};
> >> +		};
> >> +	};
> >> +
> >>  	leds {
> >>  		compatible = "gpio-leds";
> >>
> >> @@ -82,6 +94,30 @@
> >>  		states = <3300000 1
> >>  			  1800000 0>;
> >>  	};
> >> +
> >> +	x302_clk: x302-clock {
> >> +		compatible = "fixed-clock";
> >> +		#clock-cells = <0>;
> >> +		clock-frequency = <33000000>;
> >> +	};
> >> +
> >> +	x304_clk: x304-clock {
> >> +		compatible = "fixed-clock";
> >> +		#clock-cells = <0>;
> >> +		clock-frequency = <25000000>;
> >> +	};
> >> +};
> >> +
> >> +&du {
> >> +	clocks = <&cpg CPG_MOD 724>,
> >> +		 <&cpg CPG_MOD 723>,
> >> +		 <&cpg CPG_MOD 722>,
> >> +		 <&versaclock5 1>,
> >> +		 <&x302_clk>,
> >> +		 <&versaclock5 2>;
> >> +	clock-names = "du.0", "du.1", "du.2",
> >> +		      "dclkin.0", "dclkin.1", "dclkin.2";
> >> +	status = "okay";
> >>  };
> >>
> >>  &ehci0 {
> >> @@ -109,11 +145,37 @@
> >>  	};
> >>  };
> >>
> >> +&hdmi0 {
> >> +	status = "okay";
> >> +
> >> +	ports {
> >> +		port@1 {
> >> +			reg = <1>;
> >> +			rcar_dw_hdmi0_out: endpoint {
> >> +				remote-endpoint = <&hdmi0_con>;
> >> +			};
> >> +		};
> >> +	};
> >> +};
> >> +
> >>  &hsusb {
> >>  	dr_mode = "otg";
> >>  	status = "okay";
> >>  };
> >>
> >> +&i2c4 {
> >> +	clock-frequency = <400000>;
> >> +	status = "okay";
> >> +
> >> +	versaclock5: clock-generator@6a {
> >> +		compatible = "idt,5p49v5923";
> >> +		reg = <0x6a>;
> >> +		#clock-cells = <1>;
> >> +		clocks = <&x304_clk>;
> >> +		clock-names = "xin";
> >> +	};
> >> +};
> >> +
> >>  &ohci0 {
> >>  	status = "okay";
> >>  };

-- 
Regards,

Laurent Pinchart

RE: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support

[Fabrizio Castro]

Hello Laurent,

Thank you for your feedback!

> From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Sent: 19 June 2019 15:36
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
> 
> Hi Fabrizio,
> 
> On Wed, Jun 19, 2019 at 12:48:17PM +0000, Fabrizio Castro wrote:
> > On Sent: 19 June 2019 13:42 Laurent Pinchart wrote:
> > > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> > >> Add HDMI support to the HiHope RZ/G2[MN] mother board common
> > >> dtsi.
> > >>
> > >> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >>
> > >> ---
> > >> Please note that this patch was tested with a 4K monitor and cma=96M
> > >>
> > >>  arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> > >>  1 file changed, 62 insertions(+)
> > >>
> > >> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> index 625c3aa..e7568e1 100644
> > >> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> @@ -17,6 +17,18 @@
> > >>  		stdout-path = "serial0:115200n8";
> > >>  	};
> > >>
> > >> +	hdmi0-out {
> > >> +		compatible = "hdmi-connector";
> > >> +		label = "HDMI0 OUT";
> > >
> > > Is the label physically present on the device (printed on the board or
> > > the case) ?
> >
> > I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?
> >
> > > Apart from that, without access to the schematics I can't really tell if
> > > the DT is correct, but nothing strikes me as really wrong, so
> >
> > I didn't know you had no access to the schematics, on their way...
> 
> Thank you. I confirm the DT looks good.

Thank you!

> 
> On a side note, there's an ESD protection and level shifter chip between
> the HDMI output and the HDMI connector. On this board all its control
> pins are hardwired to fixed levels, so it's completely transparent, but
> in other cases it should be modelled in DT. I'm working on a driver for
> the TPD12S015 which should be quite similar, I will post it soon.

Good to know, I am looking forward to see it.

Thanks,
Fab

> 
> > > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > >
> > >> +		type = "a";
> > >> +
> > >> +		port {
> > >> +			hdmi0_con: endpoint {
> > >> +				remote-endpoint = <&rcar_dw_hdmi0_out>;
> > >> +			};
> > >> +		};
> > >> +	};
> > >> +
> > >>  	leds {
> > >>  		compatible = "gpio-leds";
> > >>
> > >> @@ -82,6 +94,30 @@
> > >>  		states = <3300000 1
> > >>  			  1800000 0>;
> > >>  	};
> > >> +
> > >> +	x302_clk: x302-clock {
> > >> +		compatible = "fixed-clock";
> > >> +		#clock-cells = <0>;
> > >> +		clock-frequency = <33000000>;
> > >> +	};
> > >> +
> > >> +	x304_clk: x304-clock {
> > >> +		compatible = "fixed-clock";
> > >> +		#clock-cells = <0>;
> > >> +		clock-frequency = <25000000>;
> > >> +	};
> > >> +};
> > >> +
> > >> +&du {
> > >> +	clocks = <&cpg CPG_MOD 724>,
> > >> +		 <&cpg CPG_MOD 723>,
> > >> +		 <&cpg CPG_MOD 722>,
> > >> +		 <&versaclock5 1>,
> > >> +		 <&x302_clk>,
> > >> +		 <&versaclock5 2>;
> > >> +	clock-names = "du.0", "du.1", "du.2",
> > >> +		      "dclkin.0", "dclkin.1", "dclkin.2";
> > >> +	status = "okay";
> > >>  };
> > >>
> > >>  &ehci0 {
> > >> @@ -109,11 +145,37 @@
> > >>  	};
> > >>  };
> > >>
> > >> +&hdmi0 {
> > >> +	status = "okay";
> > >> +
> > >> +	ports {
> > >> +		port@1 {
> > >> +			reg = <1>;
> > >> +			rcar_dw_hdmi0_out: endpoint {
> > >> +				remote-endpoint = <&hdmi0_con>;
> > >> +			};
> > >> +		};
> > >> +	};
> > >> +};
> > >> +
> > >>  &hsusb {
> > >>  	dr_mode = "otg";
> > >>  	status = "okay";
> > >>  };
> > >>
> > >> +&i2c4 {
> > >> +	clock-frequency = <400000>;
> > >> +	status = "okay";
> > >> +
> > >> +	versaclock5: clock-generator@6a {
> > >> +		compatible = "idt,5p49v5923";
> > >> +		reg = <0x6a>;
> > >> +		#clock-cells = <1>;
> > >> +		clocks = <&x304_clk>;
> > >> +		clock-names = "xin";
> > >> +	};
> > >> +};
> > >> +
> > >>  &ohci0 {
> > >>  	status = "okay";
> > >>  };
> 
> --
> Regards,
> 
> Laurent Pinchart