devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sowjanya Komatineni <skomatineni@nvidia.com>
To: thierry.reding@gmail.com, jonathanh@nvidia.com,
	tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com,
	linus.walleij@linaro.org, stefan@agner.ch, mark.rutland@arm.com
Cc: pdeschrijver@nvidia.com, pgaikwad@nvidia.com, sboyd@kernel.org,
	linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org,
	jckuo@nvidia.com, josephl@nvidia.com, talho@nvidia.com,
	skomatineni@nvidia.com, linux-tegra@vger.kernel.org,
	linux-kernel@vger.kernel.org, mperttunen@nvidia.com,
	spatra@nvidia.com, robh+dt@kernel.org, digetx@gmail.com,
	devicetree@vger.kernel.org
Subject: [PATCH V4 01/18] irqchip: tegra: do not disable COP IRQ during suspend
Date: Sun, 23 Jun 2019 20:02:42 -0700	[thread overview]
Message-ID: <1561345379-2429-2-git-send-email-skomatineni@nvidia.com> (raw)
In-Reply-To: <1561345379-2429-1-git-send-email-skomatineni@nvidia.com>

Tegra210 platforms use sc7 entry firmware to program Tegra LP0/SC7 entry
sequence and sc7 entry firmware is run from COP/BPMP-Lite.

So, COP/BPMP-Lite still need IRQ function to finish SC7 suspend sequence
for Tegra210.

This patch has fix for leaving the COP IRQ enabled for Tegra210 during
interrupt controller suspend operation.

Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Sowjanya Komatineni <skomatineni@nvidia.com>
---
 drivers/irqchip/irq-tegra.c | 20 ++++++++++++++++++--
 1 file changed, 18 insertions(+), 2 deletions(-)

diff --git a/drivers/irqchip/irq-tegra.c b/drivers/irqchip/irq-tegra.c
index e1f771c72fc4..851f88cef508 100644
--- a/drivers/irqchip/irq-tegra.c
+++ b/drivers/irqchip/irq-tegra.c
@@ -44,6 +44,7 @@ static unsigned int num_ictlrs;
 
 struct tegra_ictlr_soc {
 	unsigned int num_ictlrs;
+	bool supports_sc7;
 };
 
 static const struct tegra_ictlr_soc tegra20_ictlr_soc = {
@@ -56,6 +57,7 @@ static const struct tegra_ictlr_soc tegra30_ictlr_soc = {
 
 static const struct tegra_ictlr_soc tegra210_ictlr_soc = {
 	.num_ictlrs = 6,
+	.supports_sc7 = true,
 };
 
 static const struct of_device_id ictlr_matches[] = {
@@ -67,6 +69,7 @@ static const struct of_device_id ictlr_matches[] = {
 
 struct tegra_ictlr_info {
 	void __iomem *base[TEGRA_MAX_NUM_ICTLRS];
+	const struct tegra_ictlr_soc *soc;
 #ifdef CONFIG_PM_SLEEP
 	u32 cop_ier[TEGRA_MAX_NUM_ICTLRS];
 	u32 cop_iep[TEGRA_MAX_NUM_ICTLRS];
@@ -147,8 +150,20 @@ static int tegra_ictlr_suspend(void)
 		lic->cop_ier[i] = readl_relaxed(ictlr + ICTLR_COP_IER);
 		lic->cop_iep[i] = readl_relaxed(ictlr + ICTLR_COP_IEP_CLASS);
 
-		/* Disable COP interrupts */
-		writel_relaxed(~0ul, ictlr + ICTLR_COP_IER_CLR);
+		/*
+		 * AVP/COP/BPMP-Lite is the Tegra boot processor.
+		 *
+		 * Tegra210 system suspend flow uses sc7entry firmware which
+		 * is executed by COP/BPMP and it includes disabling COP IRQ,
+		 * clamping CPU rail, turning off VDD_CPU, and preparing the
+		 * system to go to SC7/LP0.
+		 *
+		 * COP/BPMP wakes up when COP IRQ is triggered and runs
+		 * sc7entry-firmware. So need to keep COP interrupt enabled.
+		 */
+		if (!lic->soc->supports_sc7)
+			/* Disable COP interrupts if SC7 is not supported */
+			writel_relaxed(~0ul, ictlr + ICTLR_COP_IER_CLR);
 
 		/* Disable CPU interrupts */
 		writel_relaxed(~0ul, ictlr + ICTLR_CPU_IER_CLR);
@@ -339,6 +354,7 @@ static int __init tegra_ictlr_init(struct device_node *node,
 		goto out_unmap;
 	}
 
+	lic->soc = soc;
 	tegra_ictlr_syscore_init();
 
 	pr_info("%pOF: %d interrupts forwarded to %pOF\n",
-- 
2.7.4

  reply	other threads:[~2019-06-24  3:02 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-24  3:02 [PATCH V4 00/18] SC7 entry and exit support for Tegra210 Sowjanya Komatineni
2019-06-24  3:02 ` Sowjanya Komatineni [this message]
2019-06-24  3:02 ` [PATCH V4 02/18] pinctrl: tegra: add suspend and resume support Sowjanya Komatineni
2019-06-24  9:46   ` Dmitry Osipenko
2019-06-24 17:34     ` Sowjanya Komatineni
2019-06-26 10:08   ` Thierry Reding
2019-06-24  3:02 ` [PATCH V4 03/18] gpio: tegra: use resume_noirq for tegra gpio resume Sowjanya Komatineni
2019-06-25 13:38   ` Linus Walleij
2019-06-26 17:06     ` Sowjanya Komatineni
2019-06-25 13:40   ` Thierry Reding
2019-06-24  3:02 ` [PATCH V4 04/18] clk: tegra: save and restore divider rate Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 05/18] clk: tegra: pllout: save and restore pllout context Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 06/18] clk: tegra: pll: save and restore pll context Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 07/18] clk: tegra: save and restore CPU and System clocks context Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 08/18] clk: tegra: support for saving and restoring OSC context Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 09/18] clk: tegra: add suspend resume support for DFLL Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 10/18] clk: tegra: add save and restore context support for peripheral clocks Sowjanya Komatineni
2019-06-26 10:12   ` Thierry Reding
2019-06-24  3:02 ` [PATCH V4 11/18] clk: tegra210: use fence_udelay during PLLU init Sowjanya Komatineni
2019-06-26 10:12   ` Thierry Reding
2019-06-24  3:02 ` [PATCH V4 12/18] clk: tegra210: support for Tegra210 clocks suspend and resume Sowjanya Komatineni
2019-06-26 10:16   ` Thierry Reding
2019-06-26 16:46     ` Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 13/18] soc/tegra: pmc: allow support for more tegra wake Sowjanya Komatineni
2019-06-24  8:15   ` Marc Zyngier
2019-06-24 16:21     ` Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 14/18] soc/tegra: pmc: add pmc wake support for tegra210 Sowjanya Komatineni
2019-06-26 10:26   ` Thierry Reding
2019-06-26 16:27     ` Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 15/18] arm64: tegra: enable wake from deep sleep on RTC alarm Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 16/18] soc/tegra: pmc: configure core power request polarity Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 17/18] soc/tegra: pmc: configure deep sleep control settings Sowjanya Komatineni
2019-06-24  3:02 ` [PATCH V4 18/18] arm64: dts: tegra210-p2180: Jetson TX1 SC7 timings Sowjanya Komatineni
2019-06-26 10:28   ` Thierry Reding
2019-06-26 16:28     ` Sowjanya Komatineni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1561345379-2429-2-git-send-email-skomatineni@nvidia.com \
    --to=skomatineni@nvidia.com \
    --cc=devicetree@vger.kernel.org \
    --cc=digetx@gmail.com \
    --cc=jason@lakedaemon.net \
    --cc=jckuo@nvidia.com \
    --cc=jonathanh@nvidia.com \
    --cc=josephl@nvidia.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=mperttunen@nvidia.com \
    --cc=pdeschrijver@nvidia.com \
    --cc=pgaikwad@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=spatra@nvidia.com \
    --cc=stefan@agner.ch \
    --cc=talho@nvidia.com \
    --cc=tglx@linutronix.de \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).