From: Robert Chiras <robert.chiras@nxp.com>
To: "sam@ravnborg.org" <sam@ravnborg.org>
Cc: dl-linux-imx <linux-imx@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"airlied@linux.ie" <airlied@linux.ie>
Subject: Re: [EXT] Re: [PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver
Date: Wed, 26 Jun 2019 12:13:23 +0000 [thread overview]
Message-ID: <1561551202.9328.93.camel@nxp.com> (raw)
In-Reply-To: <20190626113306.GA24921@ravnborg.org>
Hi Sam,
On Mi, 2019-06-26 at 13:33 +0200, Sam Ravnborg wrote:
> Hi Robert.
>
> On Wed, Jun 26, 2019 at 01:20:20PM +0300, Robert Chiras wrote:
> >
> > This patch adds Raydium RM67191 TFT LCD panel driver (MIPI-DSI
> > protocol).
> I was about to apply these - but I get following warnings during
> build:
> CC drivers/gpu/drm/panel/panel-raydium-rm67191.o
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c: In function ‘rad_bl_get_brightness’:
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c:470:17: warning: unused variable ‘dev’ [-Wunused-variable]
> struct device *dev = &dsi->dev;
> ^~~
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c: In function ‘rad_bl_update_status’:
> /home/sam/drm/linux.git/drivers/gpu/drm/panel/panel-raydium-
> rm67191.c:492:17: warning: unused variable ‘dev’ [-Wunused-variable]
> struct device *dev = &dsi->dev;
> ^~~
>
> Please fix and update your scripts to catch this in the future.
Oh, I am sorry about that, seems that I missed that :(
Fixed and submitted.
>
> Sam
Thanks,
Robert
prev parent reply other threads:[~2019-06-26 12:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-26 10:20 [PATCH v5 0/2] Add DSI panel driver for Raydium RM67191 Robert Chiras
2019-06-26 10:20 ` [PATCH v5 1/2] dt-bindings: display: panel: Add support for Raydium RM67191 panel Robert Chiras
2019-06-26 10:58 ` Fabio Estevam
2019-06-26 10:20 ` [PATCH v5 2/2] drm/panel: Add support for Raydium RM67191 panel driver Robert Chiras
2019-06-26 10:59 ` Fabio Estevam
2019-06-26 11:33 ` Sam Ravnborg
2019-06-26 12:13 ` Robert Chiras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1561551202.9328.93.camel@nxp.com \
--to=robert.chiras@nxp.com \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).