From: Krzysztof Kozlowski <krzk@kernel.org>
To: Xilin Wu <sophon@radxa.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Neil Armstrong <neil.armstrong@linaro.org>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Ram Kumar Dwivedi <quic_rdwivedi@quicinc.com>
Subject: Re: [PATCH RFC 2/2] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon Q6A
Date: Fri, 12 Sep 2025 10:15:47 +0200 [thread overview]
Message-ID: <156176d8-9b5c-49e4-9c17-c201255f50d4@kernel.org> (raw)
In-Reply-To: <20250912-radxa-dragon-q6a-v1-2-8ccdbf9cd19b@radxa.com>
On 12/09/2025 10:03, Xilin Wu wrote:
> Radxa Dragon Q6A is a single board computer, based on the Qualcomm
> QCS6490 platform.
>
> This is currently posted as RFC. More details are in the cover letter.
Please drop this sentence. If this is applied, then commit would be just
misleading.
>
> Signed-off-by: Xilin Wu <sophon@radxa.com>
> ---
...
> +&sound {
> + compatible = "qcom,qcs6490-rb3gen2-sndcard";
> + model = "QCS6490-Radxa-Dragon-Q6A";
> +
> + audio-routing =
> + "IN1_HPHL", "HPHL_OUT",
> + "IN2_HPHR", "HPHR_OUT",
> + "AMIC2", "MIC BIAS2",
> + "TX SWR_ADC1", "ADC2_OUTPUT";
> +
> + wcd-playback-dai-link {
> + link-name = "WCD Playback";
> +
> + cpu {
> + sound-dai = <&q6apmbedai RX_CODEC_DMA_RX_0>;
> + };
> +
> + codec {
If there is going to be new version, then codec before cpu (o < p, order
by name). But don't resend just for that.
> + sound-dai = <&wcd938x 0>, <&swr0 0>, <&lpass_rx_macro 0>;
> + };
> +
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-12 8:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 8:03 [PATCH RFC 0/2] arm64: dts: qcom: qcs6490: Introduce Radxa Dragon Q6A Xilin Wu
2025-09-12 8:03 ` [PATCH RFC 1/2] dt-bindings: arm: qcom: Add " Xilin Wu
2025-09-12 8:16 ` Krzysztof Kozlowski
2025-09-12 8:03 ` [PATCH RFC 2/2] arm64: dts: qcom: qcs6490: Introduce " Xilin Wu
2025-09-12 8:15 ` Krzysztof Kozlowski [this message]
2025-09-12 9:07 ` Konrad Dybcio
2025-09-12 8:12 ` [PATCH RFC 0/2] " Krzysztof Kozlowski
2025-09-12 8:25 ` Xilin Wu
2025-09-12 8:53 ` Krzysztof Kozlowski
2025-09-12 8:16 ` Krzysztof Kozlowski
2025-09-12 8:56 ` Konrad Dybcio
2025-09-12 9:04 ` Xilin Wu
2025-09-12 9:15 ` Konrad Dybcio
2026-04-07 10:16 ` Andriy Sharandakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=156176d8-9b5c-49e4-9c17-c201255f50d4@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_rdwivedi@quicinc.com \
--cc=robh@kernel.org \
--cc=sophon@radxa.com \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox