From mboxrd@z Thu Jan 1 00:00:00 1970 From: CK Hu Subject: Re: [RFC PATCH V2 1/4] dt-bindings: mt8183: Added FD dt-bindings Date: Fri, 12 Jul 2019 15:16:54 +0800 Message-ID: <1562915814.27825.2.camel@mtksdaap41> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-2-git-send-email-Jerry-Ch.chen@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1562661672-22439-2-git-send-email-Jerry-Ch.chen@mediatek.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Jerry-ch Chen Cc: devicetree@vger.kernel.org, Sean.Cheng@mediatek.com, laurent.pinchart+renesas@ideasonboard.com, Rynn.Wu@mediatek.com, christie.yu@mediatek.com, srv_heupstream@mediatek.com, po-yang.huang@mediatek.com, suleiman@chromium.org, sj.huang@mediatek.com, tfiga@chromium.org, jungo.lin@mediatek.com, shik@chromium.org, yuzhao@chromium.org, hans.verkuil@cisco.com, zwisler@chromium.org, frederic.chen@mediatek.com, matthias.bgg@gmail.com, linux-mediatek@lists.infradead.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi, Jerry: On Tue, 2019-07-09 at 16:41 +0800, Jerry-ch Chen wrote: > From: Jerry-ch Chen > > This patch adds DT binding documentation for the Face Detection (FD) > unit of the Mediatek's mt8183 SoC. > > Signed-off-by: Jerry-ch Chen > --- > .../bindings/media/mediatek,mt8183-fd.txt | 33 ++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > create mode 100644 Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > new file mode 100644 > index 0000000..0837223 > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/mediatek,mt8183-fd.txt > @@ -0,0 +1,33 @@ > +* Mediatek Face Detection Unit (FD) > + > +Face Detection (FD) unit is a typical memory-to-memory HW device. > +It provides hardware accelerated face detection function, and it > +is able to detect different poses of faces. FD will writre result > +of detected face into memory as output. > + > +Required properties: > +- compatible: "mediatek,mt8183-fd" > +- mediatek,scp : the node of system control processor (SCP), see > + Documentation/devicetree/bindings/remoteproc/mtk,scp.txt for details. > +- iommus: should point to the 3 entries: M4U_PORT_CAM_FDVT_RP, > + M4U_PORT_CAM_FDVT_WR and M4U_PORT_CAM_FDVT_RB. (Please see > + Documentation/devicetree/bindings/iommu/mediatek,iommu.txt for details.) > +- reg: Physical base address and length of the register space. > +- interrupts: interrupt number to the cpu. > +- clocks : must contain the FDVT clock, see > + Documentation/devicetree/bindings/clock/clock-bindings.txt for details. > +- clock-names: must be "fd". > + > +Example: > + fd: fd@1502b000 { > + compatible = "mediatek,mt8183-fd"; > + mediatek,scp = <&scp>; > + iommus = <&iommu M4U_PORT_CAM_FDVT_RP>, > + <&iommu M4U_PORT_CAM_FDVT_WR>, > + <&iommu M4U_PORT_CAM_FDVT_RB>; > + reg = <0 0x1502b000 0 0x1000>; > + interrupts = ; > + clocks = <&imgsys CLK_IMG_FDVT>; > + clock-names = "fd"; This device has no power-domain? Regards, CK > + }; > +