From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dongchun Zhu Subject: Re: [RFC,V2,1/2] media: dt-bindings: media: i2c: Add bindings for OV02A10 Date: Mon, 19 Aug 2019 13:39:30 +0800 Message-ID: <1566193170.21623.46.camel@mhfsdcap03> References: <20190704084651.3105-1-dongchun.zhu@mediatek.com> <20190704084651.3105-2-dongchun.zhu@mediatek.com> <20190723074153.GA4606@paasikivi.fi.intel.com> <1566013985.21623.9.camel@mhfsdcap03> <20190817213207.GC3504@valkosipuli.retiisi.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190817213207.GC3504@valkosipuli.retiisi.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Sakari Ailus Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, drinkcat@chromium.org, srv_heupstream@mediatek.com, tfiga@google.com, shengnan.wang@mediatek.com, louis.kuo@mediatek.com, sj.huang@mediatek.com, robh+dt@kernel.org, linux-mediatek@lists.infradead.org, matthias.bgg@gmail.com, bingbu.cao@intel.com, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: devicetree@vger.kernel.org Hi Sakari, On Sun, 2019-08-18 at 00:32 +0300, Sakari Ailus wrote: > Hi Dongchun, > > On Sat, Aug 17, 2019 at 11:53:05AM +0800, Dongchun Zhu wrote: > ... > > > > + > > > > +The device node shall contain one 'port' child node with an > > > > +'endpoint' subnode for its digital output video port, in accordance > > > > +with the video interface bindings defined in > > > > +Documentation/devicetree/bindings/media/video-interfaces.txt. > > > > +The endpoint optional property 'data-lanes' shall be "<1>". > > > > > > How many lanes does the module (or the sensor) have? > > > > > > > From sensor datasheet, OV02A10 supports 1-lane MIPI interface. > > If only one lane is supported, the property should be omitted: there's > nothing that the driver needs to know here. > Thanks for the suggestion. But sorry that I didn't read this message this morning, so this issue still remains unsettled in v3. https://patchwork.kernel.org/patch/11100219/ I would fix this point in v4.