From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ran Bi Subject: Re: [PATCH v2 2/4] rtc: Add support for the MediaTek MT2712 RTC Date: Thu, 22 Aug 2019 19:47:49 +0800 Message-ID: <1566474469.12318.7.camel@mhfsdcap03> References: <20190801110122.26834-1-ran.bi@mediatek.com> <20190801110122.26834-3-ran.bi@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Matthias Brugger Cc: Alexandre Belloni , Rob Herring , Alessandro Zummo , Mark Rutland , Mauro Carvalho Chehab , "David S . Miller" , Greg Kroah-Hartman , Jonathan Cameron , Linus Walleij , Nicolas Ferre , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com, YT Shen , Eddie Huang , Yingjoe Chen , Flor List-Id: devicetree@vger.kernel.org On Thu, 2019-08-22 at 11:12 +0200, Matthias Brugger wrote: > > On 01/08/2019 13:01, Ran Bi wrote: > > This add support for the MediaTek MT2712 RTC. It was SoC based RTC, but > > had different architecture compared with MT7622 RTC. > > > > Signed-off-by: Ran Bi > > --- > > drivers/rtc/Kconfig | 10 + > > drivers/rtc/Makefile | 1 + > > drivers/rtc/rtc-mt2712.c | 444 +++++++++++++++++++++++++++++++++++++++ > > Can't we just adjust rtc-mt7622.c (and rename it) to unify the source for both > devices. What is the difference that we need to write a driver of our own? > > Regards, > Matthias We cannot merge rtc-mt7622.c and rtc-mt2712.c together. These two rtc hardwares have totally different design. Registers naming, registers offset and operating method are different.