From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jerry-ch Chen Subject: Re: [RFC PATCH V2 4/4] platform: mtk-isp: Add Mediatek FD driver Date: Wed, 4 Sep 2019 21:19:03 +0800 Message-ID: <1567603143.22453.27.camel@mtksdccf07> References: <1562661672-22439-1-git-send-email-Jerry-Ch.chen@mediatek.com> <1562661672-22439-5-git-send-email-Jerry-Ch.chen@mediatek.com> <20190802082815.GA203993@chromium.org> <1566724680.20680.8.camel@mtksdccf07> <1566957625.20680.33.camel@mtksdccf07> <1567424859.18318.32.camel@mtksdccf07> <1567493081.18318.49.camel@mtksdccf07> <1567511169.18318.65.camel@mtksdccf07> <1567568281.18318.80.camel@mtksdccf07> <1567577389.18318.100.camel@mtksdccf07> <1567584577.22453.11.camel@mtksdccf07> <1567587708.22453.15.camel@mtksdccf07> <1567589188.22453.24.camel@mtksdccf07> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+glpam-linux-mediatek=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org To: Tomasz Figa Cc: "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Sean Cheng =?UTF-8?Q?=28=E9=84=AD=E6=98=87=E5=BC=98=29?= , "laurent.pinchart+renesas-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org" , Rynn Wu =?UTF-8?Q?=28=E5=90=B3=E8=82=B2=E6=81=A9=29?= , srv_heupstream , Po-Yang Huang =?UTF-8?Q?=28=E9=BB=83=E6=9F=8F=E9=99=BD=29?= , "mchehab-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "suleiman-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , "shik-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , Jungo Lin =?UTF-8?Q?=28=E6=9E=97=E6=98=8E=E4=BF=8A=29?= , Sj Huang =?UTF-8?Q?=28=E9=BB=83=E4=BF=A1=E7=92=8B=29?= , "yuzhao-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org" , "linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , zwisler-F7+t8E8rja8pug/h7KTFAQ@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, 2019-09-04 at 21:12 +0800, Tomasz Figa wrote: > On Wed, Sep 4, 2019 at 6:26 PM Jerry-ch Chen wrote: > > > > Hi Tomasz, > > > > On Wed, 2019-09-04 at 17:03 +0800, Tomasz Figa wrote: > > > On Wed, Sep 4, 2019 at 6:02 PM Jerry-ch Chen wrote: > > > > > > > > Hi Tomasz, > > > > > > > > On Wed, 2019-09-04 at 16:25 +0800, Tomasz Figa wrote: > > > > > On Wed, Sep 4, 2019 at 5:09 PM Jerry-ch Chen wrote: > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > On Wed, 2019-09-04 at 14:34 +0800, Tomasz Figa wrote: > > > > > > > On Wed, Sep 4, 2019 at 3:09 PM Jerry-ch Chen wrote: > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > On Wed, 2019-09-04 at 12:15 +0800, Tomasz Figa wrote: > > > > > > > > > On Wed, Sep 4, 2019 at 12:38 PM Jerry-ch Chen > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > > > On Tue, 2019-09-03 at 20:05 +0800, Tomasz Figa wrote: > > > > > > > > > > > On Tue, Sep 3, 2019 at 8:46 PM Jerry-ch Chen wrote: > > > > > > > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > > > > > > > On Tue, 2019-09-03 at 15:04 +0800, Tomasz Figa wrote: > > > > > > > > > > > > > On Tue, Sep 3, 2019 at 3:44 PM Jerry-ch Chen wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, 2019-09-03 at 13:19 +0800, Tomasz Figa wrote: > > > > > > > > > > > > > > > On Mon, Sep 2, 2019 at 8:47 PM Jerry-ch Chen wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2019-08-30 at 16:33 +0800, Tomasz Figa wrote: > > > > > > > > > > > > > > > > > On Wed, Aug 28, 2019 at 11:00 AM Jerry-ch Chen > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Mon, 2019-08-26 at 14:36 +0800, Tomasz Figa wrote: > > > > > > > > > > > > > > > > > > > Hi Jerry, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Sun, Aug 25, 2019 at 6:18 PM Jerry-ch Chen > > > > > > > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > Hi Tomasz, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Fri, 2019-08-02 at 16:28 +0800, Tomasz Figa wrote: > > > > > > > > > > > > > > > > > > > > > Hi Jerry, > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Tue, Jul 09, 2019 at 04:41:12PM +0800, Jerry-ch Chen wrote: > > [snip] > > > > > > static void mtk_fd_vb2_stop_streaming(struct vb2_queue *vq) > > > > > > { > > > > > > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq); > > > > > > struct mtk_fd_dev *fd = ctx->fd_dev; > > > > > > struct vb2_v4l2_buffer *vb; > > > > > > struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx; > > > > > > struct v4l2_m2m_queue_ctx *queue_ctx; > > > > > > u32 ret; > > > > > > > > > > > > if (!fd->fd_irq_done.done) > > > > > > > > > > We shouldn't access internal fields of completion. > > > > > > > > > > > ret = wait_for_completion_timeout(&fd->fd_irq_done, > > > > > > msecs_to_jiffies( > > > > > > MTK_FD_HW_TIMEOUT)); > > > > > > queue_ctx = V4L2_TYPE_IS_OUTPUT(vq->type) ? > > > > > > &m2m_ctx->out_q_ctx : > > > > > > &m2m_ctx->cap_q_ctx; > > > > > > while ((vb = v4l2_m2m_buf_remove(queue_ctx))) > > > > > > v4l2_m2m_buf_done(vb, VB2_BUF_STATE_ERROR); > > > > > > > > > > > > if (vq->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) > > > > > > mtk_fd_hw_disconnect(fd); > > > > > > } > > > > > > > > > > > > I've also tried to wait completion unconditionally for both queues and > > > > > > the second time will wait until timeout, as a result, it takes longer to > > > > > > swap the camera every time and close the camera app. > > > > > > > > > > I think it should work better if we call complete_all() instead of complete(). > > > > > > > > > Thanks, > > > > > > > > I use complete_all(), and it works fine now. > > > > > > > > static void mtk_fd_vb2_stop_streaming(struct vb2_queue *vq) > > > > { > > > > struct mtk_fd_ctx *ctx = vb2_get_drv_priv(vq); > > > > struct mtk_fd_dev *fd = ctx->fd_dev; > > > > struct vb2_v4l2_buffer *vb; > > > > struct v4l2_m2m_ctx *m2m_ctx = ctx->fh.m2m_ctx; > > > > struct v4l2_m2m_queue_ctx *queue_ctx; > > > > > > > > wait_for_completion_timeout(&fd->fd_irq_done, > > > > msecs_to_jiffies(MTK_FD_HW_TIMEOUT)); > > > > > > Shouldn't we still send some command to the hardware to stop? Like a > > > reset. Otherwise we don't know if it isn't still accessing the memory. > > > > > I thought no more jobs will be enqueued here when stop_streaming so we > > don't need it. > > That's true for the case when the wait completed successfully, but we > also need to ensure the hardware is stopped even if a timeout happens. > > > We still could send an ipi command to reset the HW, and wait for it's > > callback or we could set the register MTK_FD_REG_OFFSET_HW_ENABLE to > > zero to disable the HW. > > Since it's for handling a timeout, a reset should be more likely to > bring the hardware back to a reasonable state. > Ok, I will send the ipi command to reset the HW. Thanks and best regards, Jerry > > > > Best regards, > > Jerry > > > > > > queue_ctx = V4L2_TYPE_IS_OUTPUT(vq->type) ? > > > > &m2m_ctx->out_q_ctx : > > > > &m2m_ctx->cap_q_ctx; > > > > while ((vb = v4l2_m2m_buf_remove(queue_ctx))) > > > > v4l2_m2m_buf_done(vb, VB2_BUF_STATE_ERROR); > > > > > > > > if (vq->type == V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) > > > > mtk_fd_hw_disconnect(fd); > > > > } > > > > > > > > Best regards, > > > > Jerry > > > > > > > > > Best regards, > > > > > Tomasz > > > > > > > > > > > >