From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: maxime.ripard@bootlin.com
Cc: Yong Deng <yong.deng@magewell.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Chen-Yu Tsai <wens@csie.org>,
"\"David S. Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Hans Verkuil <hans.verkuil@cisco.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Jacob Chen <jacob-chen@iotwrt.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Thierry Reding <treding@nvidia.com>,
Philipp Zabel <p.zabel@pengutronix.de>,
Todor Tomov <todor.tomov@linaro.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infra
Subject: Re: [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI)
Date: Wed, 26 Sep 2018 13:38:08 +0300 [thread overview]
Message-ID: <1568838.d8CnAYTeDB@avalon> (raw)
In-Reply-To: <20180926103547.5ubb6xjkl7xngmfg@flea>
Hi Maxime,
On Wednesday, 26 September 2018 13:35:47 EEST maxime.ripard@bootlin.com wrote:
> On Wed, Sep 26, 2018 at 01:19:34PM +0300, Laurent Pinchart wrote:
> > > +Endpoint node properties for CSI1
> > > +---------------------------------
> >
> > Should you list the CSI0 properties as well ? As the driver in patch 2/2
> > doesn't support the CSI-2 interface I assume you have left out CSI0 for
> > now, but it should still be listed in the bindings. I'm fine with fixing
> > this as a follow-up patch to avoid missing the v4.20 merge window, but if
> > you end up resubmitting the series, could you please address the problem
> > ?
>
> That driver is not available, and the documentation isn't either, so
> there's no easy way to tell which properties are going to be needed
> before doing the actual work of reverse engineering it and writing a
> driver for it. Unfortunately...
While DT bindings should be independent from driver implementations, I agree
it's difficult to develop good bindings without hardware documentation and
without at least one working driver implementation.
How about just explicitly stating that these bindings don't support CSI0 yet ?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-09-26 10:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-26 8:40 [PATCH v11 1/2] dt-bindings: media: Add Allwinner V3s Camera Sensor Interface (CSI) Yong Deng
2018-09-26 10:19 ` Laurent Pinchart
2018-09-26 10:35 ` maxime.ripard-LDxbnhwyfcJBDgjK7y7TUQ
2018-09-26 10:38 ` Laurent Pinchart [this message]
2018-09-26 10:40 ` Maxime Ripard
2018-09-27 0:59 ` Yong
2018-09-28 9:38 ` Sakari Ailus
2018-09-28 9:45 ` Laurent Pinchart
2018-09-28 10:23 ` Sakari Ailus
[not found] ` <20180928102345.r2g342tg5mgcwfw6-z7MJbOB4PBP+e+fPlCVrcFDQ4js95KgL@public.gmane.org>
2018-09-28 11:10 ` Chen-Yu Tsai
2018-09-28 12:56 ` Sakari Ailus
[not found] ` <20180928125601.6ye5tvrmh57amvh5-z7MJbOB4PBP+e+fPlCVrcFDQ4js95KgL@public.gmane.org>
2018-09-28 13:36 ` Maxime Ripard
2018-09-28 13:42 ` Sakari Ailus
2018-09-28 13:42 ` Chen-Yu Tsai
2018-09-28 14:47 ` Sakari Ailus
2018-10-17 7:33 ` [linux-sunxi] " Jagan Teki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1568838.d8CnAYTeDB@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=hans.verkuil@cisco.com \
--cc=jacob-chen@iotwrt.com \
--cc=linux-arm-kernel@lists.infra \
--cc=linux-media@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=narmstrong@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=todor.tomov@linaro.org \
--cc=treding@nvidia.com \
--cc=wens@csie.org \
--cc=yong.deng@magewell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).