From: Sam Shih <sam.shih@mediatek.com>
To: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>,
John Crispin <john@phrozen.org>,
linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
Sam Shih <sam.shih@mediatek.com>
Subject: [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms"
Date: Wed, 25 Sep 2019 22:32:32 +0800 [thread overview]
Message-ID: <1569421957-20765-8-git-send-email-sam.shih@mediatek.com> (raw)
In-Reply-To: <1569421957-20765-1-git-send-email-sam.shih@mediatek.com>
From: Ryder Lee <ryder.lee@mediatek.com>
This adds a property "num-pwms" in example so that we could
specify the number of PWM channels via device tree.
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Sam Shih <sam.shih@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
Changes since v10:
1. Follow reviewers's comments:
- derive the number of PWMs from the specific compatible string
2. Add mt7629 pwm description
3. Add mt7628 fixed-clock description
Changes since v6:
Follow reviewers's comments:
- The subject should indicate this is for Mediatek
Changes since v5:
- Add an Acked-by tag
- This file is original v4 patch 5/10
(https://patchwork.kernel.org/patch/11102577/)
---
Documentation/devicetree/bindings/pwm/pwm-mediatek.txt | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
index 991728cb46cb..975d7871830d 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
+++ b/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt
@@ -9,17 +9,20 @@ Required properties:
- reg: physical base address and length of the controller's registers.
- #pwm-cells: must be 2. See pwm.txt in this directory for a description of
the cell format.
- - clocks: phandle and clock specifier of the PWM reference clock.
- - clock-names: must contain the following, except for MT7628 which
- has no clocks
+ - clocks: One phandle and clock specifier for each entry in the "clock-names"
+ property, Use fixed-clock as dummy clocks for mt7628
+ - clock-names: must contain the following
- "top": the top clock generator
- "main": clock used by the PWM core
- "pwm1-8": the eight per PWM clocks for mt2712
- "pwm1-6": the six per PWM clocks for mt7622
- "pwm1-5": the five per PWM clocks for mt7623
+ - "pwm1-4": the four per PWM clocks for mt7628
+ - "pwm1": the PWM1 clock for mt7629
- pinctrl-names: Must contain a "default" entry.
- pinctrl-0: One property must exist for each entry in pinctrl-names.
See pinctrl/pinctrl-bindings.txt for details of the property values.
+ - num-pwms: the number of PWM channels.
Example:
pwm0: pwm@11006000 {
@@ -37,4 +40,5 @@ Example:
"pwm3", "pwm4", "pwm5";
pinctrl-names = "default";
pinctrl-0 = <&pwm0_pins>;
+ num-pwms = <5>;
};
--
2.17.1
next prev parent reply other threads:[~2019-09-25 14:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-25 14:32 [PATCH v10 0/12] Add mt7629 and fix mt7628 pwm Sam Shih
2019-09-25 14:32 ` [PATCH v10 01/12] pwm: mediatek: add a property "num-pwms" Sam Shih
2019-09-25 14:32 ` [PATCH v10 02/12] pwm: mediatek: droping the check for of_device_get_match_data Sam Shih
2019-09-25 14:32 ` [PATCH v10 03/12] pwm: mediatek: remove a property "has-clks" Sam Shih
2019-09-25 14:32 ` [PATCH v10 04/12] pwm: mediatek: allocate the clks array dynamically Sam Shih
2019-09-25 14:32 ` [PATCH v10 05/12] pwm: mediatek: use pwm_mediatek as common prefix Sam Shih
2019-09-25 14:32 ` [PATCH v10 06/12] pwm: mediatek: update license and switch to SPDX tag Sam Shih
2019-09-25 14:32 ` Sam Shih [this message]
2019-09-25 22:50 ` [PATCH v10 07/12] dt-bindings: pwm: pwm-mediatek: add a property "num-pwms" Thierry Reding
2019-09-25 14:32 ` [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string Sam Shih
[not found] ` <1569421957-20765-9-git-send-email-sam.shih-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2019-09-27 11:28 ` Thierry Reding
2019-09-30 8:51 ` Sam Shih
2019-09-30 9:36 ` Thierry Reding
2019-09-30 9:51 ` Sam Shih
2019-09-25 14:32 ` [PATCH v10 09/12] arm64: dts: mt7622: add a property "num-pwms" for PWM Sam Shih
2019-09-25 14:32 ` [PATCH v10 10/12] arm: dts: mt7623: " Sam Shih
2019-09-25 14:32 ` [PATCH v10 11/12] dt-bindings: pwm: update bindings for MT7629 SoC Sam Shih
2019-09-25 14:32 ` [PATCH v10 12/12] arm: dts: mediatek: add mt7629 pwm support Sam Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1569421957-20765-8-git-send-email-sam.shih@mediatek.com \
--to=sam.shih@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=john@phrozen.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=ryder.lee@mediatek.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).