From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sam Shih Subject: Re: [PATCH v10 08/12] pwm: mediatek: Add MT7629 compatible string Date: Mon, 30 Sep 2019 16:51:08 +0800 Message-ID: <1569833468.32131.4.camel@mtksdccf07> References: <1569421957-20765-1-git-send-email-sam.shih@mediatek.com> <1569421957-20765-9-git-send-email-sam.shih@mediatek.com> <20190927112831.GA1171568@ulmo> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190927112831.GA1171568@ulmo> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Rob Herring , Mark Rutland , Matthias Brugger , Ryder Lee , John Crispin , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org List-Id: devicetree@vger.kernel.org Hi, On Fri, 2019-09-27 at 13:28 +0200, Thierry Reding wrote: > On Wed, Sep 25, 2019 at 10:32:33PM +0800, Sam Shih wrote: > > This adds pwm support for MT7629, and separate mt7629 compatible string > > from mt7622 > > > > Signed-off-by: Sam Shih > > --- > > drivers/pwm/pwm-mediatek.c | 6 ++++++ > > 1 file changed, 6 insertions(+) > > I picked this patch up and made some minor adjustments to make it build > without the num_pwms patches. With that I don't think there's anything > left from this series that you need. Yes, I think the driver should work once dtsi updated. ("[v10,12/12] arm: dts: mediatek: add mt7629 pwm support") But, due to we use comaptible string separately for every SoC now, The comaptible string in dt-bindings should be "mediatek,mt7629-pwm". I think we should use "[v10,11/12] dt-bindings: pwm: update bindings for MT7629" to replace commit 1c00ad6ebf36aa3b0fa598a48b8ae59782be4121, Or maybe we need a little modification like this ? diff --git a/Documentation/devicetree/bindings/pwm/pwm-mediatek.txt ... - - "mediatek,mt7629-pwm", "mediatek,mt7622-pwm": found on mt7629 SoC. + - "mediatek,mt7629-pwm": found on mt7629 SoC. Thanks, Regards, Sam