devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2 0/4] add meson secure watchdog driver
@ 2019-10-18  8:33 Xingyu Chen
  2019-10-18  8:33 ` [PATCH v2 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
  2019-10-18  8:33 ` [PATCH v2 4/4] arm64: dts: a1: add secure watchdog controller Xingyu Chen
  0 siblings, 2 replies; 3+ messages in thread
From: Xingyu Chen @ 2019-10-18  8:33 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong
  Cc: Xingyu Chen, Rob Herring, Jerome Brunet, Qianggui Song,
	Jianxin Pan, Jian Hu, linux-watchdog, linux-amlogic,
	linux-arm-kernel, linux-kernel, devicetree

The watchdog controller on the Meson-A/C series SoCs is moved to secure world,
We have to call SMC instruction to trap the ATF for watchdog operation. These
operations are different from previous SoCs, so we introduce a new watchdog
driver to support this kind of SoCs.

Changes since v1 at [0]:
- add a new dependency in Kconfig
- simplify/add the return operation
- remove useless ping operation when setting the timeout
- fix some return values
- fix the license statement

[0]:https://lore.kernel.org/linux-amlogic/1570874721-36077-1-git-send-email-xingyu.chen@amlogic.com

Xingyu Chen (4):
  firmware: meson_sm: add new SMC ID support for accessing secure
    watchdog
  dt-bindings: watchdog: add new binding for meson secure watchdog
  watchdog: add meson secure watchdog driver
  arm64: dts: a1: add secure watchdog controller

 .../bindings/watchdog/amlogic,meson-sec-wdt.yaml   |  34 ++++
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi          |   6 +
 drivers/firmware/meson/meson_sm.c                  |   1 +
 drivers/watchdog/Kconfig                           |  17 ++
 drivers/watchdog/Makefile                          |   1 +
 drivers/watchdog/meson_sec_wdt.c                   | 187 +++++++++++++++++++++
 include/linux/firmware/meson/meson_sm.h            |   1 +
 7 files changed, 247 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
 create mode 100644 drivers/watchdog/meson_sec_wdt.c

-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH v2 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog
  2019-10-18  8:33 [PATCH v2 0/4] add meson secure watchdog driver Xingyu Chen
@ 2019-10-18  8:33 ` Xingyu Chen
  2019-10-18  8:33 ` [PATCH v2 4/4] arm64: dts: a1: add secure watchdog controller Xingyu Chen
  1 sibling, 0 replies; 3+ messages in thread
From: Xingyu Chen @ 2019-10-18  8:33 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong
  Cc: Xingyu Chen, Rob Herring, Jerome Brunet, Qianggui Song,
	Jianxin Pan, Jian Hu, linux-watchdog, linux-amlogic,
	linux-arm-kernel, linux-kernel, devicetree

The binding targets the Meson-A/C series compatible SoCs, in which the
watchdog registers are in secure world.

Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
---
 .../bindings/watchdog/amlogic,meson-sec-wdt.yaml   | 34 ++++++++++++++++++++++
 1 file changed, 34 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
new file mode 100644
index 00000000..0bbc807
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/amlogic,meson-sec-wdt.yaml
@@ -0,0 +1,34 @@
+# SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+# Copyright (c) 2019 Amlogic, Inc
+%YAML 1.2
+---
+$id: "http://devicetree.org/schemas/power/amlogic,meson-sec-wdt.yaml#"
+$schema: "http://devicetree.org/meta-schemas/core.yaml#"
+
+title: Amlogic Meson Secure Watchdog Timer
+
+maintainers:
+  - Xingyu Chen <xingyu.chen@amlogic.com>
+
+description: |+
+  Secure Watchdog Timer used in Meson-A/C series Compatible SoCs
+
+properties:
+  compatible:
+    enum:
+      - amlogic,meson-sec-wdt
+
+  secure-monitor:
+    description: phandle to the secure-monitor node
+    $ref: /schemas/types.yaml#/definitions/phandle
+
+required:
+  - compatible
+  - secure-monitor
+
+examples:
+  - |
+    watchdog {
+          compatible = "amlogic,meson-sec-wdt";
+          secure-monitor = <&sm>;
+    };
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH v2 4/4] arm64: dts: a1: add secure watchdog controller
  2019-10-18  8:33 [PATCH v2 0/4] add meson secure watchdog driver Xingyu Chen
  2019-10-18  8:33 ` [PATCH v2 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
@ 2019-10-18  8:33 ` Xingyu Chen
  1 sibling, 0 replies; 3+ messages in thread
From: Xingyu Chen @ 2019-10-18  8:33 UTC (permalink / raw)
  To: Wim Van Sebroeck, Guenter Roeck, Kevin Hilman, Neil Armstrong
  Cc: Xingyu Chen, Rob Herring, Jerome Brunet, Qianggui Song,
	Jianxin Pan, Jian Hu, linux-watchdog, linux-amlogic,
	linux-arm-kernel, linux-kernel, devicetree

Enable secure watchdog controller for Meson-A1 SoC

Signed-off-by: Xingyu Chen <xingyu.chen@amlogic.com>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index 7210ad0..047c323 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -93,6 +93,12 @@
 				clock-names = "xtal", "pclk", "baud";
 				status = "disabled";
 			};
+
+			watchdog {
+				compatible = "amlogic,meson-sec-wdt";
+				secure-monitor = <&sm>;
+				status = "okay";
+			};
 		};
 
 		gic: interrupt-controller@ff901000 {
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-10-18  8:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-18  8:33 [PATCH v2 0/4] add meson secure watchdog driver Xingyu Chen
2019-10-18  8:33 ` [PATCH v2 2/4] dt-bindings: watchdog: add new binding for meson secure watchdog Xingyu Chen
2019-10-18  8:33 ` [PATCH v2 4/4] arm64: dts: a1: add secure watchdog controller Xingyu Chen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).