* Re: [RESEND PATCH v2 2/3] dt-bindings: iio: light: add veml6030 ALS bindings [not found] ` <b9d5cb134c7c2c7351025a0b556148bca23f302f.1569321085.git.gupt21@gmail.com> @ 2019-10-05 14:14 ` Jonathan Cameron 2019-10-21 13:31 ` [PATCH v3 " Rishi Gupta 0 siblings, 1 reply; 4+ messages in thread From: Jonathan Cameron @ 2019-10-05 14:14 UTC (permalink / raw) To: Rishi Gupta Cc: knaack.h, lars, pmeerw, gregkh, tglx, allison, alexios.zavras, angus, linux-iio, linux-kernel, hslester96, wsa+renesas, Rob Herring, Mark Rutland, devicetree On Tue, 24 Sep 2019 16:21:57 +0530 Rishi Gupta <gupt21@gmail.com> wrote: > This commit adds device tree bindings for veml6030 ambient > light sensor. > > Signed-off-by: Rishi Gupta <gupt21@gmail.com> looks fine to me, but... DT bindings should always be sent to the DT-bindings maintainers and mailing list for review. +CC Rob, Mark and devicetree list. Jonathan > --- > Changes in v2: > * Corrected grammatical mistake from 'is' to 'are' in description of bindings > > .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > new file mode 100644 > index 0000000..969b314 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0+ > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: VEML6030 Ambient Light Sensor (ALS) > + > +maintainers: > + - Rishi Gupta <gupt21@gmail.com> > + > +description: | > + Bindings for the ambient light sensor veml6030 from Vishay > + Semiconductors over an i2c interface. > + > + Irrespective of whether interrupt is used or not, application > + can get the ALS and White channel reading from IIO raw interface. > + > + If the interrupts are used, application will receive an IIO event > + whenever configured threshold is crossed. > + > + Specifications about the sensor can be found at: > + https://www.vishay.com/docs/84366/veml6030.pdf > + > +properties: > + compatible: > + enum: > + - vishay,veml6030 > + > + reg: > + description: > + I2C address of the device. If the ADDR pin on veml6030 > + is pulled up, this address is 0x48. If the ADDR pin is > + pulled down, this address is 0x10. > + maxItems: 1 > + > + interrupts: > + description: > + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW. > + Refer to interrupt-controller/interrupts.txt for generic > + interrupt client node bindings. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@10 { > + compatible = "vishay,veml6030"; > + reg = <0x10>; > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 2/3] dt-bindings: iio: light: add veml6030 ALS bindings 2019-10-05 14:14 ` [RESEND PATCH v2 2/3] dt-bindings: iio: light: add veml6030 ALS bindings Jonathan Cameron @ 2019-10-21 13:31 ` Rishi Gupta 2019-10-21 17:28 ` Rob Herring 0 siblings, 1 reply; 4+ messages in thread From: Rishi Gupta @ 2019-10-21 13:31 UTC (permalink / raw) To: jic23 Cc: knaack.h, lars, pmeerw, gregkh, tglx, allison, alexios.zavras, angus, linux-iio, linux-kernel, robh+dt, mark.rutland, devicetree, Rishi Gupta This commit adds device tree bindings for veml6030 ambient light sensor. Signed-off-by: Rishi Gupta <gupt21@gmail.com> --- Changes in v3: * None Changes in v2: * Corrected grammatical mistake from 'is' to 'are' in description of bindings .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml new file mode 100644 index 0000000..969b314 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0+ +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: VEML6030 Ambient Light Sensor (ALS) + +maintainers: + - Rishi Gupta <gupt21@gmail.com> + +description: | + Bindings for the ambient light sensor veml6030 from Vishay + Semiconductors over an i2c interface. + + Irrespective of whether interrupt is used or not, application + can get the ALS and White channel reading from IIO raw interface. + + If the interrupts are used, application will receive an IIO event + whenever configured threshold is crossed. + + Specifications about the sensor can be found at: + https://www.vishay.com/docs/84366/veml6030.pdf + +properties: + compatible: + enum: + - vishay,veml6030 + + reg: + description: + I2C address of the device. If the ADDR pin on veml6030 + is pulled up, this address is 0x48. If the ADDR pin is + pulled down, this address is 0x10. + maxItems: 1 + + interrupts: + description: + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW. + Refer to interrupt-controller/interrupts.txt for generic + interrupt client node bindings. + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@10 { + compatible = "vishay,veml6030"; + reg = <0x10>; + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; + }; + }; +... -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 2/3] dt-bindings: iio: light: add veml6030 ALS bindings 2019-10-21 13:31 ` [PATCH v3 " Rishi Gupta @ 2019-10-21 17:28 ` Rob Herring 2019-10-22 3:57 ` [PATCH v4 " Rishi Gupta 0 siblings, 1 reply; 4+ messages in thread From: Rob Herring @ 2019-10-21 17:28 UTC (permalink / raw) To: Rishi Gupta Cc: Jonathan Cameron, Hartmut Knaack, Lars-Peter Clausen, Peter Meerwald, Greg Kroah-Hartman, Thomas Gleixner, Allison Randal, alexios.zavras, Angus Ainslie (Purism), open list:IIO SUBSYSTEM AND DRIVERS, linux-kernel@vger.kernel.org, Mark Rutland, devicetree On Mon, Oct 21, 2019 at 8:31 AM Rishi Gupta <gupt21@gmail.com> wrote: > > This commit adds device tree bindings for veml6030 ambient > light sensor. > > Signed-off-by: Rishi Gupta <gupt21@gmail.com> > --- > Changes in v3: > * None > > Changes in v2: > * Corrected grammatical mistake from 'is' to 'are' in description of bindings > > .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++ > 1 file changed, 62 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml > > diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > new file mode 100644 > index 0000000..969b314 > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml > @@ -0,0 +1,62 @@ > +# SPDX-License-Identifier: GPL-2.0+ (GPL-2.0-only OR BSD-2-Clause) for new bindings please. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: VEML6030 Ambient Light Sensor (ALS) > + > +maintainers: > + - Rishi Gupta <gupt21@gmail.com> > + > +description: | > + Bindings for the ambient light sensor veml6030 from Vishay > + Semiconductors over an i2c interface. > + > + Irrespective of whether interrupt is used or not, application > + can get the ALS and White channel reading from IIO raw interface. > + > + If the interrupts are used, application will receive an IIO event > + whenever configured threshold is crossed. > + > + Specifications about the sensor can be found at: > + https://www.vishay.com/docs/84366/veml6030.pdf > + > +properties: > + compatible: > + enum: > + - vishay,veml6030 > + > + reg: > + description: > + I2C address of the device. If the ADDR pin on veml6030 > + is pulled up, this address is 0x48. If the ADDR pin is > + pulled down, this address is 0x10. If you want to define the addresses, then you do: enum: - 0x10 # ADDR pin pulled down - 0x48 # ADDR pin pulled up > + maxItems: 1 And drop this. > + > + interrupts: > + description: > + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW. > + Refer to interrupt-controller/interrupts.txt for generic > + interrupt client node bindings. > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + light-sensor@10 { > + compatible = "vishay,veml6030"; > + reg = <0x10>; > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > + }; > + }; > +... > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v4 2/3] dt-bindings: iio: light: add veml6030 ALS bindings 2019-10-21 17:28 ` Rob Herring @ 2019-10-22 3:57 ` Rishi Gupta 0 siblings, 0 replies; 4+ messages in thread From: Rishi Gupta @ 2019-10-22 3:57 UTC (permalink / raw) To: jic23 Cc: knaack.h, lars, pmeerw, gregkh, tglx, allison, alexios.zavras, angus, linux-iio, linux-kernel, robh+dt, mark.rutland, devicetree, Rishi Gupta This commit adds device tree bindings for veml6030 ambient light sensor. Signed-off-by: Rishi Gupta <gupt21@gmail.com> --- Changes in v4: * Added enum in reg property * Removed maxItems from reg property Changes in v3: * None Changes in v2: * Corrected grammatical mistake from 'is' to 'are' in description of bindings .../devicetree/bindings/iio/light/veml6030.yaml | 62 ++++++++++++++++++++++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/light/veml6030.yaml diff --git a/Documentation/devicetree/bindings/iio/light/veml6030.yaml b/Documentation/devicetree/bindings/iio/light/veml6030.yaml new file mode 100644 index 0000000..0ff9b11 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/light/veml6030.yaml @@ -0,0 +1,62 @@ +# SPDX-License-Identifier: GPL-2.0+ +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/light/veml6030.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: VEML6030 Ambient Light Sensor (ALS) + +maintainers: + - Rishi Gupta <gupt21@gmail.com> + +description: | + Bindings for the ambient light sensor veml6030 from Vishay + Semiconductors over an i2c interface. + + Irrespective of whether interrupt is used or not, application + can get the ALS and White channel reading from IIO raw interface. + + If the interrupts are used, application will receive an IIO event + whenever configured threshold is crossed. + + Specifications about the sensor can be found at: + https://www.vishay.com/docs/84366/veml6030.pdf + +properties: + compatible: + enum: + - vishay,veml6030 + + reg: + description: + I2C address of the device. + enum: + - 0x10 # ADDR pin pulled down + - 0x48 # ADDR pin pulled up + + interrupts: + description: + interrupt mapping for IRQ. Configure with IRQ_TYPE_LEVEL_LOW. + Refer to interrupt-controller/interrupts.txt for generic + interrupt client node bindings. + maxItems: 1 + +required: + - compatible + - reg + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + + i2c { + #address-cells = <1>; + #size-cells = <0>; + + light-sensor@10 { + compatible = "vishay,veml6030"; + reg = <0x10>; + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; + }; + }; +... -- 2.7.4 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-22 3:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1569321085.git.gupt21@gmail.com>
[not found] ` <b9d5cb134c7c2c7351025a0b556148bca23f302f.1569321085.git.gupt21@gmail.com>
2019-10-05 14:14 ` [RESEND PATCH v2 2/3] dt-bindings: iio: light: add veml6030 ALS bindings Jonathan Cameron
2019-10-21 13:31 ` [PATCH v3 " Rishi Gupta
2019-10-21 17:28 ` Rob Herring
2019-10-22 3:57 ` [PATCH v4 " Rishi Gupta
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).