* [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface @ 2019-10-28 7:29 Eason Yen 2019-10-28 7:29 ` Eason Yen 0 siblings, 1 reply; 4+ messages in thread From: Eason Yen @ 2019-10-28 7:29 UTC (permalink / raw) To: Matthias Brugger Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream, Eason Yen This patch add SMC fid table for SIP interface. 1. Add a header file to provide SIP interface to ATF 2. Add AUDIO SMC fid Signed-off-by: Eason Yen <eason.yen@mediatek.com> Eason Yen (1): soc: mediatek: add SMC fid table for SIP interface include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface 2019-10-28 7:29 [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface Eason Yen @ 2019-10-28 7:29 ` Eason Yen 2019-11-10 20:18 ` Matthias Brugger 0 siblings, 1 reply; 4+ messages in thread From: Eason Yen @ 2019-10-28 7:29 UTC (permalink / raw) To: Matthias Brugger Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream, Eason Yen 1. Add a header file to provide SIP interface to ATF 2. Add AUDIO SMC fid Change-Id: I218e9f571cea079268a5414725a81e9b35702e33 Signed-off-by: Eason Yen <eason.yen@mediatek.com> --- include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ 1 file changed, 28 insertions(+) create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h new file mode 100644 index 0000000..00ee0f4 --- /dev/null +++ b/include/linux/soc/mediatek/mtk_sip_svc.h @@ -0,0 +1,28 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +/* + * Copyright (c) 2019 MediaTek Inc. + */ + +#ifndef __MTK_SIP_SVC_H__ +#define __MTK_SIP_SVC_H__ + +#include <linux/kernel.h> + +/* Error Code */ +#define SIP_SVC_E_SUCCESS 0 +#define SIP_SVC_E_NOT_SUPPORTED -1 +#define SIP_SVC_E_INVALID_PARAMS -2 +#define SIP_SVC_E_INVALID_Range -3 +#define SIP_SVC_E_PERMISSION_DENY -4 + +#ifdef CONFIG_ARM64 +#define MTK_SIP_SMC_AARCH_BIT 0x40000000 +#else +#define MTK_SIP_SMC_AARCH_BIT 0x00000000 +#endif + +/* AUDIO related SMC call */ +#define MTK_SIP_AUDIO_CONTROL \ + (0x82000517 | MTK_SIP_SMC_AARCH_BIT) +#endif +/* __MTK_SIP_SVC_H__ */ -- 1.7.9.5 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface 2019-10-28 7:29 ` Eason Yen @ 2019-11-10 20:18 ` Matthias Brugger 2019-11-11 1:38 ` Eason Yen 0 siblings, 1 reply; 4+ messages in thread From: Matthias Brugger @ 2019-11-10 20:18 UTC (permalink / raw) To: Eason Yen; +Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream On 28/10/2019 08:29, Eason Yen wrote: > 1. Add a header file to provide SIP interface to ATF > 2. Add AUDIO SMC fid > > Change-Id: I218e9f571cea079268a5414725a81e9b35702e33 Please delete Change-Id entry. Apart from that, I don't really get the reason for this patch. Which driver is supposed to use this header file? Please provide more background information. Regards, Matthias > Signed-off-by: Eason Yen <eason.yen@mediatek.com> > --- > include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h > > diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h > new file mode 100644 > index 0000000..00ee0f4 > --- /dev/null > +++ b/include/linux/soc/mediatek/mtk_sip_svc.h > @@ -0,0 +1,28 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2019 MediaTek Inc. > + */ > + > +#ifndef __MTK_SIP_SVC_H__ > +#define __MTK_SIP_SVC_H__ > + > +#include <linux/kernel.h> > + > +/* Error Code */ > +#define SIP_SVC_E_SUCCESS 0 > +#define SIP_SVC_E_NOT_SUPPORTED -1 > +#define SIP_SVC_E_INVALID_PARAMS -2 > +#define SIP_SVC_E_INVALID_Range -3 > +#define SIP_SVC_E_PERMISSION_DENY -4 > + > +#ifdef CONFIG_ARM64 > +#define MTK_SIP_SMC_AARCH_BIT 0x40000000 > +#else > +#define MTK_SIP_SMC_AARCH_BIT 0x00000000 > +#endif > + > +/* AUDIO related SMC call */ > +#define MTK_SIP_AUDIO_CONTROL \ > + (0x82000517 | MTK_SIP_SMC_AARCH_BIT) > +#endif > +/* __MTK_SIP_SVC_H__ */ > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface 2019-11-10 20:18 ` Matthias Brugger @ 2019-11-11 1:38 ` Eason Yen 0 siblings, 0 replies; 4+ messages in thread From: Eason Yen @ 2019-11-11 1:38 UTC (permalink / raw) To: Matthias Brugger Cc: linux-kernel, linux-mediatek, devicetree, wsd_upstream, Eason.Yen Dear Matthias, This header files is used for mtk proprietary drivers. MTK SIP call clients should define MTK_SIP_XXX with specific control ID on this header file. mtk sip call example (sound card driver): arm_smccc_smc(MTK_SIP_AUDIO_CONTROL, /* specific MTK_SIP_XXX id */ MTK_AUDIO_SMC_OP_DRAM_REQUEST, 0, 0, 0, 0, 0, 0, &res); Because sound card driver(mt6779) is still reviewing internally, I just upstream this header file first. I will remove change-id entry and upstream again soon. Thanks for your reviewing. Regards, Eason On Sun, 2019-11-10 at 21:18 +0100, Matthias Brugger wrote: > > On 28/10/2019 08:29, Eason Yen wrote: > > 1. Add a header file to provide SIP interface to ATF > > 2. Add AUDIO SMC fid > > > > Change-Id: I218e9f571cea079268a5414725a81e9b35702e33 > > Please delete Change-Id entry. > Apart from that, I don't really get the reason for this patch. Which driver is > supposed to use this header file? > > Please provide more background information. > > Regards, > Matthias > > > Signed-off-by: Eason Yen <eason.yen@mediatek.com> > > --- > > include/linux/soc/mediatek/mtk_sip_svc.h | 28 ++++++++++++++++++++++++++++ > > 1 file changed, 28 insertions(+) > > create mode 100644 include/linux/soc/mediatek/mtk_sip_svc.h > > > > diff --git a/include/linux/soc/mediatek/mtk_sip_svc.h b/include/linux/soc/mediatek/mtk_sip_svc.h > > new file mode 100644 > > index 0000000..00ee0f4 > > --- /dev/null > > +++ b/include/linux/soc/mediatek/mtk_sip_svc.h > > @@ -0,0 +1,28 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2019 MediaTek Inc. > > + */ > > + > > +#ifndef __MTK_SIP_SVC_H__ > > +#define __MTK_SIP_SVC_H__ > > + > > +#include <linux/kernel.h> > > + > > +/* Error Code */ > > +#define SIP_SVC_E_SUCCESS 0 > > +#define SIP_SVC_E_NOT_SUPPORTED -1 > > +#define SIP_SVC_E_INVALID_PARAMS -2 > > +#define SIP_SVC_E_INVALID_Range -3 > > +#define SIP_SVC_E_PERMISSION_DENY -4 > > + > > +#ifdef CONFIG_ARM64 > > +#define MTK_SIP_SMC_AARCH_BIT 0x40000000 > > +#else > > +#define MTK_SIP_SMC_AARCH_BIT 0x00000000 > > +#endif > > + > > +/* AUDIO related SMC call */ > > +#define MTK_SIP_AUDIO_CONTROL \ > > + (0x82000517 | MTK_SIP_SMC_AARCH_BIT) > > +#endif > > +/* __MTK_SIP_SVC_H__ */ > > ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-11 1:38 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-10-28 7:29 [PATCH v1 1/1] soc: mediatek: add SMC fid table for SIP interface Eason Yen 2019-10-28 7:29 ` Eason Yen 2019-11-10 20:18 ` Matthias Brugger 2019-11-11 1:38 ` Eason Yen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).