From: <Eugen.Hristev@microchip.com>
To: <robh@kernel.org>, <Ludovic.Desroches@microchip.com>,
<wsa@the-dreams.de>
Cc: <peda@axentia.se>, <linux-i2c@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <Codrin.Ciubotariu@microchip.com>,
<Eugen.Hristev@microchip.com>
Subject: [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60
Date: Mon, 9 Dec 2019 10:20:02 +0000 [thread overview]
Message-ID: <1575886763-19089-2-git-send-email-eugen.hristev@microchip.com> (raw)
In-Reply-To: <1575886763-19089-1-git-send-email-eugen.hristev@microchip.com>
From: Eugen Hristev <eugen.hristev@microchip.com>
In SAM9X60 datasheet, FLEX_TWI_CWGR register description mentions clock
offset of 3 cycles (compared to 4 in eg. SAMA5D3).
This is the same offset as in SAMA5D2.
Fixes: b00277923743 ("i2c: at91: add new platform support for sam9x60")
Suggested-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
Acked-by: Ludovic Desroches <ludovic.desroches@microchip.com>
Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---
Changes in v3:
- fixed typo in commit description
Changes in v2:
- Sorry, wrong subject line. Modified to SAM9X60 .
drivers/i2c/busses/i2c-at91-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-at91-core.c b/drivers/i2c/busses/i2c-at91-core.c
index e13af48..5137e62 100644
--- a/drivers/i2c/busses/i2c-at91-core.c
+++ b/drivers/i2c/busses/i2c-at91-core.c
@@ -174,7 +174,7 @@ static struct at91_twi_pdata sama5d2_config = {
static struct at91_twi_pdata sam9x60_config = {
.clk_max_div = 7,
- .clk_offset = 4,
+ .clk_offset = 3,
.has_unre_flag = true,
.has_alt_cmd = true,
.has_hold_field = true,
--
2.7.4
next prev parent reply other threads:[~2019-12-09 10:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 10:19 [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Eugen.Hristev
2019-12-09 10:20 ` Eugen.Hristev [this message]
2020-01-06 14:35 ` [PATCH v3 2/4] i2c: at91: fix clk_offset for sam9x60 Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 3/4] i2c: at91: remote default value initialization Eugen.Hristev
2020-01-06 14:35 ` Wolfram Sang
2019-12-09 10:20 ` [PATCH v3 4/4] dt-bindings: i2c: at91: fix i2c-sda-hold-time-ns documentation for sam9x60 Eugen.Hristev
2019-12-18 21:37 ` Rob Herring
2020-01-06 14:35 ` Wolfram Sang
2019-12-18 21:37 ` [PATCH v3 1/4] dt-bindings: i2c: at91: cosmetic formatting of compatible list Rob Herring
2020-01-06 14:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1575886763-19089-2-git-send-email-eugen.hristev@microchip.com \
--to=eugen.hristev@microchip.com \
--cc=Codrin.Ciubotariu@microchip.com \
--cc=Ludovic.Desroches@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=robh@kernel.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox