* [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT
2020-01-08 7:25 [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT Anson Huang
@ 2020-01-08 7:25 ` Anson Huang
2020-01-08 8:06 ` Daniel Baluta
2020-01-08 8:06 ` [PATCH 1/2] arm64: dts: imx8mm: " Daniel Baluta
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Anson Huang @ 2020-01-08 7:25 UTC (permalink / raw)
To: robh+dt, mark.rutland, shawnguo, s.hauer, kernel, festevam,
daniel.baluta, leonard.crestez, shengjiu.wang, ping.bai, jun.li,
aford173, peng.fan, abel.vesa, devicetree, linux-arm-kernel,
linux-kernel
Cc: Linux-imx
Memory address/size depends on board design, so memory node should
be in board DT.
Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
---
arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 -----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
index 7a92952..0d2ec4a 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
@@ -23,6 +23,11 @@
};
};
+ memory@40000000 {
+ device_type = "memory";
+ reg = <0x0 0x40000000 0 0x80000000>;
+ };
+
reg_usdhc2_vmmc: regulator-usdhc2 {
compatible = "regulator-fixed";
pinctrl-names = "default";
diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
index cce65b9..4014029 100644
--- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
@@ -139,11 +139,6 @@
};
};
- memory@40000000 {
- device_type = "memory";
- reg = <0x0 0x40000000 0 0x80000000>;
- };
-
osc_32k: clock-osc-32k {
compatible = "fixed-clock";
#clock-cells = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: imx8mn: Memory node should be in board DT
2020-01-08 7:25 ` [PATCH 2/2] arm64: dts: imx8mn: " Anson Huang
@ 2020-01-08 8:06 ` Daniel Baluta
0 siblings, 0 replies; 6+ messages in thread
From: Daniel Baluta @ 2020-01-08 8:06 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, robh+dt@kernel.org, Abel Vesa,
devicetree@vger.kernel.org, festevam@gmail.com, Jacky Bai, Jun Li,
mark.rutland@arm.com, Peng Fan, shawnguo@kernel.org,
aford173@gmail.com, Anson Huang, S.j. Wang,
linux-arm-kernel@lists.infradead.org, Leonard Crestez,
kernel@pengutronix.de, s.hauer@pengutronix.de
Cc: dl-linux-imx
On Wed, 2020-01-08 at 15:25 +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> index 7a92952..0d2ec4a 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn-evk.dtsi
> @@ -23,6 +23,11 @@
> };
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> reg_usdhc2_vmmc: regulator-usdhc2 {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> index cce65b9..4014029 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mn.dtsi
> @@ -139,11 +139,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT
2020-01-08 7:25 [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT Anson Huang
2020-01-08 7:25 ` [PATCH 2/2] arm64: dts: imx8mn: " Anson Huang
@ 2020-01-08 8:06 ` Daniel Baluta
2020-01-08 9:24 ` Peng Fan
2020-01-09 10:55 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Daniel Baluta @ 2020-01-08 8:06 UTC (permalink / raw)
To: linux-kernel@vger.kernel.org, robh+dt@kernel.org, Abel Vesa,
devicetree@vger.kernel.org, festevam@gmail.com, Jacky Bai, Jun Li,
mark.rutland@arm.com, Peng Fan, shawnguo@kernel.org,
aford173@gmail.com, Anson Huang, S.j. Wang,
linux-arm-kernel@lists.infradead.org, Leonard Crestez,
kernel@pengutronix.de, s.hauer@pengutronix.de
Cc: dl-linux-imx
On Wed, 2020-01-08 at 15:25 +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
Care to add a cover letter for your next patch series? :).
Just use --cover-letter argument for git format-patch.
Thus, we can keep revision history centralized and can just one
Reviewed-by/Tested-by tag :).
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index cf044dd..9e54747 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -16,6 +16,11 @@
> stdout-path = &uart2;
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index a3d179b..1e5e115 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -140,11 +140,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT
2020-01-08 7:25 [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT Anson Huang
2020-01-08 7:25 ` [PATCH 2/2] arm64: dts: imx8mn: " Anson Huang
2020-01-08 8:06 ` [PATCH 1/2] arm64: dts: imx8mm: " Daniel Baluta
@ 2020-01-08 9:24 ` Peng Fan
2020-01-09 10:55 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Peng Fan @ 2020-01-08 9:24 UTC (permalink / raw)
To: Anson Huang, robh+dt@kernel.org, mark.rutland@arm.com,
shawnguo@kernel.org, s.hauer@pengutronix.de,
kernel@pengutronix.de, festevam@gmail.com, Daniel Baluta,
Leonard Crestez, S.j. Wang, Jacky Bai, Jun Li, aford173@gmail.com,
Abel Vesa, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: dl-linux-imx
> Cc: dl-linux-imx <linux-imx@nxp.com>
> Subject: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board
> DT
>
> Memory address/size depends on board design, so memory node should be in
> board DT.
Not sure it really matters, bootloader will update/create memory node of device
tree.
Regards,
Peng.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 5 +++++
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 5 -----
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index cf044dd..9e54747 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -16,6 +16,11 @@
> stdout-path = &uart2;
> };
>
> + memory@40000000 {
> + device_type = "memory";
> + reg = <0x0 0x40000000 0 0x80000000>;
> + };
> +
> leds {
> compatible = "gpio-leds";
> pinctrl-names = "default";
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> index a3d179b..1e5e115 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mm.dtsi
> @@ -140,11 +140,6 @@
> };
> };
>
> - memory@40000000 {
> - device_type = "memory";
> - reg = <0x0 0x40000000 0 0x80000000>;
> - };
> -
> osc_32k: clock-osc-32k {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> --
> 2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT
2020-01-08 7:25 [PATCH 1/2] arm64: dts: imx8mm: Memory node should be in board DT Anson Huang
` (2 preceding siblings ...)
2020-01-08 9:24 ` Peng Fan
@ 2020-01-09 10:55 ` Shawn Guo
3 siblings, 0 replies; 6+ messages in thread
From: Shawn Guo @ 2020-01-09 10:55 UTC (permalink / raw)
To: Anson Huang
Cc: robh+dt, mark.rutland, s.hauer, kernel, festevam, daniel.baluta,
leonard.crestez, shengjiu.wang, ping.bai, jun.li, aford173,
peng.fan, abel.vesa, devicetree, linux-arm-kernel, linux-kernel,
Linux-imx
On Wed, Jan 08, 2020 at 03:25:28PM +0800, Anson Huang wrote:
> Memory address/size depends on board design, so memory node should
> be in board DT.
>
> Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Applied both, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread