devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yuti Amonkar <yamonkar@cadence.com>
To: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<kishon@ti.com>, <robh+dt@kernel.org>, <mark.rutland@arm.com>,
	<maxime@cerno.tech>
Cc: <jsarha@ti.com>, <tomi.valkeinen@ti.com>, <praneeth@ti.com>,
	<mparab@cadence.com>, <sjakhade@cadence.com>,
	<yamonkar@cadence.com>
Subject: [PATCH v3 13/14] dt-bindings: phy: phy-cadence-torrent: Add subnode bindings.
Date: Wed, 22 Jan 2020 11:45:17 +0100	[thread overview]
Message-ID: <1579689918-7181-14-git-send-email-yamonkar@cadence.com> (raw)
In-Reply-To: <1579689918-7181-1-git-send-email-yamonkar@cadence.com>

From: Swapnil Jakhade <sjakhade@cadence.com>

Add sub-node bindings for each group of PHY lanes based on PHY
type. Only PHY_TYPE_DP is supported currently. Each sub-node
includes properties such as master lane number, link reset, phy
type, number of lanes etc.

Signed-off-by: Swapnil Jakhade <sjakhade@cadence.com>
---
 .../bindings/phy/phy-cadence-torrent.yaml          | 90 ++++++++++++++++++----
 1 file changed, 73 insertions(+), 17 deletions(-)

diff --git a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
index dbb8aa5..eb21615 100644
--- a/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
+++ b/Documentation/devicetree/bindings/phy/phy-cadence-torrent.yaml
@@ -19,6 +19,12 @@ properties:
       - cdns,torrent-phy
       - ti,j721e-serdes-10g
 
+  '#address-cells':
+    const: 1
+
+  '#size-cells':
+    const: 0
+
   clocks:
     maxItems: 1
     description:
@@ -41,44 +47,94 @@ properties:
       - const: torrent_phy
       - const: dptx_phy
 
-  "#phy-cells":
-    const: 0
+  resets:
+    description:
+      Must contain an entry for each in reset-names.
+      See Documentation/devicetree/bindings/reset/reset.txt
 
-  num_lanes:
+  reset-names:
     description:
-      Number of DisplayPort lanes.
-    allOf:
-      - $ref: /schemas/types.yaml#/definitions/uint32
-      - enum: [1, 2, 4]
+      Must be "torrent_reset". It controls the reset to the
+      torrent PHY.
 
-  max_bit_rate:
+patternProperties:
+  '^torrent-phy@[0-7]+$':
+    type: object
     description:
-      Maximum DisplayPort link bit rate to use, in Mbps
-    allOf:
-      - $ref: /schemas/types.yaml#/definitions/uint32
-      - enum: [2160, 2430, 2700, 3240, 4320, 5400, 8100]
+      Each group of PHY lanes with a single master lane should be represented as a sub-node.
+    properties:
+      reg:
+        description:
+          The master lane number. This is the lowest numbered lane in the lane group.
+
+      resets:
+        description:
+          Contains list of resets to get all the link lanes out of reset.
+
+      "#phy-cells":
+        description:
+          Generic PHY binding.
+        const: 0
+
+      cdns,phy-type:
+        description:
+          Should be PHY_TYPE_DP.
+        $ref: /schemas/types.yaml#/definitions/uint32
+
+      cdns,num-lanes:
+        description:
+          Number of DisplayPort lanes.
+        allOf:
+          - $ref: /schemas/types.yaml#/definitions/uint32
+          - enum: [1, 2, 4]
+
+      cdns,max-bit-rate:
+        description:
+          Maximum DisplayPort link bit rate to use, in Mbps
+        allOf:
+          - $ref: /schemas/types.yaml#/definitions/uint32
+          - enum: [2160, 2430, 2700, 3240, 4320, 5400, 8100]
+
+    required:
+      - reg
+      - resets
+      - "#phy-cells"
+      - cdns,phy-type
 
 required:
   - compatible
+  - "#address-cells"
+  - "#size-cells"
   - clocks
   - clock-names
   - reg
   - reg-names
-  - "#phy-cells"
+  - resets
+  - reset-names
 
 additionalProperties: false
 
 examples:
   - |
-    dp_phy: phy@f0fb500000 {
+    #include <dt-bindings/phy/phy.h>
+    torrent_phy: phy@f0fb500000 {
           compatible = "cdns,torrent-phy";
           reg = <0xf0 0xfb500000 0x0 0x00100000>,
                 <0xf0 0xfb030a00 0x0 0x00000040>;
           reg-names = "torrent_phy", "dptx_phy";
-          num_lanes = <4>;
-          max_bit_rate = <8100>;
-          #phy-cells = <0>;
+          resets = <&phyrst 0>;
+          reset-names = "torrent_reset";
           clocks = <&ref_clk>;
           clock-names = "refclk";
+          #address-cells = <1>;
+          #size-cells = <0>;
+          torrent_phy_dp: torrent-phy@0 {
+                    reg = <0>;
+                    resets = <&phyrst 1>;
+                    #phy-cells = <0>;
+                    cdns,phy-type = <PHY_TYPE_DP>;
+                    cdns,num-lanes = <4>;
+                    cdns,max-bit-rate = <8100>;
+          };
     };
 ...
-- 
2.4.5


  parent reply	other threads:[~2020-01-22 10:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-22 10:45 [PATCH v3 00/14] PHY: Update Cadence Torrent PHY driver with reconfiguration Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 01/14] dt-bindings: phy: Convert Cadence MHDP PHY bindings to YAML Yuti Amonkar
2020-01-27 16:25   ` Rob Herring
2020-01-22 10:45 ` [PATCH v3 02/14] phy: cadence-dp: Rename to phy-cadence-torrent Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 03/14] phy: cadence-torrent: Adopt Torrent nomenclature Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 04/14] phy: cadence-torrent: Add wrapper for PHY register access Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 05/14] phy: cadence-torrent: Add wrapper for DPTX " Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 06/14] phy: cadence-torrent: Refactor code for reusability Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 07/14] phy: cadence-torrent: Add 19.2 MHz reference clock support Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 08/14] phy: cadence-torrent: Implement PHY configure APIs Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 09/14] phy: cadence-torrent: Use regmap to read and write Torrent PHY registers Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 10/14] phy: cadence-torrent: Use regmap to read and write DPTX " Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 11/14] dt-bindings: phy: phy-cadence-torrent: Add platform dependent compatible string Yuti Amonkar
2020-01-22 10:45 ` [PATCH v3 12/14] phy: cadence-torrent: Add platform dependent initialization structure Yuti Amonkar
2020-01-22 10:45 ` Yuti Amonkar [this message]
2020-01-27 16:42   ` [PATCH v3 13/14] dt-bindings: phy: phy-cadence-torrent: Add subnode bindings Rob Herring
2020-01-28 10:04     ` Jyri Sarha
2020-01-28 15:40       ` Rob Herring
2020-01-27 16:45   ` Rob Herring
2020-01-22 10:45 ` [PATCH v3 14/14] phy: cadence-torrent: Add support for " Yuti Amonkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1579689918-7181-14-git-send-email-yamonkar@cadence.com \
    --to=yamonkar@cadence.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jsarha@ti.com \
    --cc=kishon@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=maxime@cerno.tech \
    --cc=mparab@cadence.com \
    --cc=praneeth@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=sjakhade@cadence.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).