From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5C049C11D3D for ; Thu, 27 Feb 2020 14:58:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 342C32468A for ; Thu, 27 Feb 2020 14:58:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="md6NOEcH" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732949AbgB0O6S (ORCPT ); Thu, 27 Feb 2020 09:58:18 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:43690 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730000AbgB0O6R (ORCPT ); Thu, 27 Feb 2020 09:58:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1582815495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pGG3QA/MuTy/BE1KaedN0lIF6lHb9h2nDV465fY0RG8=; b=md6NOEcH7wtfylojV61kM1Up4IZ1tc8mCF17PXGNsMNFm4cc/2TFk2TYRpWiqLey9bsH2K LeqVHH9fdOIs6zI40UTIJAf+MvBQm4IEIGfn4wD/n3InleORa0ptOVWvJ/ZHAl2Yw+ZTei CEzWkuRP23LE5odTDjn2JKspv+3W1hU= Date: Thu, 27 Feb 2020 11:57:52 -0300 From: Paul Cercueil Subject: Re: [PATCH v6 5/6] MIPS: DTS: JZ4780: define node for JZ4780 efuse To: "H. Nikolaus Schaller" Cc: PrasannaKumar Muralidharan , Andreas Kemnade , Mathieu Malaterre , Srinivas Kandagatla , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Message-Id: <1582815472.3.4@crapouillou.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nikolaus, Le mer., f=E9vr. 26, 2020 at 12:16, H. Nikolaus Schaller=20 a =E9crit : > From: PrasannaKumar Muralidharan >=20 > This patch brings support for the JZ4780 efuse. Currently it only=20 > exposes > a read only access to the entire 8K bits efuse memory and the > ethernet mac address for the davicom dm9000 chip on the CI20 board. >=20 > It also changes the nemc reg range to avoid overlap. >=20 > Tested-by: Mathieu Malaterre > Signed-off-by: PrasannaKumar Muralidharan > Signed-off-by: Mathieu Malaterre > Signed-off-by: H. Nikolaus Schaller > --- > arch/mips/boot/dts/ingenic/jz4780.dtsi | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) >=20 > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi=20 > b/arch/mips/boot/dts/ingenic/jz4780.dtsi > index f928329b034b..1e266be28096 100644 > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi > @@ -358,7 +358,7 @@ >=20 > nemc: nemc@13410000 { > compatible =3D "ingenic,jz4780-nemc"; > - reg =3D <0x13410000 0x10000>; > + reg =3D <0x13410000 0x4c>; This is wrong, the real size of the register area is 1x15c. > #address-cells =3D <2>; > #size-cells =3D <1>; > ranges =3D <1 0 0x1b000000 0x1000000 > @@ -373,6 +373,21 @@ > status =3D "disabled"; > }; >=20 > + efuse: efuse@134100d0 { > + compatible =3D "ingenic,jz4780-efuse"; > + reg =3D <0x134100d0 0x2c>; > + > + clocks =3D <&cgu JZ4780_CLK_AHB2>; > + clock-names =3D "ahb2"; As explained in my response to the other patch, 'clock-names' can go=20 away. Cheers, -Paul > + > + #address-cells =3D <1>; > + #size-cells =3D <1>; > + > + eth0_addr: eth-mac-addr@0x22 { > + reg =3D <0x22 0x6>; > + }; > + }; > + > dma: dma@13420000 { > compatible =3D "ingenic,jz4780-dma"; > reg =3D <0x13420000 0x400 > -- > 2.23.0 >=20 =