From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B663C3F2CD for ; Fri, 28 Feb 2020 16:26:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 03B692469C for ; Fri, 28 Feb 2020 16:26:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="L+RAqN9A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726277AbgB1Q0s (ORCPT ); Fri, 28 Feb 2020 11:26:48 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:40010 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725730AbgB1Q0s (ORCPT ); Fri, 28 Feb 2020 11:26:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1582907205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xOb0AVoiiFlckuvxHpEhBL9Wrp4HKGY5UhYo5YdakL0=; b=L+RAqN9ACsoeWx1jzHdHE2acUYpgMnq8YMOrZaHk4eeqRdlvNqW9Ns96f0NkFiP6lG/Qu0 5GZTb5K6gIvKRr1+aq4pAawcE+gxgqZxtb/6G5OCl9f7YhANfLqbVe297FNUmrzFJ48Byo 0W9OlUBhOUDdxmv8hJ33Sv1BaXngaCc= Date: Fri, 28 Feb 2020 13:26:20 -0300 From: Paul Cercueil Subject: Re: [PATCH v8 0/7] MIPS: CI20: Add efuse driver for Ingenic JZ4780 and attach to DM9000 for stable MAC addresses To: "H. Nikolaus Schaller" Cc: PrasannaKumar Muralidharan , Andreas Kemnade , Mathieu Malaterre , Srinivas Kandagatla , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Mauro Carvalho Chehab , "David S. Miller" , Greg Kroah-Hartman , Jonathan Cameron , Krzysztof Kozlowski , Kees Cook , Andi Kleen , Geert Uytterhoeven , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com Message-Id: <1582907181.3.7@crapouillou.net> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nikolaus, For the whole series: Reviewed-by: Paul Cercueil Cheers, -Paul Le ven., f=E9vr. 28, 2020 at 17:00, H. Nikolaus Schaller=20 a =E9crit : > * fix a compiler warning/error (reported by Paul Cercueil=20 > ) > * remove clock-names from properties (suggested by Paul Cercueil=20 > ) >=20 > PATCH V7 2020-02-28 14:58:30: > * use devm_add_action_or_reset to unprepare clock in case of error=20 > (suggested by Paul Cercueil ) > * use already existing constants to check for overflow of rd_adj and=20 > rd_strobe > * remove clock-names from bindings example and DTS (suggested by Paul=20 > Cercueil ) > * addition for nemc driver to handle this correctly (contributed by=20 > Paul Cercueil ) > * make efuse a child node of nemc to avoid problems with overlapping > reg address ranges (suggested by Paul Cercueil=20 > ) >=20 > PATCH V6 2020-02-26 12:16:07: > * add dependency on CONFIG_OF and select REGMAP_MMIO (suggested by=20 > Paul Cercueil ) > * add clk_prepare_enable() (suggested by Paul Cercueil=20 > ) > * inline jz4780_efuse_read_32bytes() since it is only used once > * remove read optimization for full block (suggested by Paul Cercueil=20 > ) > * simplify calculations for rd_adj and rd_strobe (suggested by Paul=20 > Cercueil ) > * do calculations for rd_adj and rd_strobe in local variables > * fix overflow check (did allow for 5 bit values although register is=20 > 4 bit wide) > * fixes for yaml (sugested by Andreas Kemnade ) >=20 > PATCH V5 2020-02-22 11:25:35: > * no longer RFC but PATCH > * add yaml bindings (by Andreas Kemnade ) > * fixes to yaml (suggested by Rob Herring ) >=20 > RFC V4 2020-02-17 17:55:35: > * removed read_only for nvmem config because there is no write method > * Kconfig: replaced depends MACH_JZ4780 with MACH_INGENIC > * run through checkpatch and fixed issues > * made use of devm_nvram_register() and get rid of=20 > jz4780_efuse_remove() > (suggested by Srinivas Kandagatla ) > * squashed previous patch 1/9 and 2/9 into single (regmap based)=20 > driver >=20 > RFC V3 2020-02-16 20:20:59: >=20 > This series is based on and a follow up for >=20 > https://lore.kernel.org/patchwork/cover/868157/ >=20 > ("[v2,0/2] Add efuse driver for Ingenic JZ4780 SoC") >=20 > Original authors were > PrasannaKumar Muralidharan > Mathieu Malaterre >=20 > and there are additions / code improvements by > H. Nikolaus Schaller > Paul Cercueil >=20 > This setup works, if the dm9000 driver is compiled > as a module. >=20 > Therefore it is all RFC level. It is also not completely > checkpatched. >=20 >=20 > H. Nikolaus Schaller (1): > MIPS: DTS: CI20: make DM9000 Ethernet controller use NVMEM to find=20 > the > default MAC address >=20 > Paul Cercueil (1): > memory: jz4780_nemc: Only request IO memory the driver will use >=20 > PrasannaKumar Muralidharan (5): > nvmem: add driver for JZ4780 efuse > Bindings: nvmem: add bindings for JZ4780 efuse > Documentation: ABI: nvmem: add documentation for JZ4780 efuse ABI > nvmem: MAINTAINERS: add maintainer for JZ4780 efuse driver > MIPS: DTS: JZ4780: define node for JZ4780 efuse >=20 > .../ABI/testing/sysfs-driver-jz4780-efuse | 16 ++ > .../bindings/nvmem/ingenic,jz4780-efuse.yaml | 45 ++++ > MAINTAINERS | 5 + > arch/mips/boot/dts/ingenic/ci20.dts | 3 + > arch/mips/boot/dts/ingenic/jz4780.dtsi | 19 +- > drivers/memory/jz4780-nemc.c | 15 +- > drivers/nvmem/Kconfig | 12 + > drivers/nvmem/Makefile | 2 + > drivers/nvmem/jz4780-efuse.c | 239=20 > ++++++++++++++++++ > 9 files changed, 353 insertions(+), 3 deletions(-) > create mode 100644=20 > Documentation/ABI/testing/sysfs-driver-jz4780-efuse > create mode 100644=20 > Documentation/devicetree/bindings/nvmem/ingenic,jz4780-efuse.yaml > create mode 100644 drivers/nvmem/jz4780-efuse.c >=20 > -- > 2.23.0 >=20 =