From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33D9C3F2D3 for ; Sat, 29 Feb 2020 19:33:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A8B1124688 for ; Sat, 29 Feb 2020 19:33:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=crapouillou.net header.i=@crapouillou.net header.b="dD3gpeUq" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727316AbgB2Tdq (ORCPT ); Sat, 29 Feb 2020 14:33:46 -0500 Received: from outils.crapouillou.net ([89.234.176.41]:60244 "EHLO crapouillou.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727190AbgB2Tdq (ORCPT ); Sat, 29 Feb 2020 14:33:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=crapouillou.net; s=mail; t=1583004823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=3pmaIIz4IWO5Cvqd4//x0wCrBroxzaVqn7Ua9M/d+fM=; b=dD3gpeUqqLiw2RU0TENRCfQCPkiALo0x/dQt+L+Ch7pFN2UY+ZfyPMwm8gSOku0GTx7ynK 6EAbDQOnrq2MGUVRCFnibZYqbFBX35UJZAgz5fuN7y8iY5jIGhSb7ngVVtnYldsLvjipQh sNHV0Ap2AwvZ55qftn3oLnWuUGZE+/s= Date: Sat, 29 Feb 2020 16:33:21 -0300 From: Paul Cercueil Subject: Re: [PATCH v4 2/5] MIPS: DTS: CI20: fix PMU definitions for ACT8600 To: "H. Nikolaus Schaller" Cc: Paul Boddie , Rob Herring , Mark Rutland , Ralf Baechle , Paul Burton , Miquel Raynal , Andi Kleen , Kees Cook , Krzysztof Kozlowski , Geert Uytterhoeven , "Eric W. Biederman" , devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, stable@vger.kernel.org Message-Id: <1583004801.3.3@crapouillou.net> In-Reply-To: References: <1582992575.3.2@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Nikolaus, Le sam., f=E9vr. 29, 2020 at 19:58, H. Nikolaus Schaller=20 a =E9crit : > Hi Paul, >=20 >> Am 29.02.2020 um 17:09 schrieb Paul Cercueil : >>=20 >> Hi Nikolaus, >>=20 >>=20 >> Le ven., f=E9vr. 28, 2020 at 19:02, H. Nikolaus Schaller=20 >> a =E9crit : >>> There is a ACT8600 on the CI20 board and the bindings of the >>> ACT8865 driver have changed without updating the CI20 device >>> tree. Therefore the PMU can not be probed successfully and >>> is running in power-on reset state. >>> Fix DT to match the latest act8865-regulator bindings. >>> Fixes: 73f2b940474d ("MIPS: CI20: DTS: Add I2C nodes") >>> Cc: stable@vger.kernel.org >>> Signed-off-by: H. Nikolaus Schaller >>> --- >>> arch/mips/boot/dts/ingenic/ci20.dts | 48=20 >>> ++++++++++++++++++++--------- >>> 1 file changed, 33 insertions(+), 15 deletions(-) >>> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts=20 >>> b/arch/mips/boot/dts/ingenic/ci20.dts >>> index 59c104289ece..44741e927d2b 100644 >>> --- a/arch/mips/boot/dts/ingenic/ci20.dts >>> +++ b/arch/mips/boot/dts/ingenic/ci20.dts >>> @@ -4,6 +4,8 @@ >>> #include "jz4780.dtsi" >>> #include >>> #include >>> +#include >>=20 >> This include should be in patch 3/5 where it's first used. >=20 > Yes. That is much better. >=20 >>=20 >> With that fixed: >> Reviewed-by: Paul Cercueil >>=20 >> for the whole series. >=20 > What is easier: that you fix it during applying somewhere > or should I send a v5? I guess send a V5. - Paul >=20 > BR, > Nikolaus >=20 =