devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node
  2020-03-04 12:23 [PATCH 0/1] " Rajeshwari
@ 2020-03-04 12:23 ` Rajeshwari
  2020-03-05  5:19   ` Bjorn Andersson
  0 siblings, 1 reply; 5+ messages in thread
From: Rajeshwari @ 2020-03-04 12:23 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Bjorn Andersson, Mark Rutland
  Cc: linux-arm-msm, devicetree, linux-kernel, sanm, sivaa, Rajeshwari

To enable kernel critical shutdown feature added critical trip point to
all non CPU sensors to perform shutdown in orderly manner.

Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index b8a72cf..7e5f14f 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -1956,6 +1956,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss0_crit: aoss0_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2011,6 +2017,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss0_crit: gpuss0_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2026,6 +2038,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss1_crit: gpuss1_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2041,6 +2059,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss1_crit: aoss1_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2056,6 +2080,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				cwlan_crit: cwlan_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2071,6 +2101,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				audio_crit: audio_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2086,6 +2122,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				ddr_crit: ddr_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2101,6 +2143,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				q6_hvx_crit: q6_hvx_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2116,6 +2164,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				camera_crit: camera_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2131,6 +2185,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_crit: mdm_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2146,6 +2206,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_dsp_crit: mdm_dsp_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2161,6 +2227,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				npu_crit: npu_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 
@@ -2176,6 +2248,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				video_crit: video_crit {
+                                        temperature = <110000>;
+                                        hysteresis = <2000>;
+                                        type = "critical";
+                                };
 			};
 		};
 	};
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node
  2020-03-04 12:23 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
@ 2020-03-05  5:19   ` Bjorn Andersson
  0 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2020-03-05  5:19 UTC (permalink / raw)
  To: Rajeshwari
  Cc: Andy Gross, Rob Herring, Mark Rutland, linux-arm-msm, devicetree,
	linux-kernel, sanm, sivaa

On Wed 04 Mar 04:23 PST 2020, Rajeshwari wrote:

> To enable kernel critical shutdown feature added critical trip point to

s/added/add/
s/point/points/

> all non CPU sensors to perform shutdown in orderly manner.
> 
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
> ---

No need to provide a cover-letter for a single patch.

>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index b8a72cf..7e5f14f 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -1956,6 +1956,12 @@
>  					hysteresis = <2000>;
>  					type = "hot";
>  				};
> +
> +				aoss0_crit: aoss0_crit {
> +                                        temperature = <110000>;
> +                                        hysteresis = <2000>;
> +                                        type = "critical";
> +                                };

The indentation of all but the initial line is off. Same with below
hunks as well. Please correct this.

Regards,
Bjorn

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 0/1] Added critical trip point Thermal-zones node
@ 2020-03-05  7:49 Rajeshwari
  2020-03-05  7:49 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
  0 siblings, 1 reply; 5+ messages in thread
From: Rajeshwari @ 2020-03-05  7:49 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Bjorn Andersson
  Cc: linux-arm-msm, devicetree, linux-kernel, sanm, sivaa, Rajeshwari

Changes:
* Added critical trip point to all non CPU sensors.

Rajeshwari (1):
  arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node

 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node
  2020-03-05  7:49 [PATCH 0/1] Added critical trip point Thermal-zones node Rajeshwari
@ 2020-03-05  7:49 ` Rajeshwari
  2020-03-05 12:59   ` Amit Kucheria
  0 siblings, 1 reply; 5+ messages in thread
From: Rajeshwari @ 2020-03-05  7:49 UTC (permalink / raw)
  To: Andy Gross, Rob Herring, Bjorn Andersson
  Cc: linux-arm-msm, devicetree, linux-kernel, sanm, sivaa, Rajeshwari

To enable kernel critical shutdown feature added critical trip point to
all non CPU sensors to perform shutdown in orderly manner.

Signed-off-by: Rajeshwari <rkambl@codeaurora.org>
---
 arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
 1 file changed, 78 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
index 253274d..ca876ed 100644
--- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
@@ -2366,6 +2366,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss0_crit: aoss0_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2421,6 +2427,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss0_crit: gpuss0_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2436,6 +2448,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				gpuss1_crit: gpuss1_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2451,6 +2469,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				aoss1_crit: aoss1_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2466,6 +2490,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				cwlan_crit: cwlan_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2481,6 +2511,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				audio_crit: audio_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2496,6 +2532,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				ddr_crit: ddr_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2511,6 +2553,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				q6_hvx_crit: q6_hvx_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2526,6 +2574,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				camera_crit: camera_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2541,6 +2595,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_crit: mdm_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2556,6 +2616,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				mdm_dsp_crit: mdm_dsp_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2571,6 +2637,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				npu_crit: npu_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 
@@ -2586,6 +2658,12 @@
 					hysteresis = <2000>;
 					type = "hot";
 				};
+
+				video_crit: video_crit {
+					temperature = <110000>;
+					hysteresis = <2000>;
+					type = "critical";
+				};
 			};
 		};
 	};
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member 
of Code Aurora Forum, hosted by The Linux Foundation


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/1] arm64: dts: qcom: sc7180: Added critical trip point Thermal-zones node
  2020-03-05  7:49 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
@ 2020-03-05 12:59   ` Amit Kucheria
  0 siblings, 0 replies; 5+ messages in thread
From: Amit Kucheria @ 2020-03-05 12:59 UTC (permalink / raw)
  To: Rajeshwari
  Cc: Andy Gross, Rob Herring, Bjorn Andersson, linux-arm-msm,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, LKML,
	sanm, sivaa

Hi Rajeshwari,

Please cc reviewers of the previous version of the patches in the future.

On Thu, Mar 5, 2020 at 1:19 PM Rajeshwari <rkambl@codeaurora.org> wrote:
>
> To enable kernel critical shutdown feature added critical trip point to
> all non CPU sensors to perform shutdown in orderly manner.
>
> Signed-off-by: Rajeshwari <rkambl@codeaurora.org>

Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>

> ---
>  arch/arm64/boot/dts/qcom/sc7180.dtsi | 78 ++++++++++++++++++++++++++++++++++++
>  1 file changed, 78 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> index 253274d..ca876ed 100644
> --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi
> @@ -2366,6 +2366,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               aoss0_crit: aoss0_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2421,6 +2427,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               gpuss0_crit: gpuss0_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2436,6 +2448,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               gpuss1_crit: gpuss1_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2451,6 +2469,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               aoss1_crit: aoss1_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2466,6 +2490,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               cwlan_crit: cwlan_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2481,6 +2511,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               audio_crit: audio_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2496,6 +2532,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               ddr_crit: ddr_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2511,6 +2553,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               q6_hvx_crit: q6_hvx_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2526,6 +2574,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               camera_crit: camera_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2541,6 +2595,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               mdm_crit: mdm_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2556,6 +2616,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               mdm_dsp_crit: mdm_dsp_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2571,6 +2637,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               npu_crit: npu_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>
> @@ -2586,6 +2658,12 @@
>                                         hysteresis = <2000>;
>                                         type = "hot";
>                                 };
> +
> +                               video_crit: video_crit {
> +                                       temperature = <110000>;
> +                                       hysteresis = <2000>;
> +                                       type = "critical";
> +                               };
>                         };
>                 };
>         };
> --
> QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
> of Code Aurora Forum, hosted by The Linux Foundation
>

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2020-03-05 12:59 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-05  7:49 [PATCH 0/1] Added critical trip point Thermal-zones node Rajeshwari
2020-03-05  7:49 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
2020-03-05 12:59   ` Amit Kucheria
  -- strict thread matches above, loose matches on Subject: below --
2020-03-04 12:23 [PATCH 0/1] " Rajeshwari
2020-03-04 12:23 ` [PATCH 1/1] arm64: dts: qcom: sc7180: " Rajeshwari
2020-03-05  5:19   ` Bjorn Andersson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).