* Re: [PATCH v14 01/11] dt-bindings: mediatek: Add property to mt8183 smi-common [not found] ` <1588752963-19934-2-git-send-email-weiyi.lu@mediatek.com> @ 2020-05-06 20:59 ` Enric Balletbo i Serra 2020-05-11 6:00 ` Weiyi Lu 0 siblings, 1 reply; 4+ messages in thread From: Enric Balletbo i Serra @ 2020-05-06 20:59 UTC (permalink / raw) To: Weiyi Lu, Enric Balletbo Serra, Matthias Brugger, Nicolas Boichat, Rob Herring, Sascha Hauer Cc: James Liao, srv_heupstream, linux-kernel, Fan Chen, linux-mediatek, linux-arm-kernel, devicetree Hi Weiyi, Thank you for your patch. Don't forget to cc <devicetree@vger.kernel.org>, otherwise this patch could be silently ignored. On 6/5/20 10:15, Weiyi Lu wrote: > For scpsys driver using regmap based syscon driver API. > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > --- > .../devicetree/bindings/memory-controllers/mediatek,smi-common.txt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > index b478ade..01744ec 100644 > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > @@ -20,7 +20,7 @@ Required properties: > "mediatek,mt2712-smi-common" > "mediatek,mt7623-smi-common", "mediatek,mt2701-smi-common" > "mediatek,mt8173-smi-common" > - "mediatek,mt8183-smi-common" > + "mediatek,mt8183-smi-common", "syscon" > - reg : the register and size of the SMI block. > - power-domains : a phandle to the power domain of this local arbiter. > - clocks : Must contain an entry for each entry in clock-names. > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v14 01/11] dt-bindings: mediatek: Add property to mt8183 smi-common 2020-05-06 20:59 ` [PATCH v14 01/11] dt-bindings: mediatek: Add property to mt8183 smi-common Enric Balletbo i Serra @ 2020-05-11 6:00 ` Weiyi Lu 0 siblings, 0 replies; 4+ messages in thread From: Weiyi Lu @ 2020-05-11 6:00 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: Enric Balletbo Serra, Matthias Brugger, Nicolas Boichat, Rob Herring, Sascha Hauer, James Liao, srv_heupstream, linux-kernel, Fan Chen, linux-mediatek, linux-arm-kernel, devicetree On Wed, 2020-05-06 at 22:59 +0200, Enric Balletbo i Serra wrote: > Hi Weiyi, > > Thank you for your patch. Don't forget to cc <devicetree@vger.kernel.org>, > otherwise this patch could be silently ignored. > Thank you for reminding! > On 6/5/20 10:15, Weiyi Lu wrote: > > For scpsys driver using regmap based syscon driver API. > > > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > > --- > > .../devicetree/bindings/memory-controllers/mediatek,smi-common.txt | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > index b478ade..01744ec 100644 > > --- a/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > +++ b/Documentation/devicetree/bindings/memory-controllers/mediatek,smi-common.txt > > @@ -20,7 +20,7 @@ Required properties: > > "mediatek,mt2712-smi-common" > > "mediatek,mt7623-smi-common", "mediatek,mt2701-smi-common" > > "mediatek,mt8173-smi-common" > > - "mediatek,mt8183-smi-common" > > + "mediatek,mt8183-smi-common", "syscon" > > - reg : the register and size of the SMI block. > > - power-domains : a phandle to the power domain of this local arbiter. > > - clocks : Must contain an entry for each entry in clock-names. > > ^ permalink raw reply [flat|nested] 4+ messages in thread
[parent not found: <1588752963-19934-3-git-send-email-weiyi.lu@mediatek.com>]
* Re: [PATCH v14 02/11] dt-bindings: soc: Add MT8183 power dt-bindings [not found] ` <1588752963-19934-3-git-send-email-weiyi.lu@mediatek.com> @ 2020-05-06 21:00 ` Enric Balletbo i Serra 2020-05-11 6:01 ` Weiyi Lu 0 siblings, 1 reply; 4+ messages in thread From: Enric Balletbo i Serra @ 2020-05-06 21:00 UTC (permalink / raw) To: Weiyi Lu, Enric Balletbo Serra, Matthias Brugger, Nicolas Boichat, Rob Herring, Sascha Hauer Cc: James Liao, srv_heupstream, linux-kernel, Fan Chen, linux-mediatek, linux-arm-kernel, devicetree Hi Weiyi, Thank you for your patch. You should cc devicetree@vger.kernel.org, otherwise this patch might be ignored. On 6/5/20 10:15, Weiyi Lu wrote: > Add power dt-bindings of MT8183 and introduces "BASIC" and > "SUBSYS" clock types in binding document. > The "BASIC" type is compatible to the original power control with > clock name [a-z]+[0-9]*, e.g. mm, vpu1. > The "SUBSYS" type is used for bus protection control with clock > name [a-z]+-[0-9]+, e.g. isp-0, cam-1. > And add an optional smi-comm property for phandle to smi-common > controller. > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > --- > .../devicetree/bindings/soc/mediatek/scpsys.txt | 21 ++++++++++++++--- > include/dt-bindings/power/mt8183-power.h | 26 ++++++++++++++++++++++ > 2 files changed, 44 insertions(+), 3 deletions(-) > create mode 100644 include/dt-bindings/power/mt8183-power.h > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > index 2bc3677..5424e66 100644 > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > @@ -15,6 +15,7 @@ power/power-domain.yaml. It provides the power domains defined in > - include/dt-bindings/power/mt2701-power.h > - include/dt-bindings/power/mt2712-power.h > - include/dt-bindings/power/mt7622-power.h > +- include/dt-bindings/power/mt8183-power.h > > Required properties: > - compatible: Should be one of: > @@ -27,12 +28,16 @@ Required properties: > - "mediatek,mt7623a-scpsys": For MT7623A SoC > - "mediatek,mt7629-scpsys", "mediatek,mt7622-scpsys": For MT7629 SoC > - "mediatek,mt8173-scpsys" > + - "mediatek,mt8183-scpsys" > - #power-domain-cells: Must be 1 > - reg: Address range of the SCPSYS unit > - infracfg: must contain a phandle to the infracfg controller > -- clock, clock-names: clocks according to the common clock binding. > - These are clocks which hardware needs to be > - enabled before enabling certain power domains. > +- clock, clock-names: Clocks according to the common clock binding. > + Some SoCs have to groups of clocks. > + BASIC clocks need to be enabled before enabling the > + corresponding power domain. > + SUBSYS clocks need to be enabled before releasing the > + bus protection. > Required clocks for MT2701 or MT7623: "mm", "mfg", "ethif" > Required clocks for MT2712: "mm", "mfg", "venc", "jpgdec", "audio", "vdec" > Required clocks for MT6765: MUX: "mm", "mfg" > @@ -43,6 +48,15 @@ Required properties: > Required clocks for MT7622 or MT7629: "hif_sel" > Required clocks for MT7623A: "ethif" > Required clocks for MT8173: "mm", "mfg", "venc", "venc_lt" > + Required clocks for MT8183: BASIC: "audio", "mfg", "mm", "cam", "isp", > + "vpu", "vpu1", "vpu2", "vpu3" > + SUBSYS: "mm-0", "mm-1", "mm-2", "mm-3", > + "mm-4", "mm-5", "mm-6", "mm-7", > + "mm-8", "mm-9", "isp-0", "isp-1", > + "cam-0", "cam-1", "cam-2", "cam-3", > + "cam-4", "cam-5", "cam-6", "vpu-0", > + "vpu-1", "vpu-2", "vpu-3", "vpu-4", > + "vpu-5" > > Optional properties: > - vdec-supply: Power supply for the vdec power domain > @@ -55,6 +69,7 @@ Optional properties: > - mfg_async-supply: Power supply for the mfg_async power domain > - mfg_2d-supply: Power supply for the mfg_2d power domain > - mfg-supply: Power supply for the mfg power domain > +- smi_comm: a phandle to the smi-common controller I think that in device-tree hyphen are preferred and kind of a must for new properties, also I think you should prefix this property with "mediatek,". Can I suggest you to use "mediatek,smi" like is done in the mediatek,smi-larb binding? AFAICS is the same phandle right? Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt: - mediatek,smi : a phandle to the smi_common node. > > Example: > > diff --git a/include/dt-bindings/power/mt8183-power.h b/include/dt-bindings/power/mt8183-power.h > new file mode 100644 > index 0000000..d6b25f8 > --- /dev/null > +++ b/include/dt-bindings/power/mt8183-power.h > @@ -0,0 +1,26 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +/* > + * Copyright (c) 2018 MediaTek Inc. You probably want to update the copyright to 2020. > + * Author: Weiyi Lu <weiyi.lu@mediatek.com> > + */ > + > +#ifndef _DT_BINDINGS_POWER_MT8183_POWER_H > +#define _DT_BINDINGS_POWER_MT8183_POWER_H > + > +#define MT8183_POWER_DOMAIN_AUDIO 0 > +#define MT8183_POWER_DOMAIN_CONN 1 > +#define MT8183_POWER_DOMAIN_MFG_ASYNC 2 > +#define MT8183_POWER_DOMAIN_MFG 3 > +#define MT8183_POWER_DOMAIN_MFG_CORE0 4 > +#define MT8183_POWER_DOMAIN_MFG_CORE1 5 > +#define MT8183_POWER_DOMAIN_MFG_2D 6 > +#define MT8183_POWER_DOMAIN_DISP 7 > +#define MT8183_POWER_DOMAIN_CAM 8 > +#define MT8183_POWER_DOMAIN_ISP 9 > +#define MT8183_POWER_DOMAIN_VDEC 10 > +#define MT8183_POWER_DOMAIN_VENC 11 > +#define MT8183_POWER_DOMAIN_VPU_TOP 12 > +#define MT8183_POWER_DOMAIN_VPU_CORE0 13 > +#define MT8183_POWER_DOMAIN_VPU_CORE1 14 > + > +#endif /* _DT_BINDINGS_POWER_MT8183_POWER_H */ > ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v14 02/11] dt-bindings: soc: Add MT8183 power dt-bindings 2020-05-06 21:00 ` [PATCH v14 02/11] dt-bindings: soc: Add MT8183 power dt-bindings Enric Balletbo i Serra @ 2020-05-11 6:01 ` Weiyi Lu 0 siblings, 0 replies; 4+ messages in thread From: Weiyi Lu @ 2020-05-11 6:01 UTC (permalink / raw) To: Enric Balletbo i Serra Cc: Enric Balletbo Serra, Matthias Brugger, Nicolas Boichat, Rob Herring, Sascha Hauer, James Liao, srv_heupstream, devicetree, linux-kernel, Fan Chen, linux-mediatek, linux-arm-kernel On Wed, 2020-05-06 at 23:00 +0200, Enric Balletbo i Serra wrote: > Hi Weiyi, > > Thank you for your patch. You should cc devicetree@vger.kernel.org, otherwise > this patch might be ignored. > Got it. > On 6/5/20 10:15, Weiyi Lu wrote: > > Add power dt-bindings of MT8183 and introduces "BASIC" and > > "SUBSYS" clock types in binding document. > > The "BASIC" type is compatible to the original power control with > > clock name [a-z]+[0-9]*, e.g. mm, vpu1. > > The "SUBSYS" type is used for bus protection control with clock > > name [a-z]+-[0-9]+, e.g. isp-0, cam-1. > > And add an optional smi-comm property for phandle to smi-common > > controller. > > > > Signed-off-by: Weiyi Lu <weiyi.lu@mediatek.com> > > --- > > .../devicetree/bindings/soc/mediatek/scpsys.txt | 21 ++++++++++++++--- > > include/dt-bindings/power/mt8183-power.h | 26 ++++++++++++++++++++++ > > 2 files changed, 44 insertions(+), 3 deletions(-) > > create mode 100644 include/dt-bindings/power/mt8183-power.h > > > > diff --git a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > index 2bc3677..5424e66 100644 > > --- a/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > +++ b/Documentation/devicetree/bindings/soc/mediatek/scpsys.txt > > @@ -15,6 +15,7 @@ power/power-domain.yaml. It provides the power domains defined in > > - include/dt-bindings/power/mt2701-power.h > > - include/dt-bindings/power/mt2712-power.h > > - include/dt-bindings/power/mt7622-power.h > > +- include/dt-bindings/power/mt8183-power.h > > > > Required properties: > > - compatible: Should be one of: > > @@ -27,12 +28,16 @@ Required properties: > > - "mediatek,mt7623a-scpsys": For MT7623A SoC > > - "mediatek,mt7629-scpsys", "mediatek,mt7622-scpsys": For MT7629 SoC > > - "mediatek,mt8173-scpsys" > > + - "mediatek,mt8183-scpsys" > > - #power-domain-cells: Must be 1 > > - reg: Address range of the SCPSYS unit > > - infracfg: must contain a phandle to the infracfg controller > > -- clock, clock-names: clocks according to the common clock binding. > > - These are clocks which hardware needs to be > > - enabled before enabling certain power domains. > > +- clock, clock-names: Clocks according to the common clock binding. > > + Some SoCs have to groups of clocks. > > + BASIC clocks need to be enabled before enabling the > > + corresponding power domain. > > + SUBSYS clocks need to be enabled before releasing the > > + bus protection. > > Required clocks for MT2701 or MT7623: "mm", "mfg", "ethif" > > Required clocks for MT2712: "mm", "mfg", "venc", "jpgdec", "audio", "vdec" > > Required clocks for MT6765: MUX: "mm", "mfg" > > @@ -43,6 +48,15 @@ Required properties: > > Required clocks for MT7622 or MT7629: "hif_sel" > > Required clocks for MT7623A: "ethif" > > Required clocks for MT8173: "mm", "mfg", "venc", "venc_lt" > > + Required clocks for MT8183: BASIC: "audio", "mfg", "mm", "cam", "isp", > > + "vpu", "vpu1", "vpu2", "vpu3" > > + SUBSYS: "mm-0", "mm-1", "mm-2", "mm-3", > > + "mm-4", "mm-5", "mm-6", "mm-7", > > + "mm-8", "mm-9", "isp-0", "isp-1", > > + "cam-0", "cam-1", "cam-2", "cam-3", > > + "cam-4", "cam-5", "cam-6", "vpu-0", > > + "vpu-1", "vpu-2", "vpu-3", "vpu-4", > > + "vpu-5" > > > > Optional properties: > > - vdec-supply: Power supply for the vdec power domain > > @@ -55,6 +69,7 @@ Optional properties: > > - mfg_async-supply: Power supply for the mfg_async power domain > > - mfg_2d-supply: Power supply for the mfg_2d power domain > > - mfg-supply: Power supply for the mfg power domain > > +- smi_comm: a phandle to the smi-common controller > > > I think that in device-tree hyphen are preferred and kind of a must for new > properties, also I think you should prefix this property with "mediatek,". Can I > suggest you to use "mediatek,smi" like is done in the mediatek,smi-larb binding? > AFAICS is the same phandle right? > > Documentation/devicetree/bindings/memory-controllers/mediatek,smi-larb.txt: > - mediatek,smi : a phandle to the smi_common node. > Thanks, I'll follow your suggestion in next version. > > > > > Example: > > > > diff --git a/include/dt-bindings/power/mt8183-power.h b/include/dt-bindings/power/mt8183-power.h > > new file mode 100644 > > index 0000000..d6b25f8 > > --- /dev/null > > +++ b/include/dt-bindings/power/mt8183-power.h > > @@ -0,0 +1,26 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Copyright (c) 2018 MediaTek Inc. > > You probably want to update the copyright to 2020. > Thanks, I'll fix it. > > + * Author: Weiyi Lu <weiyi.lu@mediatek.com> > > + */ > > + > > +#ifndef _DT_BINDINGS_POWER_MT8183_POWER_H > > +#define _DT_BINDINGS_POWER_MT8183_POWER_H > > + > > +#define MT8183_POWER_DOMAIN_AUDIO 0 > > +#define MT8183_POWER_DOMAIN_CONN 1 > > +#define MT8183_POWER_DOMAIN_MFG_ASYNC 2 > > +#define MT8183_POWER_DOMAIN_MFG 3 > > +#define MT8183_POWER_DOMAIN_MFG_CORE0 4 > > +#define MT8183_POWER_DOMAIN_MFG_CORE1 5 > > +#define MT8183_POWER_DOMAIN_MFG_2D 6 > > +#define MT8183_POWER_DOMAIN_DISP 7 > > +#define MT8183_POWER_DOMAIN_CAM 8 > > +#define MT8183_POWER_DOMAIN_ISP 9 > > +#define MT8183_POWER_DOMAIN_VDEC 10 > > +#define MT8183_POWER_DOMAIN_VENC 11 > > +#define MT8183_POWER_DOMAIN_VPU_TOP 12 > > +#define MT8183_POWER_DOMAIN_VPU_CORE0 13 > > +#define MT8183_POWER_DOMAIN_VPU_CORE1 14 > > + > > +#endif /* _DT_BINDINGS_POWER_MT8183_POWER_H */ > > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-05-11 6:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1588752963-19934-1-git-send-email-weiyi.lu@mediatek.com>
[not found] ` <1588752963-19934-2-git-send-email-weiyi.lu@mediatek.com>
2020-05-06 20:59 ` [PATCH v14 01/11] dt-bindings: mediatek: Add property to mt8183 smi-common Enric Balletbo i Serra
2020-05-11 6:00 ` Weiyi Lu
[not found] ` <1588752963-19934-3-git-send-email-weiyi.lu@mediatek.com>
2020-05-06 21:00 ` [PATCH v14 02/11] dt-bindings: soc: Add MT8183 power dt-bindings Enric Balletbo i Serra
2020-05-11 6:01 ` Weiyi Lu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).