devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] dt-bindings: media: venus: Add an optional power domain for perf voting
@ 2020-05-12 11:12 Rajendra Nayak
  2020-05-12 13:55 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Rajendra Nayak @ 2020-05-12 11:12 UTC (permalink / raw)
  To: stanimir.varbanov, robh+dt, agross, bjorn.andersson
  Cc: linux-arm-msm, linux-media, devicetree, linux-kernel, mka,
	Rajendra Nayak

Add an optional power domain which when specified can be used for
setting the performance state of Venus.

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
---
 Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 4 +++-
 Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 4 +++-
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
index 764affa..d5babcd 100644
--- a/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml
@@ -25,12 +25,14 @@ properties:
     maxItems: 1
 
   power-domains:
-    maxItems: 2
+    minItems: 2
+    maxItems: 3
 
   power-domain-names:
     items:
       - const: venus
       - const: vcodec0
+      - const: opp-pd
 
   clocks:
     maxItems: 5
diff --git a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
index 8552f4a..b82321c 100644
--- a/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
+++ b/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml
@@ -25,13 +25,15 @@ properties:
     maxItems: 1
 
   power-domains:
-    maxItems: 3
+    minItems: 3
+    maxItems: 4
 
   power-domain-names:
     items:
       - const: venus
       - const: vcodec0
       - const: vcodec1
+      - const: opp-pd
 
   clocks:
     maxItems: 7
-- 
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] dt-bindings: media: venus: Add an optional power domain for perf voting
  2020-05-12 11:12 [PATCH] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
@ 2020-05-12 13:55 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2020-05-12 13:55 UTC (permalink / raw)
  To: Rajendra Nayak
  Cc: mka, linux-arm-msm, robh+dt, agross, devicetree, bjorn.andersson,
	linux-kernel, stanimir.varbanov, linux-media

On Tue, 12 May 2020 16:42:46 +0530, Rajendra Nayak wrote:
> Add an optional power domain which when specified can be used for
> setting the performance state of Venus.
> 
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> ---
>  Documentation/devicetree/bindings/media/qcom,sc7180-venus.yaml    | 4 +++-
>  Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.yaml | 4 +++-
>  2 files changed, 6 insertions(+), 2 deletions(-)
> 


My bot found errors running 'make dt_binding_check' on your patch:

/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/qcom,sdm845-venus-v2.example.dt.yaml: video-codec@aa00000: power-domain-names: ['venus', 'vcodec0', 'vcodec1'] is too short
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/qcom,sc7180-venus.example.dt.yaml: video-codec@aa00000: power-domain-names: ['venus', 'vcodec0'] is too short

See https://patchwork.ozlabs.org/patch/1288381

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure dt-schema is up to date:

pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade

Please check and re-submit.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-12 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-05-12 11:12 [PATCH] dt-bindings: media: venus: Add an optional power domain for perf voting Rajendra Nayak
2020-05-12 13:55 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).