From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Carlo Caione <carlo@caione.org>,
robh+dt@kernel.org, devicetree@vger.kernel.org,
mturquette@baylibre.com, linux-clk@vger.kernel.org,
linux@arm.linux.org.uk, linux-meson@googlegroups.com,
drake@endlessm.com, jerry.cao@amlogic.com,
victor.wan@amlogic.com, pawel.moll@arm.com,
Carlo Caione <carlo@endlessm.com>
Subject: Re: [PATCH v2 3/7] clk: Amlogic: Add reset controller for CPU cores for Meson8b
Date: Wed, 02 Dec 2015 20:39:16 +0100 [thread overview]
Message-ID: <1589870.aoo3TedUT8@wuerfel> (raw)
In-Reply-To: <1449076953-5058-4-git-send-email-carlo@caione.org>
On Wednesday 02 December 2015 18:22:29 Carlo Caione wrote:
>
> +#define RST_CORE0 0
> +#define RST_CORE1 1
> +#define RST_CORE2 2
> +#define RST_CORE3 3
These defines are rather silly and just cause interdependencies with the header
file. Just drop them and use the numbers directly.
Arnd
next prev parent reply other threads:[~2015-12-02 19:39 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 17:22 [PATCH v2 0/7] Add basic SMP support for Amlogic Meson8b Carlo Caione
2015-12-02 17:22 ` [PATCH v2 1/7] ARM: DTS: Amlogic: Extend L2 cache controller node for Meson8b Carlo Caione
2015-12-02 17:22 ` [PATCH v2 2/7] dt-bindings: Amlogic: Document the CPU reset controller " Carlo Caione
2015-12-04 14:49 ` Rob Herring
2015-12-02 17:22 ` [PATCH v2 3/7] clk: Amlogic: Add reset controller for CPU cores " Carlo Caione
2015-12-02 19:39 ` Arnd Bergmann [this message]
2015-12-02 17:22 ` [PATCH v2 4/7] ARM: DTS: Amlogic: Enable reset controller " Carlo Caione
[not found] ` <1449076953-5058-1-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
2015-12-02 17:22 ` [PATCH v2 5/7] dt-bindings: Amlogic: Add SMP related documentation Carlo Caione
2015-12-04 14:52 ` Rob Herring
2015-12-02 17:22 ` [PATCH v2 6/7] ARM: Amlogic: Add SMP bringup code for Meson8b Carlo Caione
2015-12-02 17:22 ` [PATCH v2 7/7] ARM: DTS: Amlogic: Add SMP related nodes " Carlo Caione
2015-12-04 14:53 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1589870.aoo3TedUT8@wuerfel \
--to=arnd@arndb.de \
--cc=carlo@caione.org \
--cc=carlo@endlessm.com \
--cc=devicetree@vger.kernel.org \
--cc=drake@endlessm.com \
--cc=jerry.cao@amlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-meson@googlegroups.com \
--cc=linux@arm.linux.org.uk \
--cc=mturquette@baylibre.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=victor.wan@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).