* [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties [not found] <1588838535-6050-1-git-send-email-sartgarg@codeaurora.org> @ 2020-05-07 8:02 ` Sarthak Garg 2020-05-15 2:50 ` Rob Herring 2020-05-20 11:33 ` Ulf Hansson [not found] ` <1590139950-7288-1-git-send-email-sartgarg@codeaurora.org> 1 sibling, 2 replies; 6+ messages in thread From: Sarthak Garg @ 2020-05-07 8:02 UTC (permalink / raw) To: adrian.hunter, ulf.hansson Cc: vbadigan, stummala, linux-mmc, linux-kernel, linux-arm-msm, Sarthak Garg, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add information regarding DLL register properties for getting target specific configurations. These DLL register settings may vary from target to target. Also new compatible string value for sm8250 target. Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt index 5445931..b8e1d2b 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt @@ -17,6 +17,7 @@ Required properties: "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; @@ -46,6 +47,13 @@ Required properties: "cal" - reference clock for RCLK delay calibration (optional) "sleep" - sleep clock for RCLK delay calibration (optional) +- qcom,ddr-config: Certain chipsets and platforms require particular settings + for the DDR_CONFIG register. Use this field to specify the register + value as per the Hardware Programming Guide. + +- qcom,dll-config: Chipset and Platform specific value. Use this field to + specify the DLL_CONFIG register value as per Hardware Programming Guide. + Example: sdhc_1: sdhci@f9824900 { @@ -63,6 +71,9 @@ Example: clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; clock-names = "core", "iface"; + + qcom,dll-config = <0x000f642c>; + qcom,ddr-config = <0x80040868>; }; sdhc_2: sdhci@f98a4900 { @@ -80,4 +91,7 @@ Example: clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; clock-names = "core", "iface"; + + qcom,dll-config = <0x0007642c>; + qcom,ddr-config = <0x80040868>; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties 2020-05-07 8:02 ` [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties Sarthak Garg @ 2020-05-15 2:50 ` Rob Herring 2020-05-19 14:00 ` sartgarg 2020-05-20 11:33 ` Ulf Hansson 1 sibling, 1 reply; 6+ messages in thread From: Rob Herring @ 2020-05-15 2:50 UTC (permalink / raw) To: Sarthak Garg Cc: adrian.hunter, ulf.hansson, vbadigan, stummala, linux-mmc, linux-kernel, linux-arm-msm, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On Thu, May 07, 2020 at 01:32:08PM +0530, Sarthak Garg wrote: > Add information regarding DLL register properties for getting target > specific configurations. These DLL register settings may vary from > target to target. > > Also new compatible string value for sm8250 target. > > Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > index 5445931..b8e1d2b 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > @@ -17,6 +17,7 @@ Required properties: > "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" > "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" > "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" > + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" > "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" > "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" > "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; > @@ -46,6 +47,13 @@ Required properties: > "cal" - reference clock for RCLK delay calibration (optional) > "sleep" - sleep clock for RCLK delay calibration (optional) > > +- qcom,ddr-config: Certain chipsets and platforms require particular settings > + for the DDR_CONFIG register. Use this field to specify the register > + value as per the Hardware Programming Guide. > + > +- qcom,dll-config: Chipset and Platform specific value. Use this field to > + specify the DLL_CONFIG register value as per Hardware Programming Guide. Board specific or SoC specific? If the latter, imply this from the compatible string. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties 2020-05-15 2:50 ` Rob Herring @ 2020-05-19 14:00 ` sartgarg 0 siblings, 0 replies; 6+ messages in thread From: sartgarg @ 2020-05-19 14:00 UTC (permalink / raw) To: Rob Herring Cc: adrian.hunter, ulf.hansson, vbadigan, stummala, linux-mmc, linux-kernel, linux-arm-msm, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, linux-mmc-owner On 2020-05-15 08:20, Rob Herring wrote: > On Thu, May 07, 2020 at 01:32:08PM +0530, Sarthak Garg wrote: >> Add information regarding DLL register properties for getting target >> specific configurations. These DLL register settings may vary from >> target to target. >> >> Also new compatible string value for sm8250 target. >> >> Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> >> --- >> Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 14 >> ++++++++++++++ >> 1 file changed, 14 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> index 5445931..b8e1d2b 100644 >> --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt >> @@ -17,6 +17,7 @@ Required properties: >> "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" >> "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" >> "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" >> + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" >> "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" >> "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" >> "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; >> @@ -46,6 +47,13 @@ Required properties: >> "cal" - reference clock for RCLK delay calibration (optional) >> "sleep" - sleep clock for RCLK delay calibration (optional) >> >> +- qcom,ddr-config: Certain chipsets and platforms require particular >> settings >> + for the DDR_CONFIG register. Use this field to specify the register >> + value as per the Hardware Programming Guide. >> + >> +- qcom,dll-config: Chipset and Platform specific value. Use this >> field to >> + specify the DLL_CONFIG register value as per Hardware Programming >> Guide. > > Board specific or SoC specific? If the latter, imply this from the > compatible string. Reposting again as can't find my comment on the https://patchwork.kernel.org/ page. Whatever DLL settings are SOC specific are being taken care with the compatible string. That is the reason we introduced qcom,sm8250-sdhci string. The above listed two configuration can change from board to board as-well. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties 2020-05-07 8:02 ` [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties Sarthak Garg 2020-05-15 2:50 ` Rob Herring @ 2020-05-20 11:33 ` Ulf Hansson 1 sibling, 0 replies; 6+ messages in thread From: Ulf Hansson @ 2020-05-20 11:33 UTC (permalink / raw) To: Sarthak Garg Cc: Adrian Hunter, Veerabhadrarao Badiganti, Sahitya Tummala, linux-mmc@vger.kernel.org, Linux Kernel Mailing List, linux-arm-msm, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS On Thu, 7 May 2020 at 10:03, Sarthak Garg <sartgarg@codeaurora.org> wrote: > > Add information regarding DLL register properties for getting target > specific configurations. These DLL register settings may vary from > target to target. > > Also new compatible string value for sm8250 target. As Rob indicated, it's a bit confusing to understand the bindings. I think the word "target" is what makes this confusing. I would suggest splitting this patch into two pieces. One that adds the new compatible string for the new variant and another patch that adds the *board specific* dll bindings. That should clarify this. Kind regards Uffe > > Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> > --- > Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > index 5445931..b8e1d2b 100644 > --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt > @@ -17,6 +17,7 @@ Required properties: > "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" > "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" > "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" > + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" > "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" > "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" > "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; > @@ -46,6 +47,13 @@ Required properties: > "cal" - reference clock for RCLK delay calibration (optional) > "sleep" - sleep clock for RCLK delay calibration (optional) > > +- qcom,ddr-config: Certain chipsets and platforms require particular settings > + for the DDR_CONFIG register. Use this field to specify the register > + value as per the Hardware Programming Guide. > + > +- qcom,dll-config: Chipset and Platform specific value. Use this field to > + specify the DLL_CONFIG register value as per Hardware Programming Guide. > + > Example: > > sdhc_1: sdhci@f9824900 { > @@ -63,6 +71,9 @@ Example: > > clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; > clock-names = "core", "iface"; > + > + qcom,dll-config = <0x000f642c>; > + qcom,ddr-config = <0x80040868>; > }; > > sdhc_2: sdhci@f98a4900 { > @@ -80,4 +91,7 @@ Example: > > clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; > clock-names = "core", "iface"; > + > + qcom,dll-config = <0x0007642c>; > + qcom,ddr-config = <0x80040868>; > }; > -- > 2.7.4 > ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1590139950-7288-1-git-send-email-sartgarg@codeaurora.org>]
* [PATCH V2 1/8] dt-bindings: mmc: Add new compatible string for sm8250 target [not found] ` <1590139950-7288-1-git-send-email-sartgarg@codeaurora.org> @ 2020-05-22 9:32 ` Sarthak Garg 2020-05-22 9:32 ` [PATCH V2 2/8] dt-bindings: mmc: Add information for DLL register properties Sarthak Garg 1 sibling, 0 replies; 6+ messages in thread From: Sarthak Garg @ 2020-05-22 9:32 UTC (permalink / raw) To: adrian.hunter, ulf.hansson Cc: vbadigan, stummala, linux-mmc, linux-kernel, linux-arm-msm, Sarthak Garg, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add new compatible string for sm8250 target. Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt index 5445931..481f692f 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt @@ -17,6 +17,7 @@ Required properties: "qcom,msm8916-sdhci", "qcom,sdhci-msm-v4" "qcom,msm8992-sdhci", "qcom,sdhci-msm-v4" "qcom,msm8996-sdhci", "qcom,sdhci-msm-v4" + "qcom,sm8250-sdhci", "qcom,sdhci-msm-v5" "qcom,sdm845-sdhci", "qcom,sdhci-msm-v5" "qcom,qcs404-sdhci", "qcom,sdhci-msm-v5" "qcom,sc7180-sdhci", "qcom,sdhci-msm-v5"; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH V2 2/8] dt-bindings: mmc: Add information for DLL register properties [not found] ` <1590139950-7288-1-git-send-email-sartgarg@codeaurora.org> 2020-05-22 9:32 ` [PATCH V2 1/8] dt-bindings: mmc: Add new compatible string for sm8250 target Sarthak Garg @ 2020-05-22 9:32 ` Sarthak Garg 1 sibling, 0 replies; 6+ messages in thread From: Sarthak Garg @ 2020-05-22 9:32 UTC (permalink / raw) To: adrian.hunter, ulf.hansson Cc: vbadigan, stummala, linux-mmc, linux-kernel, linux-arm-msm, Sarthak Garg, Rob Herring, open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS Add information regarding DLL register properties for getting board specific configurations. These DLL register settings may vary from board to board. Signed-off-by: Sarthak Garg <sartgarg@codeaurora.org> --- Documentation/devicetree/bindings/mmc/sdhci-msm.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt index 481f692f..b8e1d2b 100644 --- a/Documentation/devicetree/bindings/mmc/sdhci-msm.txt +++ b/Documentation/devicetree/bindings/mmc/sdhci-msm.txt @@ -47,6 +47,13 @@ Required properties: "cal" - reference clock for RCLK delay calibration (optional) "sleep" - sleep clock for RCLK delay calibration (optional) +- qcom,ddr-config: Certain chipsets and platforms require particular settings + for the DDR_CONFIG register. Use this field to specify the register + value as per the Hardware Programming Guide. + +- qcom,dll-config: Chipset and Platform specific value. Use this field to + specify the DLL_CONFIG register value as per Hardware Programming Guide. + Example: sdhc_1: sdhci@f9824900 { @@ -64,6 +71,9 @@ Example: clocks = <&gcc GCC_SDCC1_APPS_CLK>, <&gcc GCC_SDCC1_AHB_CLK>; clock-names = "core", "iface"; + + qcom,dll-config = <0x000f642c>; + qcom,ddr-config = <0x80040868>; }; sdhc_2: sdhci@f98a4900 { @@ -81,4 +91,7 @@ Example: clocks = <&gcc GCC_SDCC2_APPS_CLK>, <&gcc GCC_SDCC2_AHB_CLK>; clock-names = "core", "iface"; + + qcom,dll-config = <0x0007642c>; + qcom,ddr-config = <0x80040868>; }; -- 2.7.4 ^ permalink raw reply related [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-05-22 9:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1588838535-6050-1-git-send-email-sartgarg@codeaurora.org>
2020-05-07 8:02 ` [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties Sarthak Garg
2020-05-15 2:50 ` Rob Herring
2020-05-19 14:00 ` sartgarg
2020-05-20 11:33 ` Ulf Hansson
[not found] ` <1590139950-7288-1-git-send-email-sartgarg@codeaurora.org>
2020-05-22 9:32 ` [PATCH V2 1/8] dt-bindings: mmc: Add new compatible string for sm8250 target Sarthak Garg
2020-05-22 9:32 ` [PATCH V2 2/8] dt-bindings: mmc: Add information for DLL register properties Sarthak Garg
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).