From: Hanks Chen <hanks.chen@mediatek.com>
To: Sean Wang <sean.wang@kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andy Teng <andy.teng@mediatek.com>,
lkml <linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>,
<devicetree@vger.kernel.org>, <wsd_upstream@mediatek.com>,
Mars Cheng <mars.cheng@mediatek.com>
Subject: Re: [PATCH v5 2/6] pinctrl: mediatek: update pinmux definitions for mt6779
Date: Thu, 28 May 2020 19:59:05 +0800 [thread overview]
Message-ID: <1590667145.4266.6.camel@mtkswgap22> (raw)
In-Reply-To: <CAGp9LzoULALLvO+x2TnO=K=pSD05bJFowB-usAcrpz0ddEN+Ug@mail.gmail.com>
On Thu, 2020-04-02 at 14:54 -0700, Sean Wang wrote:
> Hi, Hanks
>
> Just a few nitpicks and then Acked-by: Sean Wang <sean.wang@kernel.org>
>
> On Wed, Mar 25, 2020 at 2:31 AM Hanks Chen <hanks.chen@mediatek.com> wrote:
> >
> > Add devicetree bindings for Mediatek mt6779 SoC Pin Controller.
> >
> > Signed-off-by: Hanks Chen <hanks.chen@mediatek.com>
> > Signed-off-by: Mars Cheng <mars.cheng@mediatek.com>
> > Signed-off-by: Andy Teng <andy.teng@mediatek.com>
> > ---
> > include/dt-bindings/pinctrl/mt6779-pinfunc.h | 1242 ++++++++++++++++++++++++++
> > 1 file changed, 1242 insertions(+)
> > create mode 100644 include/dt-bindings/pinctrl/mt6779-pinfunc.h
> >
> > diff --git a/include/dt-bindings/pinctrl/mt6779-pinfunc.h b/include/dt-bindings/pinctrl/mt6779-pinfunc.h
> > new file mode 100644
> > index 0000000..4698d2f
> > --- /dev/null
> > +++ b/include/dt-bindings/pinctrl/mt6779-pinfunc.h
> > @@ -0,0 +1,1242 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/*
> > + * Copyright (C) 2019 MediaTek Inc.
> > + * Author: Andy Teng <andy.teng@mediatek.com>
> > + *
> > + */
> > +
> > +#ifndef __MT6779_PINFUNC_H
> > +#define __MT6779_PINFUNC_H
> > +
> > +#include "mt65xx.h"
>
> Use the standard include path instead: #include <dt-bindings/pinctrl/mt65xx.h>
>
Got it, I'll revise it in next version
Thanks for your comment.
> > +
> <snip>
> > +
> > +#define PINMUX_GPIO209__FUNC_GPIO209 (MTK_PIN_NO(209) | 0)
> > +
> > +#endif /* __MT6779-PINFUNC_H */
> __MT6779_PINFUNC_H
> > --
> > 1.7.9.5
next prev parent reply other threads:[~2020-05-28 11:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-25 9:31 [PATCH v5 0/6] Add basic SoC Support for Mediatek MT6779 SoC Hanks Chen
2020-03-25 9:31 ` [PATCH v5 1/6] dt-bindings: pinctrl: add bindings for MediaTek " Hanks Chen
2020-03-26 16:28 ` Rob Herring
2020-03-26 17:43 ` Rob Herring
2020-05-28 11:51 ` Hanks Chen
2020-03-25 9:31 ` [PATCH v5 2/6] pinctrl: mediatek: update pinmux definitions for mt6779 Hanks Chen
2020-04-02 21:54 ` Sean Wang
2020-05-28 11:59 ` Hanks Chen [this message]
2020-03-25 9:31 ` [PATCH v5 3/6] pinctrl: mediatek: avoid virtual gpio trying to set reg Hanks Chen
2020-04-02 21:33 ` Sean Wang
2020-03-25 9:31 ` [PATCH v5 4/6] pinctrl: mediatek: add pinctrl support for MT6779 SoC Hanks Chen
2020-03-25 15:05 ` Randy Dunlap
2020-04-02 21:46 ` Sean Wang
2020-05-28 12:34 ` Hanks Chen
2020-03-25 9:31 ` [PATCH v5 5/6] pinctrl: mediatek: add mt6779 eint support Hanks Chen
2020-03-25 9:31 ` [PATCH v5 6/6] arm64: dts: add dts nodes for MT6779 Hanks Chen
2020-03-25 16:39 ` Matthias Brugger
2020-06-16 13:34 ` Hanks Chen
2020-06-22 11:25 ` Matthias Brugger
2020-06-22 12:09 ` Hanks Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1590667145.4266.6.camel@mtkswgap22 \
--to=hanks.chen@mediatek.com \
--cc=andy.teng@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mars.cheng@mediatek.com \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).