From: Stephen Boyd <sboyd@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
bjorn.andersson@linaro.org, linus.walleij@linaro.org,
robh+dt@kernel.org, andy.gross@linaro.org,
linux-arm-msm@vger.kernel.org
Cc: rnayak@codeaurora.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support
Date: Thu, 27 Jul 2017 14:02:35 -0700 [thread overview]
Message-ID: <15907d20-c0a5-1825-ea5f-56eb13df746b@codeaurora.org> (raw)
In-Reply-To: <1501137036-20155-1-git-send-email-vivek.gautam@codeaurora.org>
On 07/26/2017 11:30 PM, Vivek Gautam wrote:
> Update the bindings doc and driver for pmi8994-gpio devices.
>
> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
> ---
>
> - Have been using this patch-set on db820c [1] for extcon with
> usb controller. The usb controller uses one of these gpios
> for usb-id/vbus detection.
>
> [1] https://github.com/boddob/linux/tree/for-qcomlt/4.13rc2-merged
>
> Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt | 2 ++
> drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> index 8d893a874634..74932318d41d 100644
> --- a/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/qcom,pmic-gpio.txt
> @@ -15,6 +15,7 @@ PMIC's from Qualcomm.
> "qcom,pm8921-gpio"
> "qcom,pm8941-gpio"
> "qcom,pm8994-gpio"
> + "qcom,pmi8994-gpio"
pmi comes after pma. Please sort alphabetically.
> "qcom,pma8084-gpio"
>
> And must contain either "qcom,spmi-gpio" or "qcom,ssbi-gpio"
> @@ -84,6 +85,7 @@ to specify in a pin configuration subnode:
> gpio1-gpio44 for pm8921
> gpio1-gpio36 for pm8941
> gpio1-gpio22 for pm8994
> + gpio1-gpio10 for pmi8994
> gpio1-gpio22 for pma8084
>
> - function:
> diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> index 664b641fd776..bf0a6438424b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c
> @@ -799,6 +799,7 @@ static int pmic_gpio_remove(struct platform_device *pdev)
> { .compatible = "qcom,pm8916-gpio" }, /* 4 GPIO's */
> { .compatible = "qcom,pm8941-gpio" }, /* 36 GPIO's */
> { .compatible = "qcom,pm8994-gpio" }, /* 22 GPIO's */
> + { .compatible = "qcom,pmi8994-gpio" }, /* 10 GPIO's */
As stated on the other patch, please drop this hunk.
> { .compatible = "qcom,pma8084-gpio" }, /* 22 GPIO's */
> { .compatible = "qcom,spmi-gpio" }, /* Generic */
> { },
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2017-07-27 21:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-27 6:30 [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support Vivek Gautam
2017-07-27 6:30 ` [PATCH 2/2] arm64: dts: Add device node for pmi8994 gpios Vivek Gautam
2017-07-27 21:00 ` Stephen Boyd
2017-07-28 6:01 ` Vivek Gautam
2017-07-27 21:02 ` Stephen Boyd [this message]
2017-08-03 20:01 ` [PATCH 1/2] pinctrl: qcom: spmi-gpio: Add pmi8994 gpio support Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15907d20-c0a5-1825-ea5f-56eb13df746b@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=andy.gross@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).