From: Yingjoe Chen <yingjoe.chen@mediatek.com>
To: Qii Wang <qii.wang@mediatek.com>
Cc: <wsa@the-dreams.de>, <devicetree@vger.kernel.org>,
<srv_heupstream@mediatek.com>, <leilk.liu@mediatek.com>,
<linux-kernel@vger.kernel.org>,
<linux-mediatek@lists.infradead.org>, <linux-i2c@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support
Date: Sat, 20 Jun 2020 15:45:54 +0800 [thread overview]
Message-ID: <1592639154.5529.3.camel@mtksdaap41> (raw)
In-Reply-To: <1589461844-15614-3-git-send-email-qii.wang@mediatek.com>
Sorry for late review.
On Thu, 2020-05-14 at 21:09 +0800, Qii Wang wrote:
> This patch adds a algorithm to calculate some ac-timing parameters
> which can fully meet I2C Spec.
>
> Signed-off-by: Qii Wang <qii.wang@mediatek.com>
> ---
> drivers/i2c/busses/i2c-mt65xx.c | 328 +++++++++++++++++++++++++++++++++-------
> 1 file changed, 277 insertions(+), 51 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-mt65xx.c b/drivers/i2c/busses/i2c-mt65xx.c
> index 0ca6c38a..7020618 100644
> --- a/drivers/i2c/busses/i2c-mt65xx.c
> +++ b/drivers/i2c/busses/i2c-mt65xx.c
<...>
> @@ -948,9 +1177,6 @@ static int mtk_i2c_probe(struct platform_device *pdev)
> if (ret)
> return -EINVAL;
>
> - if (i2c->dev_comp->timing_adjust)
> - i2c->clk_src_div *= I2C_DEFAULT_CLK_DIV;
> -
After this patch, the 'clock-div' property in device tree is no longer
used for platform with timing_adjust ability.
Please change the binding, so we don't need to provide 'clock-div' for
these platform.
Joe.C
> if (i2c->have_pmic && !i2c->dev_comp->pmic_i2c)
> return -EINVAL;
>
prev parent reply other threads:[~2020-06-20 7:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 13:09 [PATCH v2 0/2] Add i2c ac-timing adjust support Qii Wang
2020-05-14 13:09 ` [PATCH v2 1/2] MAINTAINERS: add maintainer for mediatek i2c controller driver Qii Wang
2020-05-15 9:40 ` Wolfram Sang
2020-05-14 13:09 ` [PATCH v2 2/2] i2c: mediatek: Add i2c ac-timing adjust support Qii Wang
2020-05-15 9:40 ` Wolfram Sang
2020-05-18 15:44 ` Geert Uytterhoeven
2020-05-19 2:57 ` Qii Wang
2020-05-19 7:14 ` Geert Uytterhoeven
2020-05-20 8:41 ` Qii Wang
2020-05-20 8:58 ` Geert Uytterhoeven
2020-05-20 9:14 ` Qii Wang
2020-05-19 11:17 ` Valdis Klētnieks
2020-06-20 7:45 ` Yingjoe Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1592639154.5529.3.camel@mtksdaap41 \
--to=yingjoe.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=leilk.liu@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=qii.wang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).