* [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI
@ 2020-06-23 18:31 Tim Harvey
2020-06-23 18:40 ` Fabio Estevam
2020-06-23 19:06 ` [PATCH v3] " Tim Harvey
0 siblings, 2 replies; 7+ messages in thread
From: Tim Harvey @ 2020-06-23 18:31 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Tim Harvey
The audio codec on the GW551x routes to ssi1
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v2: fix typo in commit short desc
---
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index c38e86e..8c33510 100644
--- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
@@ -110,7 +110,7 @@
simple-audio-card,frame-master = <&sound_codec>;
sound_cpu: simple-audio-card,cpu {
- sound-dai = <&ssi2>;
+ sound-dai = <&ssi1>;
};
sound_codec: simple-audio-card,codec {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 18:31 [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI Tim Harvey
@ 2020-06-23 18:40 ` Fabio Estevam
2020-06-23 18:52 ` Tim Harvey
2020-06-23 19:06 ` [PATCH v3] " Tim Harvey
1 sibling, 1 reply; 7+ messages in thread
From: Fabio Estevam @ 2020-06-23 18:40 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel
Hi Tim,
On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> The audio codec on the GW551x routes to ssi1
>
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Shouldn't this have a Fixes tag, so that it could be backported to
older stable kernels?
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 18:40 ` Fabio Estevam
@ 2020-06-23 18:52 ` Tim Harvey
2020-06-23 18:56 ` Fabio Estevam
0 siblings, 1 reply; 7+ messages in thread
From: Tim Harvey @ 2020-06-23 18:52 UTC (permalink / raw)
To: Fabio Estevam
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, stable
On Tue, Jun 23, 2020 at 11:41 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Tim,
>
> On Tue, Jun 23, 2020 at 3:31 PM Tim Harvey <tharvey@gateworks.com> wrote:
> >
> > The audio codec on the GW551x routes to ssi1
> >
> > Signed-off-by: Tim Harvey <tharvey@gateworks.com>
>
> Shouldn't this have a Fixes tag, so that it could be backported to
> older stable kernels?
Fabio,
Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1.
I didn't think it would apply cleanly to stable but it looks like it
does.
I cc'd stable@vger.kernel.org. Should I submit a new revision with the
following?
Cc: stable@vger.kernel.org
Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Thanks,
Tim
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 18:52 ` Tim Harvey
@ 2020-06-23 18:56 ` Fabio Estevam
0 siblings, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2020-06-23 18:56 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, stable
Hi Tim,
On Tue, Jun 23, 2020 at 3:52 PM Tim Harvey <tharvey@gateworks.com> wrote:
> Yes, it likely should as it fixes audio capture from 3117e851cef1b4e1.
> I didn't think it would apply cleanly to stable but it looks like it
> does.
>
> I cc'd stable@vger.kernel.org. Should I submit a new revision with the
> following?
>
> Cc: stable@vger.kernel.org
> Fixes: 3117e851cef1b4e1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Yes, that would be better.
Please note that the commit ID used in the Fixes tag should be 12-digit long.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v3] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 18:31 [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI Tim Harvey
2020-06-23 18:40 ` Fabio Estevam
@ 2020-06-23 19:06 ` Tim Harvey
2020-06-23 19:10 ` Fabio Estevam
2020-07-11 14:32 ` Shawn Guo
1 sibling, 2 replies; 7+ messages in thread
From: Tim Harvey @ 2020-06-23 19:06 UTC (permalink / raw)
To: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, NXP Linux Team
Cc: devicetree, linux-arm-kernel, linux-kernel, Tim Harvey, stable
The audio codec on the GW551x routes to ssi1
Cc: stable@vger.kernel.org
Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
v3: add fixes tag
v2: fix typo in commit short desc
---
arch/arm/boot/dts/imx6qdl-gw551x.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
index c38e86e..8c33510 100644
--- a/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-gw551x.dtsi
@@ -110,7 +110,7 @@
simple-audio-card,frame-master = <&sound_codec>;
sound_cpu: simple-audio-card,cpu {
- sound-dai = <&ssi2>;
+ sound-dai = <&ssi1>;
};
sound_codec: simple-audio-card,codec {
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 19:06 ` [PATCH v3] " Tim Harvey
@ 2020-06-23 19:10 ` Fabio Estevam
2020-07-11 14:32 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Fabio Estevam @ 2020-06-23 19:10 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Shawn Guo, Sascha Hauer, Pengutronix Kernel Team,
NXP Linux Team,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE,
linux-kernel, stable
On Tue, Jun 23, 2020 at 4:07 PM Tim Harvey <tharvey@gateworks.com> wrote:
>
> The audio codec on the GW551x routes to ssi1
>
> Cc: stable@vger.kernel.org
> Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH v3] ARM: dts: imx6qdl-gw551x: fix audio SSI
2020-06-23 19:06 ` [PATCH v3] " Tim Harvey
2020-06-23 19:10 ` Fabio Estevam
@ 2020-07-11 14:32 ` Shawn Guo
1 sibling, 0 replies; 7+ messages in thread
From: Shawn Guo @ 2020-07-11 14:32 UTC (permalink / raw)
To: Tim Harvey
Cc: Rob Herring, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
NXP Linux Team, devicetree, linux-arm-kernel, linux-kernel,
stable
On Tue, Jun 23, 2020 at 12:06:54PM -0700, Tim Harvey wrote:
> The audio codec on the GW551x routes to ssi1
>
> Cc: stable@vger.kernel.org
> Fixes: 3117e851cef1 ("ARM: dts: imx: Add TDA19971 HDMI Receiver to GW551x")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-11 14:32 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-23 18:31 [RESEND PATCH v2] ARM: dts: imx6qdl-gw551x: fix audio SSI Tim Harvey
2020-06-23 18:40 ` Fabio Estevam
2020-06-23 18:52 ` Tim Harvey
2020-06-23 18:56 ` Fabio Estevam
2020-06-23 19:06 ` [PATCH v3] " Tim Harvey
2020-06-23 19:10 ` Fabio Estevam
2020-07-11 14:32 ` Shawn Guo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).