From: satya priya <skakit@codeaurora.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Matthias Kaehlcke <mka@chromium.org>,
gregkh@linuxfoundation.org, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, akashast@codeaurora.org,
rojay@codeaurora.org, msavaliy@qti.qualcomm.com,
satya priya <skakit@codeaurora.org>
Subject: [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart
Date: Thu, 20 Aug 2020 19:21:06 +0530 [thread overview]
Message-ID: <1597931467-24268-3-git-send-email-skakit@codeaurora.org> (raw)
In-Reply-To: <1597931467-24268-1-git-send-email-skakit@codeaurora.org>
Add sleep pin ctrl for BT uart, and also change the bias
configuration to match Bluetooth module.
Signed-off-by: satya priya <skakit@codeaurora.org>
Reviewed-by: Akash Asthana <akashast@codeaurora.org>
---
Changes in V2:
- This patch adds sleep state for BT UART. Newly added in V2.
Changes in V3:
- Remove "output-high" for TX from both sleep and default states
as it is not required. Configure pull-up for TX in sleep state.
arch/arm64/boot/dts/qcom/sc7180-idp.dts | 54 +++++++++++++++++++++++++++------
1 file changed, 45 insertions(+), 9 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
index d8b5507..806f626 100644
--- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts
+++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts
@@ -473,20 +473,20 @@
&qup_uart3_default {
pinconf-cts {
- /*
- * Configure a pull-down on 38 (CTS) to match the pull of
- * the Bluetooth module.
- */
+ /* Configure no pull on 38 (CTS) to match Bluetooth module */
pins = "gpio38";
- bias-pull-down;
- output-high;
+ bias-disable;
};
pinconf-rts {
- /* We'll drive 39 (RTS), so no pull */
+ /*
+ * Configure pull-down on 39 (RTS). This is needed to avoid a
+ * floating pin which could mislead Bluetooth controller
+ * with UART RFR state (READY/NOT_READY).
+ */
pins = "gpio39";
drive-strength = <2>;
- bias-disable;
+ bias-pull-down;
};
pinconf-tx {
@@ -494,7 +494,43 @@
pins = "gpio40";
drive-strength = <2>;
bias-disable;
- output-high;
+ };
+
+ pinconf-rx {
+ /*
+ * Configure a pull-up on 41 (RX). This is needed to avoid
+ * garbage data when the TX pin of the Bluetooth module is
+ * in tri-state (module powered off or not driving the
+ * signal yet).
+ */
+ pins = "gpio41";
+ bias-pull-up;
+ };
+};
+
+&qup_uart3_sleep {
+ pinconf-cts {
+ /* Configure no-pull on 38 (CTS) to match Bluetooth module */
+ pins = "gpio38";
+ bias-disable;
+ };
+
+ pinconf-rts {
+ /*
+ * Configure pull-down on 39 (RTS). This is needed to avoid a
+ * floating pin which could mislead Bluetooth controller
+ * with UART RFR state (READY/NOT_READY).
+ */
+ pins = "gpio39";
+ drive-strength = <2>;
+ bias-pull-down;
+ };
+
+ pinconf-tx {
+ /* Configure pull-up on 40 (TX) when it isn't actively driven */
+ pins = "gpio40";
+ drive-strength = <2>;
+ bias-pull-up;
};
pinconf-rx {
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2020-08-20 13:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-20 13:51 [PATCH V3 0/3] Add wakeup support over UART RX satya priya
2020-08-20 13:51 ` [PATCH V3 1/3] arm64: dts: sc7180: " satya priya
2020-08-21 16:26 ` Matthias Kaehlcke
2020-08-20 13:51 ` satya priya [this message]
2020-08-21 17:22 ` [PATCH V3 2/3] arm64: dts: qcom: sc7180: Add sleep pin ctrl for BT uart Matthias Kaehlcke
2020-08-25 13:12 ` skakit
2020-08-25 16:38 ` Matthias Kaehlcke
2020-08-26 16:05 ` skakit
2020-08-26 16:40 ` Matthias Kaehlcke
2020-08-27 15:07 ` skakit
2020-08-27 15:23 ` Matthias Kaehlcke
2020-08-28 11:56 ` skakit
2020-08-20 13:51 ` [PATCH V3 3/3] tty: serial: qcom_geni_serial: Fix the UART wakeup issue satya priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1597931467-24268-3-git-send-email-skakit@codeaurora.org \
--to=skakit@codeaurora.org \
--cc=agross@kernel.org \
--cc=akashast@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=msavaliy@qti.qualcomm.com \
--cc=robh+dt@kernel.org \
--cc=rojay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).