Re: [RFC PATCH 01/11] dt-bindings: update the binding for Allwinner H3 TVE support

Maxime Ripard
2017-05-19T18:02:15Z

[-- Attachment #1: Type: text/plain, Size: 1119 bytes --]

On Thu, May 18, 2017 at 12:43:44AM +0800, Icenowy Zheng wrote:
> -On SoCs other than the A33 and V3s, there is one more clock required:
> +For the following compatibles:
> + * allwinner,sun5i-a13-tcon
> + * allwinner,sun6i-a31-tcon
> + * allwinner,sun6i-a31s-tcon
> + * allwinner,sun8i-a33-tcon
> + * allwinner,sun8i-v3s-tcon
> +there is one more clock and one more property required:
> + - clocks:
> + - 'tcon-ch0': The clock driving the TCON channel 0
> + - clock-output-names: Name of the pixel clock created
> +
> +For the following compatibles:
> + * allwinner,sun5i-a13-tcon
> + * allwinner,sun6i-a31-tcon
> + * allwinner,sun6i-a31s-tcon
> + * allwinner,sun8i-h3-tcon0
> +there is one more clock required:
> - 'tcon-ch1': The clock driving the TCON channel 1

Putting ID's in the compatible name is usually a bad idea. What is the
difference between the two? Only that the second one doesn't have a
clock?

That seems highly unlikely. How does it generate the pixel clock
frequency?

Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering