From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5537BC4332F for ; Fri, 18 Nov 2022 15:02:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235243AbiKRPCb (ORCPT ); Fri, 18 Nov 2022 10:02:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242181AbiKRPB3 (ORCPT ); Fri, 18 Nov 2022 10:01:29 -0500 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D420A922CD for ; Fri, 18 Nov 2022 06:58:20 -0800 (PST) Received: by mail-wr1-x434.google.com with SMTP id x5so5555687wrt.7 for ; Fri, 18 Nov 2022 06:58:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Nw23Nf2ywm0G6Jdy8jtkPxH6JRwBmcWd0JpF48UwDnA=; b=EfbDeo6h2MKp54ozSgIaeVTNnyv1UmDOJvMSjDWuUlhiM1DGNEcXVI5Py3MrQm/mTB EPOgxoTUuHZYEn5QzkIboSMSVIRx//32C3hmhPLM6XxeUI2CpG9kzHoaEg0AyWpHoQSU tkZilxvZKh/9BQImtaalXAX5rv1QFRpcaDPk2waLrk0dFvM04sAXXDJMtgT0c/nFgm0J 4qU4JPPc8eobijy13xR3EZfDU7fjGvniswS3wWOXkY0SmQH5x/yM6Kwe2Hvh6jyb4NHZ eZa4DBCbRiuKCexlah52t3UT1w1leBDFv9X/3u0kjRMeke4zPKKzaiyr16cEFZ4GK/dB PkrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Nw23Nf2ywm0G6Jdy8jtkPxH6JRwBmcWd0JpF48UwDnA=; b=t7GojXvbWitKkK2ShqR+U0rb/JEBsO7qjWKpDIK7TmZ7c5DeSdW2/2U3URVMmXg+6w rv367YJm6ma0pO8/KPwP8X06YBtfSDpvteLdATCnLmDaXY7kyeDz0eZ+i7gKfYStv+Vy 8prMskiTYwzSZBBDPn2xd+Kpu7JwUlNGyNUlyHy4Bv1F2HPWxhhWrzRiagK0ze0zaX+v asz8jhMZ0CqJRfqeIQT+jD0vr+YAWQHmJzGRZmfKRPBwxLG1Sypm0exJSu81lwVNiao9 eM1lFhLU1V8kIF8cfMc8QplhIzbiOXQhmw6EoVOphB+F+56+72nnmBd/o9IE7eCnSlcX ZJyw== X-Gm-Message-State: ANoB5pkKZzuJo6c+sx7qyFU0zcTPHahN+e7R7jnKyOZYtFhuv6l5pARf F6x1SX6Jq7vrPyaGpSD/fbgVuNrX0xZbDg== X-Google-Smtp-Source: AA0mqf4+t3xWJIqhJSWh3vn3rZsaF4mL/rObMjJPqCSIHYtK1YNzB8OFep9EeMGw+ZKrtpe+MXV3ow== X-Received: by 2002:a5d:4ac4:0:b0:22c:f296:1120 with SMTP id y4-20020a5d4ac4000000b0022cf2961120mr4322781wrs.369.1668783499360; Fri, 18 Nov 2022 06:58:19 -0800 (PST) Received: from ?IPV6:2a01:e0a:982:cbb0:f7cc:460c:56ae:45a? ([2a01:e0a:982:cbb0:f7cc:460c:56ae:45a]) by smtp.gmail.com with ESMTPSA id o9-20020a056000010900b00228692033dcsm3676836wrx.91.2022.11.18.06.58.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Nov 2022 06:58:19 -0800 (PST) Message-ID: <15ac1d06-5da7-ebd2-92ff-764c8df803a1@linaro.org> Date: Fri, 18 Nov 2022 15:58:18 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.3 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 03/10] arm64: dts: qcom: Add pm8010 pmic dtsi Content-Language: en-US To: Krzysztof Kozlowski , Abel Vesa , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List , "vkoul@kernel.org" , Srinivas Kandagatla References: <20221116103146.2556846-1-abel.vesa@linaro.org> <20221116103146.2556846-4-abel.vesa@linaro.org> <76560659-7c90-3846-c250-24bfb072ec0e@linaro.org> Organization: Linaro Developer Services In-Reply-To: <76560659-7c90-3846-c250-24bfb072ec0e@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/11/2022 13:51, Krzysztof Kozlowski wrote: > On 16/11/2022 11:31, Abel Vesa wrote: >> From: Neil Armstrong >> >> Add nodes for pm8010 in separate dtsi file. >> >> Signed-off-by: Neil Armstrong >> --- >> arch/arm64/boot/dts/qcom/pm8010.dtsi | 84 ++++++++++++++++++++++++++++ >> 1 file changed, 84 insertions(+) >> create mode 100644 arch/arm64/boot/dts/qcom/pm8010.dtsi >> >> diff --git a/arch/arm64/boot/dts/qcom/pm8010.dtsi b/arch/arm64/boot/dts/qcom/pm8010.dtsi >> new file mode 100644 >> index 000000000000..0ea641e12209 >> --- /dev/null >> +++ b/arch/arm64/boot/dts/qcom/pm8010.dtsi >> @@ -0,0 +1,84 @@ >> +// SPDX-License-Identifier: BSD-3-Clause > > Any reason why this is licensed BSD-3 clause? It's not a recommended > license (2 clause is). Same for other patches. Probably a bad copy-paste from other existing files. While checking, the majority of arch/arm64/boot/dts/qcom/pm*.dtsi uses BSD-3-Clause so it seems this was done for quite a while now. > >> +/* >> + * Copyright (c) 2022, Linaro Limited >> + */ >> + >> +#include >> +#include >> + >> +/ { >> + thermal-zones { >> + pm8010-m-thermal { >> + polling-delay-passive = <100>; >> + polling-delay = <0>; >> + >> + thermal-sensors = <&pm8010_m_temp_alarm>; >> + >> + trips { >> + trip0 { >> + temperature = <95000>; >> + hysteresis = <0>; >> + type = "passive"; >> + }; >> + >> + trip1 { >> + temperature = <115000>; >> + hysteresis = <0>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + >> + pm8010-n-thermal { >> + polling-delay-passive = <100>; >> + polling-delay = <0>; >> + >> + thermal-sensors = <&pm8010_n_temp_alarm>; >> + >> + trips { >> + trip0 { >> + temperature = <95000>; >> + hysteresis = <0>; >> + type = "passive"; >> + }; >> + >> + trip1 { >> + temperature = <115000>; >> + hysteresis = <0>; >> + type = "hot"; >> + }; >> + }; >> + }; >> + }; >> +}; >> + >> + > > Just one blank line. > > > Best regards, > Krzysztof >