From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87D8CECAAA1 for ; Mon, 12 Sep 2022 11:00:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbiILLA6 (ORCPT ); Mon, 12 Sep 2022 07:00:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229861AbiILLA5 (ORCPT ); Mon, 12 Sep 2022 07:00:57 -0400 Received: from mail-lj1-x233.google.com (mail-lj1-x233.google.com [IPv6:2a00:1450:4864:20::233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 804EA21E04 for ; Mon, 12 Sep 2022 04:00:56 -0700 (PDT) Received: by mail-lj1-x233.google.com with SMTP id by6so10048102ljb.11 for ; Mon, 12 Sep 2022 04:00:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=VNRLB5dMr8KxcMuJauPpZNtGEDYIcFeLhKYuKfQ2WK4=; b=Wr271pDa4rYLOMj1WYVJWc+MhXbFaiyoYNkavxMyqSK0firTu7PnHjPX39Rgx7kg6O stiKUajPEgJzCGa8pAk3WO8Qc91CsGQGrOY8LJ9j52EVVd1MgNPN3WaVUuEJnJN11u4b Qpg5WIoDM7DlRIOn4EJIs4ZEtbl9xc8upENfntB+G01YNTtdBEv/YwlO25SJuNNc/nL6 a3+S9EEJWQBLPyv5sAJ4LR/Wj54TYjrFhtt0kPua0B2frGbW9lGlwZ1V6Oqz7i7sx03d yGtQxThRzGLvFRlb8Np9yms1PBoIZPkKtHK6nE3JHQPr1W9wN+R147UYGbkNUD7oxVWm S0PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=VNRLB5dMr8KxcMuJauPpZNtGEDYIcFeLhKYuKfQ2WK4=; b=GodV/5R1PAMy/GCVilsYid9wjSYaBqK5iGZ6pSqJMjkcXshFJD0zy/Y2Ynp1eIxGUy AwXz3ZDgaNluPnAWe8MSEPexw5sI6xqUn+MTep+QsICBBMB984Yae96zFLKM+vRHsM3u 4P760RhLzjf3h/0+sJ9qg53Pkj+noJj7yU7sBX8UjixeRT1cL99h9tfGLbxe/PgPxIDj en//TGoMzks7NeAw5rby/6ssSFGCxvk82zTTCVP1Cu6VA0No0Z89plsOCdOXNmh5XydU tkEtmfUm95shGuQNhy/JT/GpSnz9BKinau8GBTcUVKINj4K5LLdszUClQQmvyYOVtrk+ c0QQ== X-Gm-Message-State: ACgBeo1o1V89LumJOf5Y7iEXwFEqQMp9DY0UlZOh95SeIEiTVTWRlZaU Iatt8xbDs5dTINFNSDgm8RhCDQ== X-Google-Smtp-Source: AA6agR5qUmM2ZmB3u+ceQgLmGH1b3qt0oNh2whK2G3kPo3FfMoZ57icsO07DBG7SNBSMhG5XpY/UNg== X-Received: by 2002:a2e:9801:0:b0:25e:45ed:edc5 with SMTP id a1-20020a2e9801000000b0025e45ededc5mr7229723ljj.467.1662980454897; Mon, 12 Sep 2022 04:00:54 -0700 (PDT) Received: from [10.129.96.84] ([109.232.243.34]) by smtp.gmail.com with ESMTPSA id v6-20020a197406000000b004979df1c1fasm1010823lfe.61.2022.09.12.04.00.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Sep 2022 04:00:54 -0700 (PDT) Message-ID: <15b65ac4-6656-dec5-80fd-e3c29b226a25@linaro.org> Date: Mon, 12 Sep 2022 13:00:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH 6/7] arm64: dts: allwinner: h616: OrangePi Zero 2: Add USB nodes Content-Language: en-US To: Andre Przywara , Jernej Skrabec , Samuel Holland , Chen-Yu Tsai , Kishon Vijay Abraham I , Vinod Koul Cc: Rob Herring , Krzysztof Kozlowski , Greg Kroah-Hartman , linux-phy@lists.infradead.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Karl Kurbjun , Icenowy Zheng References: <20220911235945.6635-1-andre.przywara@arm.com> <20220911235945.6635-7-andre.przywara@arm.com> From: Krzysztof Kozlowski In-Reply-To: <20220911235945.6635-7-andre.przywara@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 12/09/2022 01:59, Andre Przywara wrote: > The OrangePi Zero 2 has one USB-A host port, VBUS is provided by > a GPIO controlled regulator. > The USB-C port is meant to power the board, but is also connected to > the USB 0 port, which we configure as an MUSB peripheral. > > Signed-off-by: Andre Przywara > --- > .../allwinner/sun50i-h616-orangepi-zero2.dts | 42 +++++++++++++++++++ > 1 file changed, 42 insertions(+) > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts > index 02893f3ac99d..3197dc43397b 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-orangepi-zero2.dts > @@ -49,8 +49,25 @@ reg_vcc5v: vcc5v { > regulator-max-microvolt = <5000000>; > regulator-always-on; > }; > + > + reg_usb1_vbus: usb1-vbus { Generic node names, so at least generic prefix/suffix (regulator-usb1-vbus) > + compatible = "regulator-fixed"; > + regulator-name = "usb1-vbus"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + vin-supply = <®_vcc5v>; > + enable-active-high; > + gpio = <&pio 2 16 GPIO_ACTIVE_HIGH>; /* PC16 */ > + status = "okay"; No need for status. Best regards, Krzysztof